From patchwork Tue May 23 03:55:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Gan, Yi Fang" X-Patchwork-Id: 97721 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1879442vqo; Mon, 22 May 2023 21:05:25 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6ne0EnRJXm2LV+gDzL2P0kNh2yyEmG+Xrzz3kcsUyUikqXn4Ruv/DG++rc7gak8ACWYTxY X-Received: by 2002:a05:6a21:9201:b0:ff:b564:c532 with SMTP id tl1-20020a056a21920100b000ffb564c532mr12305937pzb.43.1684814724690; Mon, 22 May 2023 21:05:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684814724; cv=none; d=google.com; s=arc-20160816; b=MzgoUVP2EuNfw5o0Unz+o//Ps4AtjW1CzNXudmsdkx38Lyw7DmmNnMzox298p5n9/N Hpd4KQF+tPIRws3rdsnYeTw2v2vVH2DUTAaSFVEfdnL6Gydb3/MfnFeKwdZFzf5gtFc2 j0G7A10NHvqn5fnvM/2ijoAtWpsuaEAmkX/FumSrhiLlmuDxDiaJAtc32yKxSBw0Yk2A 6WADfbIizhFtyN9Xu7IuFWySmZzPF0BeMEy80LpUzrbitn2LtDHuWBt/LJCj8XdjZmKK 1UT47lapUhEvEVDfzNpzLxePDPa3AcN+c4Ze+4ZtldknbTuEEtYZ+XwUEUCqQEnz2LmZ /Rjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=XOwI9zzx3UJYobf96lJIEe8i6rhkj/gDLVlyWRH4kEo=; b=XItYUDyxjq8HmXWT7w9lPDa8WFIqNeFZPnU4U9BA2xcADO/OCkU5cC3UFOTqXINYA0 WOrtsiWr430RJMXUQKmG9puUzYx9vEH9n1dj1gNxVzKC0bMwg5dmJHEcnQYZh/sqzxqV s4tk/Vs38wx9cS+Cbs8ESqnOIkqgwSX2jsaI6YAUATlR7wCDPeZV+I9aup7VaFh/ace0 Fn+5zRly9O8KTIePos7H7S/5LzemmTfxkH+rlsERmtlMUZswo5BLCEAqqfPId+JUgSum CiLP1u8Ip2JiEM4u0RWJJwxF2d+YkqUOL+tslLDiSs8/wvouZRAWKEb4p8X8Pbai4Ows Y2fA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=GO05ctuD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r12-20020aa7988c000000b0063d30a836e1si4097896pfl.244.2023.05.22.21.05.12; Mon, 22 May 2023 21:05:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=GO05ctuD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234354AbjEWD4f (ORCPT + 99 others); Mon, 22 May 2023 23:56:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234347AbjEWD4b (ORCPT ); Mon, 22 May 2023 23:56:31 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49D15120; Mon, 22 May 2023 20:56:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684814183; x=1716350183; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=kv+U3eR2t5jXrzu7bhE+tT5rUsZNuQI3uVH6Dk7rusQ=; b=GO05ctuDT4THeaWR4P76lv2IV/SZoF76y7xB2Jly9HMlpTXuGZTFlck8 rtPDaZCCN4Eo7oL9FiYUucqUBMCFm30oMSAd0e/B0L4zvvjLrR2DL1Th8 T+AJpMbYfEVCrcKz10zEyM6GpeAWXznbAXt/75Ub8pjV1tNrSS7k8IFPb rVGU13lFpavVZi3DcXMzLB87ULmsDGnie4TfGL7yVZrwFFKqHwT99N+Ju vMwSbG7OOGR9AN0C3U+Na1GyiYs+bRz6SygABKbGSmRYr9p7VlAMegcjD gM5po7dlI2WicW2UPJJdQRW+SFvaotJv/VtMo4D2PKJpSmm7l6mqy83vj A==; X-IronPort-AV: E=McAfee;i="6600,9927,10718"; a="342577144" X-IronPort-AV: E=Sophos;i="6.00,185,1681196400"; d="scan'208";a="342577144" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2023 20:56:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10718"; a="681240866" X-IronPort-AV: E=Sophos;i="6.00,185,1681196400"; d="scan'208";a="681240866" Received: from ganyifangubuntu20-ilbpg12.png.intel.com ([10.88.229.31]) by orsmga006.jf.intel.com with ESMTP; 22 May 2023 20:56:19 -0700 From: Gan Yi Fang To: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Jakub Kicinski , Paolo Abeni , Maxime Coquelin Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Looi Hong Aun , Michael Sit Wei Hong , Gan Yi Fang Subject: [PATCH net 1/1] net: stmmac: Remove redundant checking for rx_coalesce_usecs Date: Mon, 22 May 2023 23:55:48 -0400 Message-Id: <20230523035548.188651-1-yi.fang.gan@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.1 required=5.0 tests=AC_FROM_MANY_DOTS,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766656284735286799?= X-GMAIL-MSGID: =?utf-8?q?1766656284735286799?= The datatype of rx_coalesce_usecs is u32, always larger or equal to zero. Previous checking does not include value 0, this patch removes the checking to handle the value 0. Signed-off-by: Gan Yi Fang --- drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c index 35c8dd92d369..6ed0e683b5e0 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c @@ -917,7 +917,7 @@ static int __stmmac_set_coalesce(struct net_device *dev, else if (queue >= max_cnt) return -EINVAL; - if (priv->use_riwt && (ec->rx_coalesce_usecs > 0)) { + if (priv->use_riwt) { rx_riwt = stmmac_usec2riwt(ec->rx_coalesce_usecs, priv); if ((rx_riwt > MAX_DMA_RIWT) || (rx_riwt < MIN_DMA_RIWT))