From patchwork Mon May 22 20:57:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 97617 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1715184vqo; Mon, 22 May 2023 14:00:34 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ45cAk6FkKYJESrcchNsCrnCFeMCTzC9V1otTfOw4fe0oD/Nq2/2cO6nrBoLH81iXbDiVFN X-Received: by 2002:a17:902:daca:b0:1ad:dbea:6e09 with SMTP id q10-20020a170902daca00b001addbea6e09mr14623646plx.66.1684789234055; Mon, 22 May 2023 14:00:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684789234; cv=none; d=google.com; s=arc-20160816; b=W/mn4ibUIonJDbMjYXcBgIglMYci7rIq/XsjIsp4pqOdywOY7RImCK+wMU5ZNn26aP PzoupvP4/s5fsfU33x9PnhM7FW/eQeTfYAIlYWIhtS+uxDL1W7RPwn8+h0DtZIeWaYBH SOkjAH4diwRZfgMhBCZY+cstRkU7N+JOfDCnui5P9wdvlTyA6tZJKEDTQUGHmds9Hn3q vafHUPJV0Rh+8+a6XIqKIVhNh+bk7Tw0iN2IkxJLsdK7avXY+XlJtMBdwwJFUr5dugGQ L3U2vvpkKIE2z1tbLQGSP+VnzYSIG9MsEkzF/e5vA8NMoicQOz9LDwOVG/mQGk8Gpccd XYug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=oZIY9GTPXEPoSMZhe+ryqBhZXmHTyjPJq3hYdlaANCY=; b=mLuACHuMRj6WOLdtuRsEBn+wL/7HIIf3/GX+qwm8951bhzXWH8wGlO7/66N/2DPfPq L1gl10qa2KWZKehW0NFGXm+mN6emJGyOuzxcJllEXsg+NvRalDnV1R/s4hQXA0FTIeoK yFjLgtd0KGIcKAVl0NXjMMGkdtiucWKO/S651En1TjojLhrLynNQDzs1HWqb5XSXoDR/ 6SbjraPo+omouojpoD/nqRVKm/J0A59wKqcU90F+TsWeX9WLcmWE/SvN4CU9f++oHOUM 0E9zaYRuvdN56J5qJLK13XBLhqkuIYsgQQTrAdi2270PuxkTWPl8CNf7Rd+xG8wEgU66 m8Uw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MoY4Ojos; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id iw1-20020a170903044100b001a63a7b7025si5137065plb.30.2023.05.22.14.00.18; Mon, 22 May 2023 14:00:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MoY4Ojos; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234728AbjEVU65 (ORCPT + 99 others); Mon, 22 May 2023 16:58:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234641AbjEVU6p (ORCPT ); Mon, 22 May 2023 16:58:45 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 478F6BF for ; Mon, 22 May 2023 13:58:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684789079; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oZIY9GTPXEPoSMZhe+ryqBhZXmHTyjPJq3hYdlaANCY=; b=MoY4OjoskLooqeppXLTciFeL2Fj5ImoCxNXgjD4VK9WDd+1XuA4TBK5oWh8eiq0hBKbPIN ds7AP6tbgW92L+QH2OiezI6J1tXDBYfuWQACVo0Z95Zp5QIjDa/GAxmvW/bXJYLHL0LxOW o9ymf6QCQdJUJUZ8vAyXd60k4zxlzC4= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-580-uxNl4WjbMQmkgPs6MbWOuQ-1; Mon, 22 May 2023 16:57:53 -0400 X-MC-Unique: uxNl4WjbMQmkgPs6MbWOuQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3732F28EC104; Mon, 22 May 2023 20:57:52 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.39.192.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9B2D02166B25; Mon, 22 May 2023 20:57:49 +0000 (UTC) From: David Howells To: Jens Axboe , Al Viro , Christoph Hellwig Cc: David Howells , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, John Hubbard , Dave Chinner , Christoph Hellwig Subject: [PATCH v21 1/6] iomap: Don't get an reference on ZERO_PAGE for direct I/O block zeroing Date: Mon, 22 May 2023 21:57:39 +0100 Message-Id: <20230522205744.2825689-2-dhowells@redhat.com> In-Reply-To: <20230522205744.2825689-1-dhowells@redhat.com> References: <20230522205744.2825689-1-dhowells@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766629555719801147?= X-GMAIL-MSGID: =?utf-8?q?1766629555719801147?= ZERO_PAGE can't go away, no need to hold an extra reference. Signed-off-by: David Howells Reviewed-by: David Hildenbrand Reviewed-by: John Hubbard Reviewed-by: Dave Chinner Reviewed-by: Christoph Hellwig cc: Al Viro cc: linux-fsdevel@vger.kernel.org Reviewed-by: Jan Kara Reviewed-by: Christian Brauner --- fs/iomap/direct-io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c index 019cc87d0fb3..66a9f10e3207 100644 --- a/fs/iomap/direct-io.c +++ b/fs/iomap/direct-io.c @@ -203,7 +203,7 @@ static void iomap_dio_zero(const struct iomap_iter *iter, struct iomap_dio *dio, bio->bi_private = dio; bio->bi_end_io = iomap_dio_bio_end_io; - get_page(page); + bio_set_flag(bio, BIO_NO_PAGE_REF); __bio_add_page(bio, page, len, 0); iomap_dio_submit_bio(iter, dio, bio, pos); }