From patchwork Mon May 22 19:50:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 97583 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1694003vqo; Mon, 22 May 2023 13:15:42 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4DNl1Do17O5ewFy54Xo1Z3rDXhwjYtabgtwQdTOZxxwLYNdmhiiHPCmNIt0rY6g1JIEnw/ X-Received: by 2002:a17:903:18b:b0:1ad:d995:54a with SMTP id z11-20020a170903018b00b001add995054amr13044675plg.46.1684786542323; Mon, 22 May 2023 13:15:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684786542; cv=none; d=google.com; s=arc-20160816; b=usUk3HRQ7mtqxixUt85POLQ+8rweJWaTCH5wnfE25KwB/bOOCuhKTjsrbni2VP6DvX JNbmbqtTQj5X+KmWmJWrO318VpipuEgEgpZb8nn0JchjvxtHX6Mp+ShAoKYzEfGvwmXl Z1eL3FuNU9lvhkpN1Dh+bXxFQmOgUeY5HQtklki+L0Omz8tPQz05UGWzS8I5C6gDV3Ol xj7GYXg5BMnaE2WFUFlGCU7W+LDr0pLDF/n73Z26L36X12M+2MXQy2nLVQLjLYxSs95T R1S6yG18j7zfKsAVspm7EfAU+rLMfKVPxod12RrS5H79Ba0QUf2YijD/EFf9fK5+cL+T y5Ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=WgHhOacVrxc6HGxdFM6k0YTyCIMBmDtAEJ1yeJMrcnc=; b=chLCPEvQ+eirdIyoXf1MS/B8iB6aQICiSHQvtRzJaueOZxyeUf9e34I6Dm7BtlJzgF 1uk1s3bnRSzhqGpieW1Y3WheY4BjsddJIAV2S2oxDR32PWEkt1yjtQd1VJYxwC/KihtB w+Vx2vRVnzjYhotSla5biRWuJSDpzFHwnu9nyPwbcLGdXY9Mkslyu4nDv1EL1LeiDGtH gKymHIPYONRUh9C+TvfNekNoJRECWny8I3BNsrILulNbZ5zHwb0d3DqCsQxgTQKjw58M uAXOWF02vbhAufFXjlQFZHZoKJ+YFtD3ME6WyMySlOfke7OjaCAd3E9RqoIH4GzVxx9h U/Ig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LTCRW8mv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c8-20020a170903234800b001a923bc3af0si4755941plh.544.2023.05.22.13.15.27; Mon, 22 May 2023 13:15:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LTCRW8mv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235451AbjEVTvA (ORCPT + 99 others); Mon, 22 May 2023 15:51:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235391AbjEVTur (ORCPT ); Mon, 22 May 2023 15:50:47 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A3D1C1 for ; Mon, 22 May 2023 12:50:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 21DA362AF9 for ; Mon, 22 May 2023 19:50:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EBC0FC4339B; Mon, 22 May 2023 19:50:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684785044; bh=DHB3E3whHUuZqeuu1DX7URmHv9V7oPFeShT/zXTe+DA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LTCRW8mvE+v+Qu9tfP6jNx3wcAib4AscGGz4Yi3vX0P6du6+fNQkfijJ4gOBxUEKV ZtPnFk9Dp7WlkzMvR/pj6r+WRzYXOpj6du4PA9p1dNnC21g4h5MhBqQF18eMM/otmD a6XRLVpIfXIsOvU3jIU0timMeTB/HBUDeNhW4OxfyQKctWeMgQD52yYGU7L3NGVUgI eZOXGbIiXYSC7Bn/CxAkj1A8L7FM754F756W9iiwwRdDOUpC86ogUwrTw/a83Bb0cS zpBzW+Ge7GZOtaQTDxMdtUE0NsMQ+M5JCA7WQvAlIzIVqJGiPW7JJdtaCRUkFKyKDW 9W56i/cl8X8Iw== From: Arnd Bergmann To: Ingo Molnar , Peter Zijlstra Cc: Arnd Bergmann , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , linux-kernel@vger.kernel.org Subject: [PATCH 4/5] sched: make task_vruntime_update() prototype visible Date: Mon, 22 May 2023 21:50:20 +0200 Message-Id: <20230522195021.3456768-5-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230522195021.3456768-1-arnd@kernel.org> References: <20230522195021.3456768-1-arnd@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766626733660183373?= X-GMAIL-MSGID: =?utf-8?q?1766626733660183373?= From: Arnd Bergmann Having the prototype next to the caller but not visible to the callee causes a W=1 warning: kernel/sched/fair.c:11985:6: error: no previous prototype for 'task_vruntime_update' [-Werror=missing-prototypes] Move this to a header, as we do for all other function declarations. Signed-off-by: Arnd Bergmann Reviewed-by: Mukesh Ojha --- kernel/sched/core.c | 2 -- kernel/sched/sched.h | 1 + 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 044bcdf4181a..aae6ff717c55 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -6030,8 +6030,6 @@ static inline struct task_struct *pick_task(struct rq *rq) BUG(); /* The idle class should always have a runnable task. */ } -extern void task_vruntime_update(struct rq *rq, struct task_struct *p, bool in_fi); - static void queue_core_balance(struct rq *rq); static struct task_struct * diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index 44b34836bb60..d5ac0af1eede 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -1245,6 +1245,7 @@ static inline raw_spinlock_t *__rq_lockp(struct rq *rq) bool cfs_prio_less(const struct task_struct *a, const struct task_struct *b, bool fi); +void task_vruntime_update(struct rq *rq, struct task_struct *p, bool in_fi); /* * Helpers to check if the CPU's core cookie matches with the task's cookie