From patchwork Mon May 22 17:03:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Reichel X-Patchwork-Id: 97547 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1597461vqo; Mon, 22 May 2023 10:08:36 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6Un7sm+8BGuHJ1Uo0E9SUBbDS++n0rdr7NtPDsTpkY84xLfE4xFzHDi30j6CuRgBdihs2X X-Received: by 2002:a17:902:c111:b0:1ab:1b8:8a5f with SMTP id 17-20020a170902c11100b001ab01b88a5fmr10588360pli.33.1684775315977; Mon, 22 May 2023 10:08:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684775315; cv=none; d=google.com; s=arc-20160816; b=Gkv/8VRFvF4g+hXYphshqBjO/97Qb61W7COQb/zWUb2R1dCoHyLriy1IASbj/VAN4j Z6of+dks4iBhXTh+wNz6ewmUNDsVklQsE+RrMx/N8MqTWugGgpBU52uff6aQfIIy8rj/ O2ITZxrzSfI9xeVRnI9Fs/iKN+oHtDnNR5eTB9aqZD9ffTlsNlx4+RDPeydmOP5iYQos 0hO0eJ47m3ixfVDjxCvWHkCHlQ1/uzGrHK1sC1oHSDRrfh6f68NZF69qqmSTRSEyaMbQ Gjit62a4KMndOczYguxdkcdU259pbjDgMh6cynwBIPQxgsYN31zMZwYoBKvZnIEUluu3 AEJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=GctqNwC3kPlSUc45fRPhNWXEs1X3QuuTc5TTkbGLQrc=; b=QbZbt0JdYzSFM79lswfWQBaBXGC+h5p5rBarT9VpY1KBEGR8asZblzFQNfqSlZ6Z8S smLJVNNPN8O6NN/DSOIegKlsWfhTjHKH/jYU1FD4lgy3n6mmbckLflNVoMw5zOHsrwQQ K8De3nc5LrX317ei7t6w4hL3Rpz/TZTIUD+7wOsNdXiSiTQjuVuR+NOe6Jx9gmvnz1k4 koJjk0+/L3D5O0L0wd/vPsCANLFxcPDuBhSjwjheWnoKamX8R1U7NR/ZJkGRwEsPSKON PrLaAEEs8+gUZyHGzqq/qM2H1fxEkIKTif5+Sd3DIt5GAvQEHA5E6DNmOYI2IegxGFtE g9iw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=kcI6B1fV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ct21-20020a17090af59500b00246ff7fbff8si4722218pjb.11.2023.05.22.10.08.23; Mon, 22 May 2023 10:08:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=kcI6B1fV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233545AbjEVRED (ORCPT + 99 others); Mon, 22 May 2023 13:04:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233406AbjEVRDr (ORCPT ); Mon, 22 May 2023 13:03:47 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 665F9F4; Mon, 22 May 2023 10:03:46 -0700 (PDT) Received: from jupiter.universe (dyndsl-091-248-208-162.ewe-ip-backbone.de [91.248.208.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: sre) by madras.collabora.co.uk (Postfix) with ESMTPSA id 1FAF46606E74; Mon, 22 May 2023 18:03:45 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1684775025; bh=ce34z/CXrUq2NMhvtZdCHvp4uOK1+ORwK5t6sNy10LE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kcI6B1fVLFNOtckJ7RVa23rviif43wxsc80XQ4QwZusJGSB+7f1nSpKDr/GFUZ0zV z2Gfd6YIIm7qQfN6KRW6cIT6ymgICqTG1NHQD6I3/walJPTZ/FtdtjAOMU8vp8nqMK e3clQzDzO0/qzZDWi8emT4QFEgn8nmoKf+R7pF8J9pRwpH01nfQWQzoB791PtFdpWq k9zeev7emXRL9ohg0hj+ZRNsqSPwJ8hfIr6ZQgxbz/xbNy4RUZxVOACzrQIn0PBLR6 nYXY5+V798pFtVm0cnEi3WO2ZRUM/K6zyJjXLAifHN3cduF1SVkc5JAoJq9bAL6MjZ BWoXnbSWIDyMg== Received: by jupiter.universe (Postfix, from userid 1000) id 82DD04807F1; Mon, 22 May 2023 19:03:40 +0200 (CEST) From: Sebastian Reichel To: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski Cc: Heiko Stuebner , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Sebastian Reichel , kernel@collabora.com Subject: [PATCH v3 7/7] phy: phy-rockchip-inno-usb2: improve error message Date: Mon, 22 May 2023 19:03:24 +0200 Message-Id: <20230522170324.61349-8-sebastian.reichel@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230522170324.61349-1-sebastian.reichel@collabora.com> References: <20230522170324.61349-1-sebastian.reichel@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766614961485087944?= X-GMAIL-MSGID: =?utf-8?q?1766614961485087944?= Printing the OF node is not useful, since we get the same information from the device context. Instead print the reg address, that could not be found. Signed-off-by: Sebastian Reichel --- drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c index f5c30f117cba..b982c3f0d4b5 100644 --- a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c +++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c @@ -1377,8 +1377,7 @@ static int rockchip_usb2phy_probe(struct platform_device *pdev) } while (phy_cfgs[index].reg); if (!rphy->phy_cfg) { - dev_err(dev, "no phy-config can be matched with %pOFn node\n", - np); + dev_err(dev, "could not find phy config for reg=0x%08x\n", reg); return -EINVAL; }