From patchwork Mon May 22 11:50:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 97334 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1388116vqo; Mon, 22 May 2023 04:56:07 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4LUQGJc49CDhVyz05fLlJtkPwqTnWM+DV0UxwyuiO7NRICK0k6KWj/YaQTJ6VadxLbXdYG X-Received: by 2002:a05:6a00:f88:b0:64d:2db5:f792 with SMTP id ct8-20020a056a000f8800b0064d2db5f792mr11265807pfb.2.1684756567232; Mon, 22 May 2023 04:56:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684756567; cv=none; d=google.com; s=arc-20160816; b=V5PsA+z+dQIHrETWZtU/FrApOYDeIbM82xp5/cpWWXVZ9dUzBeaWPkH5rljrWEmxXA JwRDH1XvmPdN8Bic2bQ07rzuOi3Ui2bRnlXWHcj3uTWPCgvsX7SBu9bmtIOIcR+RfDGe 7s9CakI2JjZX9fEWILXwMwT8/U/eFcDc3FWaG9Bj7ylyKU+wCqy6eWomSp0J1o7Emtqb 1eTuFnBcxGQvQqVLsjvDae3QsOqj1hCcjggM3DJZU5sFwtMTbHaCxxCpqcSEEGvHJDCT ejsGYVJLdeqF2/ssW5ucu3beNl2NsV7M07rEyVrEbuMfnQhhBOpCWHn13r6g3YvmasLp OKzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=+FX0YKQnSkl+3Eo5BAsijPilUjepYEu0nnKSimylLaQ=; b=ubEh8hOwaF3nmkhwORIIb6uhYBYyEWZtKgZapkn+DrFgE+AAAPt680GmEfQC8iVoUT 9kfnyek9W4uwZX/WRYI5Wf+caADGZe216dstle6hP7VbFtkJ5ooHXSPpEehtRc3PKSkG qYF9dhfBAeAuQbeabnY77bYHAhseYV7o7cWk0LdZcHKUy79y4RXjCb8OhZR4y2NGN+Xy 1YA8u1VOMfzjogUGQB8p1kunv6od6jlopX+HwrFD322n5VQwcBv8epamAMOioYvlijY4 K6sixLPtf2b7KjCHlARy2pp/oECiC68lTQKcLCCyagbtF983/HYTvdPknaEqaNF/Q0zO 6MEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lsvk8ncs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p188-20020a6229c5000000b0063f2827e1dasi1751pfp.184.2023.05.22.04.55.55; Mon, 22 May 2023 04:56:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lsvk8ncs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233482AbjEVLv7 (ORCPT + 99 others); Mon, 22 May 2023 07:51:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233322AbjEVLvl (ORCPT ); Mon, 22 May 2023 07:51:41 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C012DA1 for ; Mon, 22 May 2023 04:51:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5DFB3611AC for ; Mon, 22 May 2023 11:51:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE2EBC4339B; Mon, 22 May 2023 11:51:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684756279; bh=TRV8Ny4PJMXTeyf3oIo1EZT/b+jnBF0oOM2xdHt1ejw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lsvk8ncsJzq6J/GHSZvjZVawAB94qDoWC6ys2sgjuJaP5QNX10ARI3Qp5eL8l1VVq 9MTWkFCzshBJdQfHusdOiTCdXKTM8r2bpRwDXPIp5o81CBHnR6/ZyjbvFoGdENPb+h Wavnsq+Hzzu77LtogSIvbxOdUyf5HySLQRz+dLNHw/X4yHfvVVnWqF0NXPtwUPqJ0y zPN3DV0/8tr3p3U/16CpyXY+q5fUZOcH2FqpFmnKGzBASV/4VVpio4vJ/qU3wkA2RX OLvBYSEXWqIRs7ghJPmG1fGg7DxfPSZMj2dyQlkaLmsPkGAPXM54JGDlAloZWJWvK9 E1a3u8u34pR4Q== From: Arnd Bergmann To: Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter , Felix Kuehling , Rajneesh Bhardwaj , Harish Kasiviswanathan Cc: Arnd Bergmann , Hawking Zhang , Le Ma , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/5] drm/amdgpu: use %pad format string for dma_addr_t Date: Mon, 22 May 2023 13:50:31 +0200 Message-Id: <20230522115047.1169839-4-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230522115047.1169839-1-arnd@kernel.org> References: <20230522115047.1169839-1-arnd@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766595302171440923?= X-GMAIL-MSGID: =?utf-8?q?1766595302171440923?= From: Arnd Bergmann DMA addresses can be shorter than u64, which results in a broken debug output: drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c: In function 'amdgpu_gart_table_ram_alloc': drivers/gpu/drm/amd/amdgpu/amdgpu.h:41:22: error: format '%llx' expects argument of type 'long long unsigned int', but argument 4 has type 'dma_addr_t' {aka 'unsigned int'} [-Werror=format=] drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c:146:9: note: in expansion of macro 'dev_info' 146 | dev_info(adev->dev, "%s dma_addr:%llx\n", __func__, dma_addr); Use the special %pad format string and pass the DMA address by reference. Fixes: d020a29b6b58 ("drm/amdgpu: Allocate GART table in RAM for AMD APU") Signed-off-by: Arnd Bergmann --- drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c index a070adf30c88..73b8cca35bab 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c @@ -143,7 +143,7 @@ int amdgpu_gart_table_ram_alloc(struct amdgpu_device *adev) return -EFAULT; } - dev_info(adev->dev, "%s dma_addr:%llx\n", __func__, dma_addr); + dev_info(adev->dev, "%s dma_addr:%pad\n", __func__, &dma_addr); /* Create SG table */ sg = kmalloc(sizeof(*sg), GFP_KERNEL); if (!sg) {