From patchwork Mon May 22 10:54:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Yang X-Patchwork-Id: 97297 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1366625vqo; Mon, 22 May 2023 04:15:38 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6hrNgFalFWvVLV2zVEhmm444q6csFjvCdyJ4xi3atEU0bSZ/S9dbAfvFMaGdHranQboLjq X-Received: by 2002:a05:6a20:9f92:b0:106:c9b7:c93d with SMTP id mm18-20020a056a209f9200b00106c9b7c93dmr9650696pzb.19.1684754137917; Mon, 22 May 2023 04:15:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684754137; cv=none; d=google.com; s=arc-20160816; b=Wkid6LLOtC40+dVpWwHwkaniBZQysmP8/5KzhUkC4MqfTHjwcEKRRJbwN+7JnEJIXm XfcBKcaSKHwXgNJmArLwyo9CR8VqTb2mUTQGXzhjwb26OW/JFH1TOINEN2wl30+f5DNw gEmvUjkuc5p8qhTPZ9b3zz3Fk+9WoNqmG7fonn4iRr5+Z8hRmfM9+Nugrd+6MsToBYKX mfscx8kYa17gzoYf0IkG4o13lVW6iqwm7Uh9rhcmPyfUorulu4zoFhVIWO7B3TusERan V5dHUohTzrUjSE17jTHCfs5qq95MCsWTApN90BkUCxd1H3dkSJjunEE6pIHbSkbbePD9 QsWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=E5v3OA97PzwcyWc2mCPAWgEmQ1PwlOzYoY5ZvYxibKk=; b=oRrQqWVCczo9yrRgRvgiiozgaj3fpjtWEerWGwzFNrz2PH4yU+6g7vSe5omkP/fiuT H54zcRewPoLGir1QIOhFMEtD1E4wOZ+CGoRYXbFw5l1uH576d2tTsZRF6mh3oU+ldvq+ Cb/1NqDhGO9f00Wpv0CdVQ4gAbO6uuVgwaCFLrzfxfabGchyb80mMKBhvTwVVgVXCI/7 ruKnzxHzHDhlhX6sZ39O+IMNxSPd6X37GXob1mTR8KSkkvEAO3p1jOBF1CmDr8dqFqz2 0PKQyvx7xiKNnEGyOw/TdDc2zMgMAvjplY/heaKQ9eXiDgpzXzPqbAV4ktlZxR87ciGb lhoQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ep5-20020a17090ae64500b002534791ea59si425373pjb.28.2023.05.22.04.15.25; Mon, 22 May 2023 04:15:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231232AbjEVLLq (ORCPT + 99 others); Mon, 22 May 2023 07:11:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231429AbjEVLLO (ORCPT ); Mon, 22 May 2023 07:11:14 -0400 Received: from ubuntu20 (unknown [193.203.214.57]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 882A4358C for ; Mon, 22 May 2023 04:06:15 -0700 (PDT) Received: by ubuntu20 (Postfix, from userid 1003) id ECF0DE1EF6; Mon, 22 May 2023 18:54:03 +0800 (CST) From: Yang Yang To: akpm@linux-foundation.org, david@redhat.com Cc: yang.yang29@zte.com.cn, imbrenda@linux.ibm.com, jiang.xuexin@zte.com.cn, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ran.xiaokai@zte.com.cn, xu.xin.sc@gmail.com, xu.xin16@zte.com.cn Subject: [PATCH v8 5/6] ksm: update the calculation of KSM profit Date: Mon, 22 May 2023 18:54:02 +0800 Message-Id: <20230522105402.4225-1-yang.yang29@zte.com.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <202305221842587200002@zte.com.cn> References: <202305221842587200002@zte.com.cn> MIME-Version: 1.0 X-Spam-Status: No, score=3.4 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,FSL_HELO_NON_FQDN_1, HEADER_FROM_DIFFERENT_DOMAINS,HELO_NO_DOMAIN,NO_DNS_FOR_FROM, RCVD_IN_PBL,RDNS_NONE,SPF_SOFTFAIL,SPOOFED_FREEMAIL_NO_RDNS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: *** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766592754968886300?= X-GMAIL-MSGID: =?utf-8?q?1766592754968886300?= From: xu xin When use_zero_pages is enabled, the calculation of ksm profit is not correct because ksm zero pages is not counted in. So update the calculation of KSM profit including the documentation. Signed-off-by: xu xin Cc: Xiaokai Ran Cc: Yang Yang Cc: Jiang Xuexin Cc: Claudio Imbrenda Cc: David Hildenbrand --- Documentation/admin-guide/mm/ksm.rst | 18 +++++++++++------- mm/ksm.c | 2 +- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/Documentation/admin-guide/mm/ksm.rst b/Documentation/admin-guide/mm/ksm.rst index 019dc40a0d3c..dde7c152f0ae 100644 --- a/Documentation/admin-guide/mm/ksm.rst +++ b/Documentation/admin-guide/mm/ksm.rst @@ -204,21 +204,25 @@ several times, which are unprofitable memory consumed. 1) How to determine whether KSM save memory or consume memory in system-wide range? Here is a simple approximate calculation for reference:: - general_profit =~ pages_sharing * sizeof(page) - (all_rmap_items) * + general_profit =~ ksm_saved_pages * sizeof(page) - (all_rmap_items) * sizeof(rmap_item); - where all_rmap_items can be easily obtained by summing ``pages_sharing``, - ``pages_shared``, ``pages_unshared`` and ``pages_volatile``. + where ksm_saved_pages equals to the sum of ``pages_sharing`` + + ``ksm_zero_pages`` of the system, and all_rmap_items can be easily + obtained by summing ``pages_sharing``, ``pages_shared``, ``pages_unshared`` + and ``pages_volatile``. 2) The KSM profit inner a single process can be similarly obtained by the following approximate calculation:: - process_profit =~ ksm_merging_pages * sizeof(page) - + process_profit =~ ksm_saved_pages * sizeof(page) - ksm_rmap_items * sizeof(rmap_item). - where ksm_merging_pages is shown under the directory ``/proc//``, - and ksm_rmap_items is shown in ``/proc//ksm_stat``. The process profit - is also shown in ``/proc//ksm_stat`` as ksm_process_profit. + where ksm_saved_pages equals to the sum of ``ksm_merging_pages`` and + ``ksm_zero_pages``, both of which are shown under the directory + ``/proc//ksm_stat``, and ksm_rmap_items is alos shown in + ``/proc//ksm_stat``. The process profit is also shown in + ``/proc//ksm_stat`` as ksm_process_profit. From the perspective of application, a high ratio of ``ksm_rmap_items`` to ``ksm_merging_pages`` means a bad madvise-applied policy, so developers or diff --git a/mm/ksm.c b/mm/ksm.c index 4e510f5c5938..d23a240c2519 100644 --- a/mm/ksm.c +++ b/mm/ksm.c @@ -3085,7 +3085,7 @@ static void wait_while_offlining(void) #ifdef CONFIG_PROC_FS long ksm_process_profit(struct mm_struct *mm) { - return mm->ksm_merging_pages * PAGE_SIZE - + return (long)(mm->ksm_merging_pages + mm->ksm_zero_pages) * PAGE_SIZE - mm->ksm_rmap_items * sizeof(struct ksm_rmap_item); } #endif /* CONFIG_PROC_FS */