diff mbox series

[v2,4/4] arm64: dts: qcom: qdu1000-idp: add SDHCI for emmc

Message ID 20230522093620.3568-5-quic_kbajaj@quicinc.com
State New
Headers
Series arm64: dts: qcom: qdu1000: add SDHCI |

Commit Message

Komal Bajaj May 22, 2023, 9:36 a.m. UTC 
  Add sdhci node for emmc in qdu1000-idp.

Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com>
---
 arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

Comments

Bhupesh Sharma May 22, 2023, 9:53 a.m. UTC | #1 
On Mon, 22 May 2023 at 15:06, Komal Bajaj <quic_kbajaj@quicinc.com> wrote:
>
> Add sdhci node for emmc in qdu1000-idp.
>
> Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
> index 9e9fd4b8023e..61d8446a2d55 100644
> --- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
> @@ -451,3 +451,26 @@
>  &uart7 {
>         status = "okay";
>  };
> +
> +&sdhc_1 {
> +       pinctrl-names = "default", "sleep";
> +       pinctrl-0 = <&sdc1_on_state>;
> +       pinctrl-1 = <&sdc1_off_state>;
> +
> +       cap-mmc-hw-reset;
> +       mmc-ddr-1_8v;
> +       mmc-hs200-1_8v;
> +       mmc-hs400-1_8v;
> +       mmc-hs400-enhanced-strobe;
> +
> +       non-removable;
> +       no-sd;
> +       no-sdio;
> +
> +       supports-cqe;
> +
> +       vmmc-supply = <&vreg_l10a_2p95>;
> +       vqmmc-supply = <&vreg_l7a_1p8>;
> +
> +       status = "okay";
> +};

This node is out of alphabetical order again.
&uart7 would follow &sdhc_1 and so on...

Thanks,
Bhupesh
Komal Bajaj May 23, 2023, 1:54 p.m. UTC | #2 
On 5/22/2023 3:23 PM, Bhupesh Sharma wrote:
> On Mon, 22 May 2023 at 15:06, Komal Bajaj <quic_kbajaj@quicinc.com> wrote:
>> Add sdhci node for emmc in qdu1000-idp.
>>
>> Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 23 +++++++++++++++++++++++
>>   1 file changed, 23 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
>> index 9e9fd4b8023e..61d8446a2d55 100644
>> --- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
>> +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
>> @@ -451,3 +451,26 @@
>>   &uart7 {
>>          status = "okay";
>>   };
>> +
>> +&sdhc_1 {
>> +       pinctrl-names = "default", "sleep";
>> +       pinctrl-0 = <&sdc1_on_state>;
>> +       pinctrl-1 = <&sdc1_off_state>;
>> +
>> +       cap-mmc-hw-reset;
>> +       mmc-ddr-1_8v;
>> +       mmc-hs200-1_8v;
>> +       mmc-hs400-1_8v;
>> +       mmc-hs400-enhanced-strobe;
>> +
>> +       non-removable;
>> +       no-sd;
>> +       no-sdio;
>> +
>> +       supports-cqe;
>> +
>> +       vmmc-supply = <&vreg_l10a_2p95>;
>> +       vqmmc-supply = <&vreg_l7a_1p8>;
>> +
>> +       status = "okay";
>> +};
> This node is out of alphabetical order again.
> &uart7 would follow &sdhc_1 and so on...
Sure will change this next version.

Thanks
Komal
>
> Thanks,
> Bhupesh
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
index 9e9fd4b8023e..61d8446a2d55 100644
--- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
+++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
@@ -451,3 +451,26 @@ 
 &uart7 {
 	status = "okay";
 };
+
+&sdhc_1 {
+	pinctrl-names = "default", "sleep";
+	pinctrl-0 = <&sdc1_on_state>;
+	pinctrl-1 = <&sdc1_off_state>;
+
+	cap-mmc-hw-reset;
+	mmc-ddr-1_8v;
+	mmc-hs200-1_8v;
+	mmc-hs400-1_8v;
+	mmc-hs400-enhanced-strobe;
+
+	non-removable;
+	no-sd;
+	no-sdio;
+
+	supports-cqe;
+
+	vmmc-supply = <&vreg_l10a_2p95>;
+	vqmmc-supply = <&vreg_l7a_1p8>;
+
+	status = "okay";
+};