[2/3] MIPS: Select CONFIG_GENERIC_IDLE_POLL_SETUP

Message ID 20230521223124.21911-3-jiaxun.yang@flygoat.com
State New
Headers
Series MIPS: Enhancements on usage and documentation of parameters |

Commit Message

Jiaxun Yang May 21, 2023, 10:31 p.m. UTC
  hlt,nohlt paramaters are useful when debugging cpuidle
related issues.

Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
---
 Documentation/admin-guide/kernel-parameters.txt | 4 ++--
 arch/mips/Kconfig                               | 1 +
 2 files changed, 3 insertions(+), 2 deletions(-)
  

Comments

Thomas Bogendoerfer June 9, 2023, 8:36 a.m. UTC | #1
On Sun, May 21, 2023 at 11:31:23PM +0100, Jiaxun Yang wrote:
> hlt,nohlt paramaters are useful when debugging cpuidle
> related issues.
> 
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
>  Documentation/admin-guide/kernel-parameters.txt | 4 ++--
>  arch/mips/Kconfig                               | 1 +
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 515cd1f88ea2..9c502d3aa0cd 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -3694,8 +3694,8 @@
>  
>  	nohibernate	[HIBERNATION] Disable hibernation and resume.
>  
> -	nohlt		[ARM,ARM64,MICROBLAZE,SH] Forces the kernel to busy wait
> -			in do_idle() and not use the arch_cpu_idle()
> +	nohlt		[ARM,ARM64,MICROBLAZE,MIPS,SH] Forces the kernel to
> +			busy wait in do_idle() and not use the arch_cpu_idle()
>  			implementation; requires CONFIG_GENERIC_IDLE_POLL_SETUP
>  			to be effective. This is useful on platforms where the
>  			sleep(SH) or wfi(ARM,ARM64) instructions do not work
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 5f52bdecb4c9..e437bf43ecfc 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -45,6 +45,7 @@ config MIPS
>  	select GENERIC_LIB_UCMPDI2
>  	select GENERIC_SCHED_CLOCK if !CAVIUM_OCTEON_SOC
>  	select GENERIC_SMP_IDLE_THREAD
> +	select GENERIC_IDLE_POLL_SETUP
>  	select GENERIC_TIME_VSYSCALL
>  	select GUP_GET_PXX_LOW_HIGH if CPU_MIPS32 && PHYS_ADDR_T_64BIT
>  	select HAS_IOPORT if !NO_IOPORT_MAP || ISA
> -- 
> 2.39.2 (Apple Git-143)

applied to mips-next.

Thomas.
  

Patch

diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
index 515cd1f88ea2..9c502d3aa0cd 100644
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -3694,8 +3694,8 @@ 
 
 	nohibernate	[HIBERNATION] Disable hibernation and resume.
 
-	nohlt		[ARM,ARM64,MICROBLAZE,SH] Forces the kernel to busy wait
-			in do_idle() and not use the arch_cpu_idle()
+	nohlt		[ARM,ARM64,MICROBLAZE,MIPS,SH] Forces the kernel to
+			busy wait in do_idle() and not use the arch_cpu_idle()
 			implementation; requires CONFIG_GENERIC_IDLE_POLL_SETUP
 			to be effective. This is useful on platforms where the
 			sleep(SH) or wfi(ARM,ARM64) instructions do not work
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 5f52bdecb4c9..e437bf43ecfc 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -45,6 +45,7 @@  config MIPS
 	select GENERIC_LIB_UCMPDI2
 	select GENERIC_SCHED_CLOCK if !CAVIUM_OCTEON_SOC
 	select GENERIC_SMP_IDLE_THREAD
+	select GENERIC_IDLE_POLL_SETUP
 	select GENERIC_TIME_VSYSCALL
 	select GUP_GET_PXX_LOW_HIGH if CPU_MIPS32 && PHYS_ADDR_T_64BIT
 	select HAS_IOPORT if !NO_IOPORT_MAP || ISA