From patchwork Sun May 21 10:12:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 96865 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp852020vqo; Sun, 21 May 2023 05:34:18 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5WJQfT/iYdSC4Mq8UrGQRfm+lsntSVQJNfXLpFS83hHxD7MKsqoOtbSrSh6SPq3g8XP+4g X-Received: by 2002:a05:6a21:2c83:b0:100:d061:52ca with SMTP id ua3-20020a056a212c8300b00100d06152camr6839163pzb.50.1684672458249; Sun, 21 May 2023 05:34:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684672458; cv=none; d=google.com; s=arc-20160816; b=eLqTwQ/1jdtylKgw4g7r1WFlIZ8mQx2Xs2GT/VwCnA6vXbegUvoFIXlQZNOLAVZv89 mvxYc1wZm1sLMfQbBHVm7kYckB0x7UrrESbYeNQREpJ2f+6v8dJz/rpwVJ2YWBTHJ6w3 y56Cztb2J/LIMmDUEZXQrGsrbpyDJnQ1a7iVMIm/TpnnwZbzZEo3cmIWIVCSEmt9M4Cu i3Rg4knF3M5bJNlNzHhWWv7VYPPjubYO7iQr+Ey2xYZMXeWPnMHwDvb1b5D4UkZuNZnj bgTkrevjv/HYDuOAr7lxLXhXEkuscvZ7jcA2j5bsZ9Y9AqEt8lDfZqCOw1oCt2uJbf4N Whdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=D66zJlACp46RF5wmLGGk0AyE7BJSu2zFNKPrMtm0Z9E=; b=s2JrOWGl4kIQsNj1cr1M6/36zeaE8ubu42FipnZhQ54K8jcqCty3f2SFhr/TSAdrRe klhu6lpgK+j0hLgIuqOV94DDgtRhvTDpoSMi8wW2kuAwTiyG0TyL5r3Ba/Gdxq+BlBY7 FxFJn1G/5Ro2vMSlrbDAzpNk31iDXLFaDaAxb13y5tXD0QHbrt/xolK6raRbBXM8v8aG 4ze9k7RR34XagoqaE271TBqsp9quSPKu8cV+HkwkjSQY2ACFfV7c2qsPzGaJvyyA1G4k m2nuXbxPlmD+gtPKpbHjGyPpSIZ1nWBdER1qsHPGGXL+cpKXHSXoBzEj94RZRAF+s7Xr ApfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PINJX4DO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q21-20020a656a95000000b005303c3dedc2si3209648pgu.419.2023.05.21.05.34.05; Sun, 21 May 2023 05:34:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PINJX4DO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231134AbjEULta (ORCPT + 99 others); Sun, 21 May 2023 07:49:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230459AbjEUK1S (ORCPT ); Sun, 21 May 2023 06:27:18 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E80C10E2; Sun, 21 May 2023 03:23:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E6F3C60C94; Sun, 21 May 2023 10:23:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C825C433D2; Sun, 21 May 2023 10:23:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684664608; bh=xLmFwERNLFGS44YuN2v3vab89SlNXlrWfcwD+NSS4sc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PINJX4DODMB4CoA3wTX1FBA+zyOp+XmO+q/mnBCmSPeov7yP4TZ3nxL6xkr/RDTPi E6UVndyBT3h1d7vXfHTNuAvNKgPeOvNLdZ04FAC+sgCkHTTjvmHaNCnokQztF1f5bP rlapEI4CHl1x1OJFDijLkGTR9+w1QAmcEN+iH3ACxjQk3AIeiI5Js/5W8Z7G6q/An1 Na6p98Uo6JFslD9QhscTGwocbd7yC9dwjyvQ4ySvmkQSRu+OKnn1q74g4EM5CQcfUb LTeVoalXU3XlWBjphsWOWcIgORzPCMcemewKU65GF/nKBPwuJc9E4R+PVWZyTNX3Da E00rb9AO2hw3g== From: Jisheng Zhang To: Eugeniy Paltsev , Vinod Koul Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 02/11] dmaengine: dw-axi-dmac: remove unnecessary devm_free_irq() calling Date: Sun, 21 May 2023 18:12:07 +0800 Message-Id: <20230521101216.4084-3-jszhang@kernel.org> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230521101216.4084-1-jszhang@kernel.org> References: <20230521101216.4084-1-jszhang@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766507107054361967?= X-GMAIL-MSGID: =?utf-8?q?1766507107054361967?= In dw_remove(), We have disabled the irq from the dw-axi-dma side, so we are safe against the case "The irq is still ON when devices remove is executed and irq should be quiesced before remove is completed." Signed-off-by: Jisheng Zhang --- drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c index 203be13499e3..a19b651ddaad 100644 --- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c +++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c @@ -1563,8 +1563,6 @@ static int dw_remove(struct platform_device *pdev) pm_runtime_disable(chip->dev); axi_dma_suspend(chip); - devm_free_irq(chip->dev, chip->irq, chip); - of_dma_controller_free(chip->dev->of_node); list_for_each_entry_safe(chan, _chan, &dw->dma.channels,