| Message ID | 20230520063818.27208-5-lvjianmin@loongson.cn |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp189091vqo;
Fri, 19 May 2023 23:53:50 -0700 (PDT)
X-Google-Smtp-Source:
ACHHUZ4NIpLgPnYEs9dGthj/Wg7vI7tZHAKO9f6Bx2m/3uiD071gZxp1+hcIe49HT6DqpctvbSoH
X-Received: by 2002:a17:902:d4c2:b0:1ac:6c46:8c80 with SMTP id
o2-20020a170902d4c200b001ac6c468c80mr6405305plg.53.1684565629947;
Fri, 19 May 2023 23:53:49 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1684565629; cv=none;
d=google.com; s=arc-20160816;
b=og1fCasAbZ7OyxxhuXa2XkWBkReD9BuKrsD1NNg6X0yyiPz6nsajRplH7phCXw65kb
5pVLAGlGVjGPf2U/Iucj/VMM5Sqn++7VX2lgDYYpmjgli3pN0C0NjYaR81ZZMQBnYOW5
5qlYfLO8qOIreDJ1PBK3e53TY6wdjh9Tqn2i7xDfqU2MPbB7dMSZ+bHsKdlmamBqkf7b
yTC50QwDLbfQWdd5Jgw5/HZ71KHQWB/fmD+FiUBMWcG9CeoxGPVfxT7ev7LSp/TWyR3/
kolZ9ypeFVB8AFnOZMhn10Ko0NDX4Histg8SmYQYZCFvxdaUtO3JdcPMw87Vr0T0NUv+
zlLQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from;
bh=/3aKiemlYayG10N/6o2Jo4eIPgYwBtXA5PbKIj6gqt4=;
b=YTFjmnqEiXMwEFEz9M1JoCVe9xgxDUB36iXDVDY8UohZblf+Atnj0T6Cb3YYtJc2H7
P8aWDgRVaGylIrKqj+IpmpXmqbDydQvHtsFtAx7E2IPtuMblr6QESBCy6VeRnR2eA/yL
+m2esMGDpTwH1J5RNAe8uUoD3/qjQ1l2gsC8hDCcyAgNNMfl8kNtPj/Bjh/nnu+vC3y5
A+Q6tXT/ArxDfD+eRcDDSVqquGiR9IM1YZEveZwRP073sXBYMZg4XurI8AIkqj8vbQD8
8vlMKBswJOB0Xm4Vpgk1bcRmdOvuE0rq09ac6E8G6KZZU2ZDq49JfHzr+BNotrix5HWp
P6SA==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
ix10-20020a170902f80a00b001aade552f84si962446plb.93.2023.05.19.23.53.37;
Fri, 19 May 2023 23:53:49 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S230171AbjETGie (ORCPT <rfc822;ahmedalshaiji.dev@gmail.com>
+ 99 others); Sat, 20 May 2023 02:38:34 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44094 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229991AbjETGia (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Sat, 20 May 2023 02:38:30 -0400
Received: from loongson.cn (mail.loongson.cn [114.242.206.163])
by lindbergh.monkeyblade.net (Postfix) with ESMTP id 566911A8
for <linux-kernel@vger.kernel.org>;
Fri, 19 May 2023 23:38:29 -0700 (PDT)
Received: from loongson.cn (unknown [10.20.42.176])
by gateway (Coremail) with SMTP id _____8CxlfDkamhkD18KAA--.18223S3;
Sat, 20 May 2023 14:38:28 +0800 (CST)
Received: from loongson-pc.loongson.cn (unknown [10.20.42.176])
by localhost.localdomain (Coremail) with SMTP id
AQAAf8BxFLXaamhkd1JrAA--.51105S6;
Sat, 20 May 2023 14:38:27 +0800 (CST)
From: Jianmin Lv <lvjianmin@loongson.cn>
To: Thomas Gleixner <tglx@linutronix.de>, Marc Zyngier <maz@kernel.org>
Cc: linux-kernel@vger.kernel.org, loongarch@lists.linux.dev,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Huacai Chen <chenhuacai@loongson.cn>,
loongson-kernel@lists.loongnix.cn, Yinbo Zhu <zhuyinbo@loongson.cn>
Subject: [PATCH V1 4/4] irqchip/loongson-liointc: Add IRQCHIP_SKIP_SET_WAKE
flag
Date: Sat, 20 May 2023 14:38:18 +0800
Message-Id: <20230520063818.27208-5-lvjianmin@loongson.cn>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20230520063818.27208-1-lvjianmin@loongson.cn>
References: <20230520063818.27208-1-lvjianmin@loongson.cn>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-CM-TRANSID: AQAAf8BxFLXaamhkd1JrAA--.51105S6
X-CM-SenderInfo: 5oymxthqpl0qxorr0wxvrqhubq/
X-Coremail-Antispam: 1Uk129KBjvdXoW7Jry3XF48ZryDXF4fuFy3Arb_yoWkGFX_WF
y7Jw1kCry2vrsIka4xCr4Utr1Fk3y5uanrua1FvFs3Z348tw45Cay3Z3ZxGFWUKryjvF93
Kr48Wr4rCrWxtjkaLaAFLSUrUUUUnb8apTn2vfkv8UJUUUU8wcxFpf9Il3svdxBIdaVrn0
xqx4xG64xvF2IEw4CE5I8CrVC2j2Jv73VFW2AGmfu7bjvjm3AaLaJ3UjIYCTnIWjp_UUUY
C7kC6x804xWl14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0rVWrJVCq3w
AFIxvE14AKwVWUGVWUXwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK
6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4j6F4UM28EF7
xvwVC2z280aVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gr1j6F4UJwAa
w2AFwI0_JF0_Jw1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44
I27wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Wrv_ZF1lYx0Ex4A2
jsIE14v26r4j6F4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCY1x0262
kKe7AKxVWUAVWUtwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwCFI7km
07C267AKxVWUAVWUtwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r
1rMI8E67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVW5
JVW7JwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6r
1j6r1xMIIF0xvEx4A2jsIE14v26r4j6F4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1U
YxBIdaVFxhVjvjDU0xZFpf9x07jhgAwUUUUU=
X-Spam-Status: No, score=1.4 required=5.0 tests=BAYES_00,RCVD_IN_SBL_CSS,
SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no
autolearn_force=no version=3.4.6
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1766395089821920039?=
X-GMAIL-MSGID: =?utf-8?q?1766395089821920039?=
|
| Series |
irqchip/loongson: Fix some loongson irqchip drivers
|
|
Commit Message
吕建民
May 20, 2023, 6:38 a.m. UTC
From: Yinbo Zhu <zhuyinbo@loongson.cn> Liointc doesn't require specific logic to work with wakeup IRQs, and no irq_set_wake callback is needed. To allow registered IRQs from liointc to be used as a wakeup-source, and ensure irq_set_irq_wake() works well, the flag IRQCHIP_SKIP_SET_WAKE should be added. Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn> Signed-off-by: Jianmin Lv <lvjianmin@loongson.cn> --- drivers/irqchip/irq-loongson-liointc.c | 1 + 1 file changed, 1 insertion(+)
Comments
Hi, Jianmin, On Sat, May 20, 2023 at 2:38 PM Jianmin Lv <lvjianmin@loongson.cn> wrote: > > From: Yinbo Zhu <zhuyinbo@loongson.cn> > > Liointc doesn't require specific logic to work with wakeup IRQs, > and no irq_set_wake callback is needed. To allow registered IRQs > from liointc to be used as a wakeup-source, and ensure irq_set_irq_wake() > works well, the flag IRQCHIP_SKIP_SET_WAKE should be added. Maybe using LIOINTC instead of Liointc/liointc is better in commit message. Except this small issue, for the whole series, Reviewed-by: Huacai Chen <chenhuacai@loongson.cn> > > Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn> > Signed-off-by: Jianmin Lv <lvjianmin@loongson.cn> > --- > drivers/irqchip/irq-loongson-liointc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/irqchip/irq-loongson-liointc.c b/drivers/irqchip/irq-loongson-liointc.c > index 9a9c2bf048a3..dbd1ccce0fb2 100644 > --- a/drivers/irqchip/irq-loongson-liointc.c > +++ b/drivers/irqchip/irq-loongson-liointc.c > @@ -291,6 +291,7 @@ static int liointc_init(phys_addr_t addr, unsigned long size, int revision, > ct->chip.irq_mask = irq_gc_mask_disable_reg; > ct->chip.irq_mask_ack = irq_gc_mask_disable_reg; > ct->chip.irq_set_type = liointc_set_type; > + ct->chip.flags = IRQCHIP_SKIP_SET_WAKE; > > gc->mask_cache = 0; > priv->gc = gc; > -- > 2.31.1 > >
On 2023/5/20 下午4:43, Huacai Chen wrote: > Hi, Jianmin, > > On Sat, May 20, 2023 at 2:38 PM Jianmin Lv <lvjianmin@loongson.cn> wrote: >> >> From: Yinbo Zhu <zhuyinbo@loongson.cn> >> >> Liointc doesn't require specific logic to work with wakeup IRQs, >> and no irq_set_wake callback is needed. To allow registered IRQs >> from liointc to be used as a wakeup-source, and ensure irq_set_irq_wake() >> works well, the flag IRQCHIP_SKIP_SET_WAKE should be added. > Maybe using LIOINTC instead of Liointc/liointc is better in commit > message. Except this small issue, for the whole series, > Reviewed-by: Huacai Chen <chenhuacai@loongson.cn> > Ok, I'll change it, thanks. >> >> Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn> >> Signed-off-by: Jianmin Lv <lvjianmin@loongson.cn> >> --- >> drivers/irqchip/irq-loongson-liointc.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/irqchip/irq-loongson-liointc.c b/drivers/irqchip/irq-loongson-liointc.c >> index 9a9c2bf048a3..dbd1ccce0fb2 100644 >> --- a/drivers/irqchip/irq-loongson-liointc.c >> +++ b/drivers/irqchip/irq-loongson-liointc.c >> @@ -291,6 +291,7 @@ static int liointc_init(phys_addr_t addr, unsigned long size, int revision, >> ct->chip.irq_mask = irq_gc_mask_disable_reg; >> ct->chip.irq_mask_ack = irq_gc_mask_disable_reg; >> ct->chip.irq_set_type = liointc_set_type; >> + ct->chip.flags = IRQCHIP_SKIP_SET_WAKE; >> >> gc->mask_cache = 0; >> priv->gc = gc; >> -- >> 2.31.1 >> >> > _______________________________________________ > Loongson-kernel mailing list -- loongson-kernel@lists.loongnix.cn > To unsubscribe send an email to loongson-kernel-leave@lists.loongnix.cn >
diff --git a/drivers/irqchip/irq-loongson-liointc.c b/drivers/irqchip/irq-loongson-liointc.c index 9a9c2bf048a3..dbd1ccce0fb2 100644 --- a/drivers/irqchip/irq-loongson-liointc.c +++ b/drivers/irqchip/irq-loongson-liointc.c @@ -291,6 +291,7 @@ static int liointc_init(phys_addr_t addr, unsigned long size, int revision, ct->chip.irq_mask = irq_gc_mask_disable_reg; ct->chip.irq_mask_ack = irq_gc_mask_disable_reg; ct->chip.irq_set_type = liointc_set_type; + ct->chip.flags = IRQCHIP_SKIP_SET_WAKE; gc->mask_cache = 0; priv->gc = gc;