From patchwork Fri May 19 19:09:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Fernandes X-Patchwork-Id: 96596 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1481227vqo; Fri, 19 May 2023 12:53:37 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6r0d5sJb+CIY/Dijamtmm4mQlCR0wVQWchOpBoUogdHygitUUW8C/DxBlL6D8Qbfe9V1Kg X-Received: by 2002:a05:6a21:32a7:b0:104:873:c3cc with SMTP id yt39-20020a056a2132a700b001040873c3ccmr3495578pzb.40.1684526016860; Fri, 19 May 2023 12:53:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684526016; cv=none; d=google.com; s=arc-20160816; b=ZzZp9yCB46SCSqogMUQKEgXGEQRgBnvTJrP5UhtczWIQBl7xp9JkGTg3YnJNa0J+lQ de9xSBs+NmPkvWJSg3yhinhoHczN7uf98C5ydbDrCKHUBn7r5P6SuKGNoyFoiJYatP3I AA+iT1UrXe4lO+wutKh/vLIYfdWYJ0AWGtc3U8EXs5lhhsbVuCcZyl21lKMNq+fbVES0 KFrq5BiY70qxbJBIJqYI05QmsmOjsQY6adRusvtkj1SJcqwvpht+Nfi5AUJ7T2noY5/I BgbuPnU7jF4Kyxm6c/lgc/UxGaqbtDTiJ0h+idgYkykdILDEqvqohVML6M/bncgR2WTH Vh5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=t64UzVHVroabp76Xd4g1LLeTmZtqX+n8nvVYbfjxh90=; b=JSP5pzTqfxvwSyqNPEtZ//2/Qp+rtHnSA/pEMi0q56p++wUE9KSCNdsWXb1xPcrB8F sTLRWSKK/3zaMvjiTU5cWd0HdbNDsgf6dMwOKiJMVG/d0Ux3uLEzxCko4ItpQgxnuj6X a7idPiSWUPtjekZT5vRhBu+ckheWa4nyI6xXQaLZPKRGmY3qvQOQqX087wOaGe7MVEFU 8UVnB5uz3z/cII/pn1r13WFrAOMjNydMLmiGb+aNGEMEU7RNI5ss7fqnhfstfp9mmeo/ ZB0sJCMhGppmtM2nV/NUZRjCGcvNFmYQy382cSBQ+AyJ2eaq0QvBxK6ZyB0leiBfdI18 avug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=o7UU9iUh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 202-20020a6302d3000000b005346af99305si115350pgc.526.2023.05.19.12.53.21; Fri, 19 May 2023 12:53:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=o7UU9iUh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231655AbjESTKd (ORCPT + 99 others); Fri, 19 May 2023 15:10:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231414AbjESTKW (ORCPT ); Fri, 19 May 2023 15:10:22 -0400 Received: from mail-ua1-x92b.google.com (mail-ua1-x92b.google.com [IPv6:2607:f8b0:4864:20::92b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44F18171B for ; Fri, 19 May 2023 12:09:49 -0700 (PDT) Received: by mail-ua1-x92b.google.com with SMTP id a1e0cc1a2514c-783eef15004so1198934241.3 for ; Fri, 19 May 2023 12:09:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1684523388; x=1687115388; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=t64UzVHVroabp76Xd4g1LLeTmZtqX+n8nvVYbfjxh90=; b=o7UU9iUhAbrwB44BtKTmc5RQ8dUPaFjHnnyhvbFZd+1u585u1S76A7OrnTd4nASMLC ZkUXlYY0ZOkyICYNTcwic2MeSK8V8ncKEVmdi5sB8vbXKubDEMtEYecQ/rgSsn59s9aX 4//vGzJMsIiFGeko/yn1WZd6ewTT2Ke489JRE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684523388; x=1687115388; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t64UzVHVroabp76Xd4g1LLeTmZtqX+n8nvVYbfjxh90=; b=dEBcVAA0E4U1SpxVjea2KiWrD9cCxsqzUUT7PzjQmoG0vN2mEki+wHqlFnMUfqFyvS SbiufRweUZ0cJCoMw7AkCi+ptt/aIjtangPlibysYGxBa/z5uGzA8VPprPLm6tk9J4pc i6/WDHyshVnZ7hL/zh5dJXB13HONlC/XdT8q6sT+f3zDniav9ONjMkCDb3DpOVwHKkhy ztCcxBp5q94M6G2t4dZTad5YHqRuxoXf6lQ2sJCDKiY93HTRxSegAdnnGFsqTfR8mRQC /wzdjjwjU2e3Lk7Vym5rosKyutPe6pazYu+yt50JIYVPfH/pHVywLfxaWRMkzBuyRnBv 3fKA== X-Gm-Message-State: AC+VfDybHroqQNvz2bbfv1CvA4wNk0ntQ7Byb+N/LOd1PnaB5p/bevAX mZD+odNQQbOwb0T1vO8tJyWAKzA8WziMb8x0vDA= X-Received: by 2002:a67:f050:0:b0:435:f378:8ee8 with SMTP id q16-20020a67f050000000b00435f3788ee8mr163030vsm.26.1684523388002; Fri, 19 May 2023 12:09:48 -0700 (PDT) Received: from joelboxx.c.googlers.com.com (129.239.188.35.bc.googleusercontent.com. [35.188.239.129]) by smtp.gmail.com with ESMTPSA id q20-20020ae9e414000000b0074e1ee30478sm1317611qkc.37.2023.05.19.12.09.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 May 2023 12:09:47 -0700 (PDT) From: "Joel Fernandes (Google)" To: linux-kernel@vger.kernel.org Cc: "Joel Fernandes (Google)" , linux-kselftest@vger.kernel.org, linux-mm@kvack.org, Shuah Khan , Vlastimil Babka , Michal Hocko , Linus Torvalds , Lorenzo Stoakes , Kirill A Shutemov , "Liam R. Howlett" , "Paul E. McKenney" , Suren Baghdasaryan Subject: [PATCH v2 2/4] selftests: mm: Fix failure case when new remap region was not found Date: Fri, 19 May 2023 19:09:32 +0000 Message-ID: <20230519190934.339332-3-joel@joelfernandes.org> X-Mailer: git-send-email 2.40.1.698.g37aff9b760-goog In-Reply-To: <20230519190934.339332-1-joel@joelfernandes.org> References: <20230519190934.339332-1-joel@joelfernandes.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766353552531892015?= X-GMAIL-MSGID: =?utf-8?q?1766353552531892015?= When a valid remap region could not be found, the source mapping is not cleaned up. Fix the goto statement such that the clean up happens. Signed-off-by: Joel Fernandes (Google) --- tools/testing/selftests/mm/mremap_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/mremap_test.c b/tools/testing/selftests/mm/mremap_test.c index 5c3773de9f0f..6822d657f589 100644 --- a/tools/testing/selftests/mm/mremap_test.c +++ b/tools/testing/selftests/mm/mremap_test.c @@ -316,7 +316,7 @@ static long long remap_region(struct config c, unsigned int threshold_mb, if (addr + c.dest_alignment < addr) { ksft_print_msg("Couldn't find a valid region to remap to\n"); ret = -1; - goto out; + goto clean_up_src; } addr += c.dest_alignment; }