From patchwork Fri May 19 16:04:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kaiser X-Patchwork-Id: 96489 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1357068vqo; Fri, 19 May 2023 09:22:46 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7C4jtjLiVbIMVzwOO/6+6aKwDLmurQcSjywxDgltqy7m/GIg31SqCQjQdzVVW6gPBX3gkV X-Received: by 2002:a17:90a:881:b0:253:510e:130a with SMTP id v1-20020a17090a088100b00253510e130amr3325060pjc.19.1684513365662; Fri, 19 May 2023 09:22:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684513365; cv=none; d=google.com; s=arc-20160816; b=QOwLPdvdfwNpTCEAlZgE8vHxRm/PpR4TFvOqTWXLLG69IEuYRKgwuuElnmDl248VmO j+KzbM6/e1ev1w5fo66DjtjP+51YoZltl/wuy5i4NKIHZ7N70+y1aqVCM1E6+0Yikkzd KRc7521+OPXRVi3FaUKd3Gkh3UKzlWqbUlHk3oJFVmCDNOrZWSKcyyvb4S+t3QuOVmqT QcPYsyKUgf4J9wHTnEoJBdWssC+5Z49jd8Dg9uBbHtNLxAgMxIjivxK/5u3pun3LqGMq jPSJxQUMWX4UlR8LeBD61cBVCC+lbtkbVxV0YmeTM06IDf8SB9A57Tms1KCWLcqNj/kV HLIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=QNC6AWEI5h0QalFgl/Ea1sL+Cqur0RjPq13hrvm97pg=; b=LRxvliCtB0KcexUH7xfvv9+zQvJgDzJL7VL2PksT9GwY5s+7Uo0ZLeAG2B5Qd6fqa4 D1nfdgf3WIgQe5pBAdM3OgQd4XadzmeJcjxfWmrrqzqvO5VSjxxCYeaFcKj9Vh65FwMc i6AS7Kh0wAQc/Qa4HTk21yUBIdbjxaiysqonht7xMbngQAnZTZ3vNEVrQzFvAsyZRAmz pXzpU4aOV+VD4s0JZ+sjipTCs4pLwiVNw5WHJUQpKah7OQ+sOUQwuHkgu9Hg+zUtbPVx lpc/ae3SNZQOQIA1dzfbQV0o0CCv6dnHdswsZ7iTJGPc9UhFIAq7bJ8uzljCTumsM9VL roOA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y14-20020a63ad4e000000b0052c9458bc03si3734763pgo.278.2023.05.19.09.22.32; Fri, 19 May 2023 09:22:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229643AbjESQFj (ORCPT + 99 others); Fri, 19 May 2023 12:05:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229458AbjESQFe (ORCPT ); Fri, 19 May 2023 12:05:34 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09CED9E; Fri, 19 May 2023 09:05:33 -0700 (PDT) Received: from ipservice-092-217-072-086.092.217.pools.vodafone-ip.de ([92.217.72.86] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1q02bk-0001Ah-JD; Fri, 19 May 2023 18:05:32 +0200 From: Martin Kaiser To: Herbert Xu Cc: linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH v2 2/3] hwrng: imx-rngc - use bitfield macros to read rng type Date: Fri, 19 May 2023 18:04:32 +0200 Message-Id: <20230519160433.287161-3-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230519160433.287161-1-martin@kaiser.cx> References: <20230427185357.923412-1-martin@kaiser.cx> <20230519160433.287161-1-martin@kaiser.cx> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764358567427078965?= X-GMAIL-MSGID: =?utf-8?q?1766340286966514637?= Use the mechanism from bitfield.h to read the rng type field in the version_id register. This makes the code a tiny bit simpler. Signed-off-by: Martin Kaiser --- drivers/char/hw_random/imx-rngc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/char/hw_random/imx-rngc.c b/drivers/char/hw_random/imx-rngc.c index cf29c323453a..b5f7b91bd13e 100644 --- a/drivers/char/hw_random/imx-rngc.c +++ b/drivers/char/hw_random/imx-rngc.c @@ -27,7 +27,7 @@ #define RNGC_FIFO 0x0014 /* the fields in the ver id register */ -#define RNGC_TYPE_SHIFT 28 +#define RNG_TYPE GENMASK(31, 28) #define RNGC_VER_MAJ_SHIFT 8 /* the rng_type field */ @@ -251,7 +251,7 @@ static int imx_rngc_probe(struct platform_device *pdev) return irq; ver_id = readl(rngc->base + RNGC_VER_ID); - rng_type = ver_id >> RNGC_TYPE_SHIFT; + rng_type = FIELD_GET(RNG_TYPE, ver_id); /* * This driver supports only RNGC and RNGB. (There's a different * driver for RNGA.)