From patchwork Fri May 19 09:27:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 96319 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1104109vqo; Fri, 19 May 2023 02:39:26 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6rYO0/N04F9E5eEn8uS5gazIHbm3tKr0xQaD+pqlf3JM61v1TL7oLG0c6yc326oVBbNZUW X-Received: by 2002:a17:903:1109:b0:1ac:3605:97ec with SMTP id n9-20020a170903110900b001ac360597ecmr2285011plh.62.1684489166105; Fri, 19 May 2023 02:39:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684489166; cv=none; d=google.com; s=arc-20160816; b=NhgJShR/c5Knud3z6o3VbHe66A3A+Gwxlr+FxCraH3C2hz+aFrSz2gz+zqRaAEXh2a qQMTwXdPM4gZYzK1uJyhvayqXR2Hl0caW7oJ3M3ir6Gf+Zk4gJNvLeNVLeiHvaqp+QZ1 YN6KkFZJ734vGhbYECjGKNHL9u5Zwd0+7ndW2IedeTQ0/Yn0cWbTN8lVCUXcq7x4o7QQ r0/6ruu7ULtAiroGQH1mzb1gQMzNvmzgy5DymzVrJ3Tw2WqblCIrKwGl5nj0wq11GIy6 gUnGzKRZjVMWQNzmEsOK01sYuEEU9dRg1kJD6ZaXwm2ELDY3gcXQvUK3cYIz6eYb6lNc 6puA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=cpw/NUFswrYiWWCk7SNj+4W4pPcjXeFrDogiMre1ubQ=; b=EAY0UnS6BpERKhZPP0GoGFDJWU1x9KEH4iqr48DwNHVLqGHypBzNI3URHEw7v34HEe 8W5XMIzscQHDU8Yw61Pf3iWX2r5OPT5aXY2r3Ad6j8mTTethlBMuQ5cR+xEjO6UMh7rp IAvk0Lh+zo3dde7yfvlcaRPIUwILWmVIMJ3rXOlKOpfGNz4BGe+52KuIp5QD7PHn7sJI 1h18oIYh0uVo44cpIvUmYFTYufwc3zsIp4gK8iHjSapr267I3F8VsVJ9qIopCQHlFeO2 7cNIrlfl/GEt2oBRXJtLa5ErqMF3CYcZCfxjo0UibLdOi5gx6k/S9Ca8BJhzB/t/rl8/ aXqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RSXpt6Ib; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n16-20020a170903111000b001a6f94a0854si3448767plh.324.2023.05.19.02.39.14; Fri, 19 May 2023 02:39:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RSXpt6Ib; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230308AbjESJ2X (ORCPT + 99 others); Fri, 19 May 2023 05:28:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229644AbjESJ2W (ORCPT ); Fri, 19 May 2023 05:28:22 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32A5319A for ; Fri, 19 May 2023 02:28:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B36336558D for ; Fri, 19 May 2023 09:28:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B8DBC433EF; Fri, 19 May 2023 09:28:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684488501; bh=oqaxusc9buD7w2Ddys91pietI0uocG68+c+khpbA3To=; h=From:To:Cc:Subject:Date:From; b=RSXpt6Iby9HAjPxnV5GqCjOfqn643OHr3L4k3vxbYnukfGCAjM8QvcsWOHa7GEPGd VmOzown06OswYEEihZXC1G30nLZA/aHpwM8SDpNdo7bO+cwPACVkrQy4nz/yizbGXw 0G4UvKWb07imYX+alpJ8DYT1n3rQk7VL8XH6fS0cS+3wi0SAk7mo9PtYiR7za2OshX LlKTQRtQAmBzc0zF3s1N4J8jdEX1tktBv6yvysz42HZCIldxKsBAEZGL4/kGg8zuLo HANvZ3FDY+b/Hw5CttK0f7sRDyfP/H5k2OZAzTBQfGupho9LQ/vW58DGGuS73rQYTN TKi+vOzAyre4w== From: Arnd Bergmann To: Andrew Morton , Oscar Salvador Cc: Arnd Bergmann , David Hildenbrand , Vlastimil Babka , "Mike Rapoport (IBM)" , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] mm,page_owner: mark page_owner_threshold helpers as static Date: Fri, 19 May 2023 11:27:43 +0200 Message-Id: <20230519092800.3772196-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766314911660521857?= X-GMAIL-MSGID: =?utf-8?q?1766314911660521857?= From: Arnd Bergmann The newly added functions have no prototype: mm/page_owner.c:748:5: error: no previous prototype for 'page_owner_threshold_get' [-Werror=missing-prototypes] mm/page_owner.c:754:5: error: no previous prototype for 'page_owner_threshold_set' [-Werror=missing-prototypes] Evidently they are only meant to be used locally, so just mark them static. Fixes: daed0e400a81 ("mm,page_owner: filter out stacks by a threshold counter") Signed-off-by: Arnd Bergmann --- mm/page_owner.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/page_owner.c b/mm/page_owner.c index 28c519fc9372..bbec66cd1b72 100644 --- a/mm/page_owner.c +++ b/mm/page_owner.c @@ -745,13 +745,13 @@ const struct file_operations page_owner_stack_operations = { unsigned long page_owner_stack_threshold; -int page_owner_threshold_get(void *data, u64 *val) +static int page_owner_threshold_get(void *data, u64 *val) { *val = page_owner_stack_threshold; return 0; } -int page_owner_threshold_set(void *data, u64 val) +static int page_owner_threshold_set(void *data, u64 val) { page_owner_stack_threshold = val; return 0;