From patchwork Fri May 19 07:40:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 96243 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1062965vqo; Fri, 19 May 2023 01:03:57 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5yDbGv5c/1ZFSrLRKdGRXTsWhqDmryYyuBB41JUs3/tGqaJhN1jk1xYQO+632pqD2pcGYj X-Received: by 2002:a05:6a00:cd1:b0:643:b37d:d350 with SMTP id b17-20020a056a000cd100b00643b37dd350mr2391667pfv.31.1684483437281; Fri, 19 May 2023 01:03:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684483437; cv=none; d=google.com; s=arc-20160816; b=VWmX3wwV4aKAF4IUqSXfhZxVqOw0h2t3lm9bb8f+tguoAMb+PM2/PUFEGIN/t1bo/t QSdHyxlDUs+N9OeyiIZZMgOFQsYvXS7g/Q+Ts0VCOJkU+yjVv4U3DRwEeFeVeYqI2T+u ywCKdM+AtMnFoydSJv1kOcDcUU2SzPbWcQUOu1zh5VmzKAqujRMyJvDeC383bV8TBDX8 fQK/vqTF2EI7pYc+QEdnLic7UpBKEyP+nLYUX0ZtpBfGNgfv7e9xtc3ngwcmOlRpDujP 31c4tlLlzKfGH2DgQJhdI43hEdYzGARHkEA2H5S4nhm0oTSwFON0KmT4aeSAzDr2auZz 5WEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=oZIY9GTPXEPoSMZhe+ryqBhZXmHTyjPJq3hYdlaANCY=; b=oaf76AYyZug6OJkaqtGlz4YhOTT96bIuwrNkeRXdy4TknCdOn3KNZ2d5GeWz1nq+/N 4PXnRk7K511Y/PM+g46lVaB/BcxDESDgehEf9q1NBJJ7KB/MDyk1V0DxciAFQWXhEcpr +HT6t9RqbzkSGUaLjDrXDzgqQRu7vxN3UYiixmVMxDcqjl6PNwxNBo6XkhW/SkVwUqXq ycz+i5eNEz468dDZHJwzsfdF+dP2HtHpTqxKCFcwZoyrhPdYXyNdvOkjvi276V88fTpm Uyc5nGMquOh2A2ntgg7tgJREXM7V/dcSi+Wbv/bR1n9M+t0y06jRsfU2cYl/+xqrlB58 rXyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=SY6kmsjg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y64-20020a638a43000000b0053475d8615csi2871824pgd.32.2023.05.19.01.03.45; Fri, 19 May 2023 01:03:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=SY6kmsjg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230431AbjESHqu (ORCPT + 99 others); Fri, 19 May 2023 03:46:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229852AbjESHqZ (ORCPT ); Fri, 19 May 2023 03:46:25 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3E1726AB for ; Fri, 19 May 2023 00:43:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684482156; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oZIY9GTPXEPoSMZhe+ryqBhZXmHTyjPJq3hYdlaANCY=; b=SY6kmsjgU1rxdcFdFAhtKgFKrqsYPJXYEai35iQK2mU82uA3aQ03VHVJbp0+9eLUEEXIV9 BwK3z8geN8jbXUoc2linV4kClpjP95V8HCOnOnY13WAFpb/cr5BpF5ylUXAJg3QMbzA/7X f7j97gSwP4zMCGTR0q3nCGBuJjR3yfs= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-218-S_Amoo1cMROA4t9BdXJr9g-1; Fri, 19 May 2023 03:42:33 -0400 X-MC-Unique: S_Amoo1cMROA4t9BdXJr9g-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8E12685A5AA; Fri, 19 May 2023 07:42:32 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.221]) by smtp.corp.redhat.com (Postfix) with ESMTP id 503291121314; Fri, 19 May 2023 07:42:30 +0000 (UTC) From: David Howells To: Jens Axboe , Al Viro , Christoph Hellwig Cc: David Howells , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, John Hubbard , Dave Chinner , Christoph Hellwig Subject: [PATCH v20 27/32] iomap: Don't get an reference on ZERO_PAGE for direct I/O block zeroing Date: Fri, 19 May 2023 08:40:42 +0100 Message-Id: <20230519074047.1739879-28-dhowells@redhat.com> In-Reply-To: <20230519074047.1739879-1-dhowells@redhat.com> References: <20230519074047.1739879-1-dhowells@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766308904875507509?= X-GMAIL-MSGID: =?utf-8?q?1766308904875507509?= ZERO_PAGE can't go away, no need to hold an extra reference. Signed-off-by: David Howells Reviewed-by: David Hildenbrand Reviewed-by: John Hubbard Reviewed-by: Dave Chinner Reviewed-by: Christoph Hellwig cc: Al Viro cc: linux-fsdevel@vger.kernel.org --- fs/iomap/direct-io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c index 019cc87d0fb3..66a9f10e3207 100644 --- a/fs/iomap/direct-io.c +++ b/fs/iomap/direct-io.c @@ -203,7 +203,7 @@ static void iomap_dio_zero(const struct iomap_iter *iter, struct iomap_dio *dio, bio->bi_private = dio; bio->bi_end_io = iomap_dio_bio_end_io; - get_page(page); + bio_set_flag(bio, BIO_NO_PAGE_REF); __bio_add_page(bio, page, len, 0); iomap_dio_submit_bio(iter, dio, bio, pos); }