From patchwork Fri May 19 07:40:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 96219 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1055391vqo; Fri, 19 May 2023 00:45:12 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7wy64A+UR1Ig4Xp1HtyRC1+DvUTFN7gWYqpsbZsWgLtrd6G09krUm1NNJXzFTi5mcnLbGa X-Received: by 2002:a17:90a:b396:b0:247:2d9d:4722 with SMTP id e22-20020a17090ab39600b002472d9d4722mr1445278pjr.0.1684482312391; Fri, 19 May 2023 00:45:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684482312; cv=none; d=google.com; s=arc-20160816; b=ZoFTPFI8Tou2XdDyPoKIv0YPnUmMlKsFWo2yJmhFPUfovQgxnbpk6b0vBjORw6g/24 rViuZbN791mkzKH5o6qb/UJYdns1bjblBC0KgLHX4sFaQt9Cy029WDc2ZEzoPhA7fqf8 rIDJa2soVoA0DS2f8TPvl5VsefHGHg1VKFFiuKv4eJh2mYUAcJIo5RLTiG8jFCYgp0WS gxFj/qFAQR/XOX1X4g8LDzJ9geDB8HV5qWnkC+yVgrZfDkUicWt/LWBZuoedVzN/OFWa Y616jfkwN9WNuEtHHp0bnNsxh28nCg12B9xZ/97m4pGABYuof33eZhNoRLYrsAlZhKr+ GTcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=MIKgygGFPP04jCWudTIx6Exr1BpE2idki489iWC06JA=; b=COd6kLeWwMovS37Y3ZAQWRMdMYSDL9Dmt/1y/Lm+jmLYfkxRP23AOrxiuNaV9WnCNu wd2O1YSQnZOyKgmhm+jp4uYj/E8jWRJ9knatXPJ9IKhUsB7VVWKSute3Z5/EuQ+mAthg wa6LEHF4YS4UbfUFZWC/UzJ8fSvclzoCi4nhzOtW7LiHGBdOp4s0tD/DC1XqCkOvJ4RR gm2dBDmiCUHwTC8Q0DHNZud8eKvgKhs8GEc5ryLomZbWKP17HwPbKaMG2ghVTaDndI1i NFG7STtBVD/W77ZaFG+ne8chppf2URkHX0aSMBI91ge0vtdD8B+Lxqf2TxAG6P1X4YnP Camg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=b5p3Egya; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v14-20020a63bf0e000000b005348c534625si666944pgf.569.2023.05.19.00.44.59; Fri, 19 May 2023 00:45:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=b5p3Egya; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230161AbjESHoN (ORCPT + 99 others); Fri, 19 May 2023 03:44:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231216AbjESHnN (ORCPT ); Fri, 19 May 2023 03:43:13 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B42871997 for ; Fri, 19 May 2023 00:42:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684482130; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MIKgygGFPP04jCWudTIx6Exr1BpE2idki489iWC06JA=; b=b5p3EgyaoBdcAW+MZ8niqVl8BOWkVSrN3tj4rrtmwYJgjNIwB8BHoH4XIZ8znDvVZp5qfn hiOdvXS2ezSRQDYUmi6hIzswuzg1/ePfo3zjPHKryT/DKm/GTSegn5ozO1v2s3JHaKe7R7 XViaLEareFGiLerWhC62itqCYgCIttE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-76-BiSEfFWJO5ihxPcX24ACRw-1; Fri, 19 May 2023 03:42:03 -0400 X-MC-Unique: BiSEfFWJO5ihxPcX24ACRw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id ADED48027F5; Fri, 19 May 2023 07:42:02 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.221]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9BEDF40CFD45; Fri, 19 May 2023 07:41:59 +0000 (UTC) From: David Howells To: Jens Axboe , Al Viro , Christoph Hellwig Cc: David Howells , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , Konstantin Komarov , ntfs3@lists.linux.dev Subject: [PATCH v20 18/32] ntfs3: Provide a splice-read stub Date: Fri, 19 May 2023 08:40:33 +0100 Message-Id: <20230519074047.1739879-19-dhowells@redhat.com> In-Reply-To: <20230519074047.1739879-1-dhowells@redhat.com> References: <20230519074047.1739879-1-dhowells@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766307725314925190?= X-GMAIL-MSGID: =?utf-8?q?1766307725314925190?= Provide a splice_read stub for NTFS3 to perform various checks before allowing the operation to proceed. Signed-off-by: David Howells cc: Christoph Hellwig cc: Al Viro cc: Jens Axboe cc: Konstantin Komarov cc: ntfs3@lists.linux.dev cc: linux-fsdevel@vger.kernel.org cc: linux-block@vger.kernel.org cc: linux-mm@kvack.org --- fs/ntfs3/file.c | 36 +++++++++++++++++++++++++++++++++++- 1 file changed, 35 insertions(+), 1 deletion(-) diff --git a/fs/ntfs3/file.c b/fs/ntfs3/file.c index 9a3d55c367d9..c27814946aa3 100644 --- a/fs/ntfs3/file.c +++ b/fs/ntfs3/file.c @@ -744,6 +744,40 @@ static ssize_t ntfs_file_read_iter(struct kiocb *iocb, struct iov_iter *iter) return generic_file_read_iter(iocb, iter); } +static ssize_t ntfs_file_splice_read(struct file *in, loff_t *ppos, + struct pipe_inode_info *pipe, + size_t len, unsigned int flags) +{ + struct inode *inode = in->f_mapping->host; + struct ntfs_inode *ni = ntfs_i(inode); + + if (is_encrypted(ni)) { + ntfs_inode_warn(inode, "encrypted i/o not supported"); + return -EOPNOTSUPP; + } + + if (is_compressed(ni) && (in->f_flags & O_DIRECT)) { + ntfs_inode_warn(inode, "direct i/o + compressed not supported"); + return -EOPNOTSUPP; + } + +#ifndef CONFIG_NTFS3_LZX_XPRESS + if (ni->ni_flags & NI_FLAG_COMPRESSED_MASK) { + ntfs_inode_warn( + inode, + "activate CONFIG_NTFS3_LZX_XPRESS to read external compressed files"); + return -EOPNOTSUPP; + } +#endif + + if (is_dedup(ni)) { + ntfs_inode_warn(inode, "read deduplicated not supported"); + return -EOPNOTSUPP; + } + + return generic_file_splice_read(in, ppos, pipe, len, flags); +} + /* * ntfs_get_frame_pages * @@ -1159,7 +1193,7 @@ const struct file_operations ntfs_file_operations = { #ifdef CONFIG_COMPAT .compat_ioctl = ntfs_compat_ioctl, #endif - .splice_read = generic_file_splice_read, + .splice_read = ntfs_file_splice_read, .mmap = ntfs_file_mmap, .open = ntfs_file_open, .fsync = generic_file_fsync,