| Message ID | 20230518132905.4182265-1-hugo@hugovil.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp502984vqo;
Thu, 18 May 2023 06:44:09 -0700 (PDT)
X-Google-Smtp-Source:
ACHHUZ42u6jck8fir7Zg2YZkfEBCFqsqgn6m0uaAe201YcPIMEOGjiFPsq/ckJ0ilIfhd1Gb0CXI
X-Received: by 2002:a17:90a:d583:b0:250:461:ae65 with SMTP id
v3-20020a17090ad58300b002500461ae65mr2817473pju.5.1684417448828;
Thu, 18 May 2023 06:44:08 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1684417448; cv=none;
d=google.com; s=arc-20160816;
b=pBZ+cPnnITsq5FVFdsfbOSUXN7Wl6fQ0IeMn+btpPIqi01cx7DOlhYdxB54wAzo/aY
dpSreC5F+9CZWUHDIxR6WHESNKTAzob9cTPdIKPyE/i8qRRg3Px2iGR2ggct94x+eRpd
rdwwUJNFhbUPEWEmFTBE1trp4QbazZFAwwT+3o/67Xom9vZo6vD/EEcLX38KoeCxHhNq
Yb8dkDcDA5leewW75sA/aJqRsegV3c7CIlykFXksDGSVASi1QyivxsYVaRVhdUCrP/qz
/24gBRl7fs60UI14tu8M+01BzPRKQjxeFcNiUEVmjDTkshubRoXDI+MJgUoSYCUSdbJw
XP9Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:subject:content-transfer-encoding:mime-version
:message-id:date:cc:to:from:dkim-signature;
bh=gv+Uil0bms5UyRlK+q3kZYwBqsWMgwJratCLIUValBY=;
b=HjJ/U7OfJZQxoYT+HwhTvZ8fa0UqwUKA8ybWQvkoiup1fq+Cff+nVbj4sB+GWlZ50H
5BsLpFCNN3Z1aSN74tswsW6nLKicYL+oceVJCxYZchHp+XR5SGWsRDF4BYiHFIUy7Oj0
SL9zjlJGEphyLwDyQbMsBIgexw9NJFpCj2GTgCFsdjLyf31EvdvAIVKv0Z10o6/C7f4c
3+PsT5zswUv+VleFVyvI9yziFlUcEhKKs+WlAsnoGAQCPvBINJEtkz5hYZAq0G/JK2Ig
WoTfI6U91Ndy5DgF/9p6IYYDz90mv5ZdKpj1RSuPU0VHYwSOkb4iVR7CJemcU11eq4P3
2JkQ==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=fail header.i=@hugovil.com header.s=x header.b=J0pxBQBD;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
cc9-20020a17090af10900b002473e331f90si1731470pjb.46.2023.05.18.06.43.55;
Thu, 18 May 2023 06:44:08 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=fail header.i=@hugovil.com header.s=x header.b=J0pxBQBD;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S231488AbjERNcT (ORCPT <rfc822;pacteraone@gmail.com> + 99 others);
Thu, 18 May 2023 09:32:19 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56524 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S231486AbjERNcP (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Thu, 18 May 2023 09:32:15 -0400
Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2718E19AA;
Thu, 18 May 2023 06:32:01 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com
; s=x;
h=Subject:Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Cc:To
:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date
:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:
References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:
List-Owner:List-Archive;
bh=gv+Uil0bms5UyRlK+q3kZYwBqsWMgwJratCLIUValBY=; b=J
0pxBQBD60cRfykraZOpAovm6FFBHPsefVM9QK0e5pUAE2mL4a1QeGvwZ0Ym9My/XVyOvIRTUI9k9S
B2MyFqcUDlguUdxf0KsKe9weZnZHqv70UvnYApX8WDd7Ymg8wBAf/jxkzwOhUSaVfzyVbkaeYil4g
WzGBjwDuorAU+AEA=;
Received: from modemcable168.174-80-70.mc.videotron.ca ([70.80.174.168]:36904
helo=pettiford.lan)
by mail.hugovil.com with esmtpa (Exim 4.92)
(envelope-from <hugo@hugovil.com>)
id 1pzdjZ-0004WC-V9; Thu, 18 May 2023 09:31:58 -0400
From: Hugo Villeneuve <hugo@hugovil.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: hugo@hugovil.com, linux-gpio@vger.kernel.org,
Hugo Villeneuve <hvilleneuve@dimonoff.com>,
linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Date: Thu, 18 May 2023 09:29:06 -0400
Message-Id: <20230518132905.4182265-1-hugo@hugovil.com>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SA-Exim-Connect-IP: 70.80.174.168
X-SA-Exim-Mail-From: hugo@hugovil.com
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
X-Spam-Level:
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,
T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
Subject: [RFC PATCH v2 1/2] dt-bindings: sc16is7xx: Add property to change
GPIO function
X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000)
X-SA-Exim-Scanned: Yes (on mail.hugovil.com)
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1766239710665169042?=
X-GMAIL-MSGID: =?utf-8?q?1766239710665169042?=
|
| Series |
[RFC,v2,1/2] dt-bindings: sc16is7xx: Add property to change GPIO function
|
|
Commit Message
Hugo Villeneuve
May 18, 2023, 1:29 p.m. UTC
From: Hugo Villeneuve <hvilleneuve@dimonoff.com> Some variants in this series of uart controllers have GPIO pins that are shared between GPIO and modem control lines. The pin mux mode (GPIO or modem control lines) can be set for each ports (channels) supported by the variant. This adds a property to the device tree to set the GPIO pin mux to modem control lines on selected ports if needed. Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> --- v1 -> v2: Add nxp vendor prefix Add git base-commit .../bindings/serial/nxp,sc16is7xx.txt | 28 +++++++++++++++++++ 1 file changed, 28 insertions(+) base-commit: 4d6d4c7f541d7027beed4fb86eb2c451bd8d6fff
Comments
On Thu, May 18, 2023 at 09:29:06AM -0400, Hugo Villeneuve wrote: > From: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > Some variants in this series of uart controllers have GPIO pins that > are shared between GPIO and modem control lines. > > The pin mux mode (GPIO or modem control lines) can be set for each > ports (channels) supported by the variant. > > This adds a property to the device tree to set the GPIO pin mux to > modem control lines on selected ports if needed. > > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> On the basis of similarity to existing properties due to my lack of understanding of the hardware it'll have to be an Ack. Hopefully Greg & Co. have more specific insight. Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor. > --- > v1 -> v2: Add nxp vendor prefix > Add git base-commit > > .../bindings/serial/nxp,sc16is7xx.txt | 28 +++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt > index 0fa8e3e43bf8..23a81c83f012 100644 > --- a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt > +++ b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt > @@ -23,6 +23,9 @@ Optional properties: > 1 = active low. > - irda-mode-ports: An array that lists the indices of the port that > should operate in IrDA mode. > +- nxp,modem-control-line-ports: An array that lists the indices of the port that > + should have shared GPIO lines configured as modem > + control lines. > > Example: > sc16is750: sc16is750@51 { > @@ -35,6 +38,17 @@ Example: > #gpio-cells = <2>; > }; > > + sc16is752: sc16is752@54 { > + compatible = "nxp,sc16is752"; > + reg = <0x54>; > + clocks = <&clk20m>; > + interrupt-parent = <&gpio3>; > + interrupts = <7 IRQ_TYPE_EDGE_FALLING>; > + nxp,modem-control-line-ports = <1>; /* Port 1 as modem control lines */ > + gpio-controller; /* Port 0 as GPIOs */ > + #gpio-cells = <2>; > + }; > + > * spi as bus > > Required properties: > @@ -59,6 +73,9 @@ Optional properties: > 1 = active low. > - irda-mode-ports: An array that lists the indices of the port that > should operate in IrDA mode. > +- nxp,modem-control-line-ports: An array that lists the indices of the port that > + should have shared GPIO lines configured as modem > + control lines. > > Example: > sc16is750: sc16is750@0 { > @@ -70,3 +87,14 @@ Example: > gpio-controller; > #gpio-cells = <2>; > }; > + > + sc16is752: sc16is752@0 { > + compatible = "nxp,sc16is752"; > + reg = <0>; > + clocks = <&clk20m>; > + interrupt-parent = <&gpio3>; > + interrupts = <7 IRQ_TYPE_EDGE_FALLING>; > + nxp,modem-control-line-ports = <1>; /* Port 1 as modem control lines */ > + gpio-controller; /* Port 0 as GPIOs */ > + #gpio-cells = <2>; > + }; > > base-commit: 4d6d4c7f541d7027beed4fb86eb2c451bd8d6fff > -- > 2.30.2 >
Hello Hugo, W dniu 18.05.2023 o 15:29, Hugo Villeneuve pisze: > From: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > Some variants in this series of uart controllers have GPIO pins that > are shared between GPIO and modem control lines. > > The pin mux mode (GPIO or modem control lines) can be set for each > ports (channels) supported by the variant. > > This adds a property to the device tree to set the GPIO pin mux to > modem control lines on selected ports if needed. > > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> > --- > v1 -> v2: Add nxp vendor prefix > Add git base-commit > > .../bindings/serial/nxp,sc16is7xx.txt | 28 +++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt > index 0fa8e3e43bf8..23a81c83f012 100644 > --- a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt > +++ b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt > @@ -23,6 +23,9 @@ Optional properties: > 1 = active low. > - irda-mode-ports: An array that lists the indices of the port that > should operate in IrDA mode. > +- nxp,modem-control-line-ports: An array that lists the indices of the port that > + should have shared GPIO lines configured as modem > + control lines. > > Example: > sc16is750: sc16is750@51 { > @@ -35,6 +38,17 @@ Example: > #gpio-cells = <2>; > }; > > + sc16is752: sc16is752@54 { > + compatible = "nxp,sc16is752"; > + reg = <0x54>; > + clocks = <&clk20m>; > + interrupt-parent = <&gpio3>; > + interrupts = <7 IRQ_TYPE_EDGE_FALLING>; > + nxp,modem-control-line-ports = <1>; /* Port 1 as modem control lines */ > + gpio-controller; /* Port 0 as GPIOs */ > + #gpio-cells = <2>; > + }; > + > * spi as bus > > Required properties: > @@ -59,6 +73,9 @@ Optional properties: > 1 = active low. > - irda-mode-ports: An array that lists the indices of the port that > should operate in IrDA mode. > +- nxp,modem-control-line-ports: An array that lists the indices of the port that > + should have shared GPIO lines configured as modem > + control lines. > > Example: > sc16is750: sc16is750@0 { > @@ -70,3 +87,14 @@ Example: > gpio-controller; > #gpio-cells = <2>; > }; > + > + sc16is752: sc16is752@0 { > + compatible = "nxp,sc16is752"; > + reg = <0>; > + clocks = <&clk20m>; > + interrupt-parent = <&gpio3>; > + interrupts = <7 IRQ_TYPE_EDGE_FALLING>; > + nxp,modem-control-line-ports = <1>; /* Port 1 as modem control lines */ Just a minor nitpick: an example showing syntax for both ports would be great. This can be included here, leaving the previous example intact. Otherwise, LGTM. > + gpio-controller; /* Port 0 as GPIOs */ > + #gpio-cells = <2>; > + }; > > base-commit: 4d6d4c7f541d7027beed4fb86eb2c451bd8d6fff > -- > 2.30.2
On Fri, 19 May 2023 15:03:37 +0200 Lech Perczak <lech.perczak@camlingroup.com> wrote: > Hello Hugo, > > W dniu 18.05.2023 o 15:29, Hugo Villeneuve pisze: > > From: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > > > Some variants in this series of uart controllers have GPIO pins that > > are shared between GPIO and modem control lines. > > > > The pin mux mode (GPIO or modem control lines) can be set for each > > ports (channels) supported by the variant. > > > > This adds a property to the device tree to set the GPIO pin mux to > > modem control lines on selected ports if needed. > > > > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> > > --- > > v1 -> v2: Add nxp vendor prefix > > Add git base-commit > > > > .../bindings/serial/nxp,sc16is7xx.txt | 28 +++++++++++++++++++ > > 1 file changed, 28 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt > > index 0fa8e3e43bf8..23a81c83f012 100644 > > --- a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt > > +++ b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt > > @@ -23,6 +23,9 @@ Optional properties: > > 1 = active low. > > - irda-mode-ports: An array that lists the indices of the port that > > should operate in IrDA mode. > > +- nxp,modem-control-line-ports: An array that lists the indices of the port that > > + should have shared GPIO lines configured as modem > > + control lines. > > > > Example: > > sc16is750: sc16is750@51 { > > @@ -35,6 +38,17 @@ Example: > > #gpio-cells = <2>; > > }; > > > > + sc16is752: sc16is752@54 { > > + compatible = "nxp,sc16is752"; > > + reg = <0x54>; > > + clocks = <&clk20m>; > > + interrupt-parent = <&gpio3>; > > + interrupts = <7 IRQ_TYPE_EDGE_FALLING>; > > + nxp,modem-control-line-ports = <1>; /* Port 1 as modem control lines */ > > + gpio-controller; /* Port 0 as GPIOs */ > > + #gpio-cells = <2>; > > + }; > > + > > * spi as bus > > > > Required properties: > > @@ -59,6 +73,9 @@ Optional properties: > > 1 = active low. > > - irda-mode-ports: An array that lists the indices of the port that > > should operate in IrDA mode. > > +- nxp,modem-control-line-ports: An array that lists the indices of the port that > > + should have shared GPIO lines configured as modem > > + control lines. > > > > Example: > > sc16is750: sc16is750@0 { > > @@ -70,3 +87,14 @@ Example: > > gpio-controller; > > #gpio-cells = <2>; > > }; > > + > > + sc16is752: sc16is752@0 { > > + compatible = "nxp,sc16is752"; > > + reg = <0>; > > + clocks = <&clk20m>; > > + interrupt-parent = <&gpio3>; > > + interrupts = <7 IRQ_TYPE_EDGE_FALLING>; > > + nxp,modem-control-line-ports = <1>; /* Port 1 as modem control lines */ > Just a minor nitpick: an example showing syntax for both ports would be great. > This can be included here, leaving the previous example intact. Otherwise, LGTM. > > + gpio-controller; /* Port 0 as GPIOs */ > > + #gpio-cells = <2>; Hi, I have decided to add a separate example, because adding an example for both ports also means that the gpio-controller property should be removed. Hugo. > > + }; > > > > base-commit: 4d6d4c7f541d7027beed4fb86eb2c451bd8d6fff > > -- > > 2.30.2 > > -- > Pozdrawiam/With kind regards, > Lech Perczak > > Sr. Software Engineer > Camlin Technologies Poland Limited Sp. z o.o. > Strzegomska 54, > 53-611 Wroclaw > Tel: (+48) 71 75 000 16 > Email: lech.perczak@camlingroup.com > Website: http://www.camlingroup.com > >
diff --git a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt index 0fa8e3e43bf8..23a81c83f012 100644 --- a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt +++ b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt @@ -23,6 +23,9 @@ Optional properties: 1 = active low. - irda-mode-ports: An array that lists the indices of the port that should operate in IrDA mode. +- nxp,modem-control-line-ports: An array that lists the indices of the port that + should have shared GPIO lines configured as modem + control lines. Example: sc16is750: sc16is750@51 { @@ -35,6 +38,17 @@ Example: #gpio-cells = <2>; }; + sc16is752: sc16is752@54 { + compatible = "nxp,sc16is752"; + reg = <0x54>; + clocks = <&clk20m>; + interrupt-parent = <&gpio3>; + interrupts = <7 IRQ_TYPE_EDGE_FALLING>; + nxp,modem-control-line-ports = <1>; /* Port 1 as modem control lines */ + gpio-controller; /* Port 0 as GPIOs */ + #gpio-cells = <2>; + }; + * spi as bus Required properties: @@ -59,6 +73,9 @@ Optional properties: 1 = active low. - irda-mode-ports: An array that lists the indices of the port that should operate in IrDA mode. +- nxp,modem-control-line-ports: An array that lists the indices of the port that + should have shared GPIO lines configured as modem + control lines. Example: sc16is750: sc16is750@0 { @@ -70,3 +87,14 @@ Example: gpio-controller; #gpio-cells = <2>; }; + + sc16is752: sc16is752@0 { + compatible = "nxp,sc16is752"; + reg = <0>; + clocks = <&clk20m>; + interrupt-parent = <&gpio3>; + interrupts = <7 IRQ_TYPE_EDGE_FALLING>; + nxp,modem-control-line-ports = <1>; /* Port 1 as modem control lines */ + gpio-controller; /* Port 0 as GPIOs */ + #gpio-cells = <2>; + };