From patchwork Thu May 18 07:27:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 95679 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp302616vqo; Thu, 18 May 2023 00:29:40 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7EbVh8u0r/WzAR9RzRtVEi3orP1/NwRk+20m4Sa5WsYZRNG69WvZiNcaiJDDw23T0kbpBt X-Received: by 2002:a05:6a21:7899:b0:101:90e:c0cb with SMTP id bf25-20020a056a21789900b00101090ec0cbmr1289209pzc.59.1684394980127; Thu, 18 May 2023 00:29:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684394980; cv=none; d=google.com; s=arc-20160816; b=ZSRrKkFZX+AiUhSb9eQfmgKzpKOkDoF081qo+GtaEVLlEvCoJhDuV1AyvUUbmSngZD 4WWSrR2pGwLNKnlD9XIjZO4ygG6pSyWHG9nFPeeisQyF4L69T3AYbpsXoeBxEGeY0yTO AX5/PktMmwHQf/1txXf6w8LL8p93RoEcUIP+tTlD+cjHt2xGnUuqOft36L0D7MV9MMEH UDRaidSBGUTWgEMT3ERM7CCbO2ep6iVw/XwQYsdl6+34eS76AwcFAxrT4Xxk9AOMl6rh TmCcmvQbNlq+/Ec0A+ndTdHps0TcOWpOSaaUFjEHk8jxDuOtZ6JyUhiKE56HYJsRah4i 65VA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=xY4US8j109ap8g7iJPTxaqGh/0KFUvHJ6e/HWa50JR0=; b=rc06H3Hnyt5nN0H6i5j/kVHT+0hz4aTnQB38BYEw6QliNihnQCQpj5n0M0mdbSjbwf 6clC8+VrMHTSN4BrjgJZtzud4f4knMlIf4aCaXVigzrqi0oh+VF0uiiOLmNGvznzSH+x B68d+XAlzGuUB0LHvWtOiHskJLHUMhLSlY1PqfYsc+NM2rBBpxAN5nhH6kKPMd52yw5e CsNZeeJ4iu3uijQ2fksP8OC4qGdNyP67iYXCjJGzpgmEKxrO9yT+wlDSj/nAG2CCXvUJ qHWP74/uS4fxGjvhx9m6PLrKOMhDTeipy9tDKPK6F9qcgWPcfishEKVulcIQjTHocgI3 24Yw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VdCXcIJz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v190-20020a6389c7000000b0052c6c5bc1e6si894482pgd.247.2023.05.18.00.29.25; Thu, 18 May 2023 00:29:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VdCXcIJz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230119AbjERH2K (ORCPT + 99 others); Thu, 18 May 2023 03:28:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229527AbjERH2A (ORCPT ); Thu, 18 May 2023 03:28:00 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C9D519BB for ; Thu, 18 May 2023 00:27:59 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-510ddeab704so1210579a12.3 for ; Thu, 18 May 2023 00:27:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684394878; x=1686986878; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xY4US8j109ap8g7iJPTxaqGh/0KFUvHJ6e/HWa50JR0=; b=VdCXcIJz3zJr+Z194kctgRAjtWQyZ8oKgT3cqsKr2mbtExnmGXiP6sq1k6ff7pm/cB /2TbXgKWQfA5/hdwYF5YeQPaNdZAM6GBNHvIztoou8hegf3uUbCwiCQxBQX7becb0J6M lSzA5ZWORuBJMzq9QGt1+2CoYD/6tUMsrMb+62zbEZTlWDdZp4urjE1QejdtIqapndS6 J/0dwAFwWXC1PxLwiryYg76queLaMNfzQKhH1j10QGIqdXI/u+qvtIS2ObSyuWofmM4x Rj4fm6iHvvf27XCjbs63mUYGm8d37NdEiWizcFIZBEva1cii+s7v/DLYuB2hA1gu/0bl GaEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684394878; x=1686986878; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xY4US8j109ap8g7iJPTxaqGh/0KFUvHJ6e/HWa50JR0=; b=jzvEjT9scgvkrCk9hWUAP8UeZ0qA+Fh6DsUMyVPN9ihUBLY/lseCtq/bY+ZaXgt6SB Os4yZqrA21KMwAUvRIAqLYJ/NBEgSzHBYxY+1h3D1bDLTrN4b3PifB2JZ9Idcu6KhMdj YFYj/PusOljJab0VmoUutH7YPrmwR3/F5UW8jowaSwfys7pVJKiD5jfOab8GkE7qfQCB lHBLRuiMEvffuS8aMr+2qIm9hgObhIMhzuSoDdnDWrNQ2rD8fjIj0rkrsHuTfdWO1858 p9NNJJ4O00oB3AksgqFT8tBz9cdF7yyfY2doXQZhag8REdwjGlcgqWRMap2pWrHVLmGI BY2Q== X-Gm-Message-State: AC+VfDxftscLBdyNsAJbKkTvZOW+9nz9VJgZ8Fkr2DH/V0M2AxOaJdip reLsqLHi2fOB7RDHlYH4jDjHvA== X-Received: by 2002:a17:907:1ca8:b0:96a:bfc:7342 with SMTP id nb40-20020a1709071ca800b0096a0bfc7342mr32079981ejc.62.1684394878057; Thu, 18 May 2023 00:27:58 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a2b:c408:5834:f48e]) by smtp.gmail.com with ESMTPSA id g17-20020a17090669d100b00965aee5be9asm594241ejs.170.2023.05.18.00.27.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 May 2023 00:27:57 -0700 (PDT) From: Krzysztof Kozlowski To: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , Pierre-Louis Bossart Subject: [RESEND PATCH 01/12] ASoC: codecs: rt1308: do not store status in state container Date: Thu, 18 May 2023 09:27:42 +0200 Message-Id: <20230518072753.7361-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230518072753.7361-1-krzysztof.kozlowski@linaro.org> References: <20230518072753.7361-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766216150814877988?= X-GMAIL-MSGID: =?utf-8?q?1766216150814877988?= Driver in its update status callback stores Soundwire device status in state container but it never uses it later. Simplify the code a bit. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Pierre-Louis Bossart --- sound/soc/codecs/rt1308-sdw.c | 5 +---- sound/soc/codecs/rt1308-sdw.h | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/rt1308-sdw.c b/sound/soc/codecs/rt1308-sdw.c index 1797af824f60..313e97c94532 100644 --- a/sound/soc/codecs/rt1308-sdw.c +++ b/sound/soc/codecs/rt1308-sdw.c @@ -304,9 +304,6 @@ static int rt1308_update_status(struct sdw_slave *slave, { struct rt1308_sdw_priv *rt1308 = dev_get_drvdata(&slave->dev); - /* Update the status */ - rt1308->status = status; - if (status == SDW_SLAVE_UNATTACHED) rt1308->hw_init = false; @@ -314,7 +311,7 @@ static int rt1308_update_status(struct sdw_slave *slave, * Perform initialization only if slave status is present and * hw_init flag is false */ - if (rt1308->hw_init || rt1308->status != SDW_SLAVE_ATTACHED) + if (rt1308->hw_init || status != SDW_SLAVE_ATTACHED) return 0; /* perform I/O transfers required for Slave initialization */ diff --git a/sound/soc/codecs/rt1308-sdw.h b/sound/soc/codecs/rt1308-sdw.h index 04ff18fa18e2..f816c73e247e 100644 --- a/sound/soc/codecs/rt1308-sdw.h +++ b/sound/soc/codecs/rt1308-sdw.h @@ -159,7 +159,6 @@ struct rt1308_sdw_priv { struct snd_soc_component *component; struct regmap *regmap; struct sdw_slave *sdw_slave; - enum sdw_slave_status status; struct sdw_bus_params params; bool hw_init; bool first_hw_init;