From patchwork Thu May 18 07:27:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 95688 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp305536vqo; Thu, 18 May 2023 00:36:22 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7CBi+qT0ay9rKWdJ7o06y2l/xM9mLvlAVhNRbeWjzHPXX5+9VVqKJwUXGSH1r14Vfw+9ks X-Received: by 2002:a05:6a00:15c2:b0:645:cfb0:2779 with SMTP id o2-20020a056a0015c200b00645cfb02779mr3613635pfu.26.1684395381665; Thu, 18 May 2023 00:36:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684395381; cv=none; d=google.com; s=arc-20160816; b=sq/vbIF2pw2bponFuHtHUP/lpXhGuV+Q/AoG0vK6Ccd3u39UGGl7Y/Hh5aY2LSrusd TR7F+yhVyZRj/KLNcKRcwhTdL7xyhlXnKFN2Ll6LINHgRJuFvUJDRPQjoDZwyMdP9pfN FbO6CnvmnjhubvnGYb3bHZkppLLNPoFxINOGfN0EGxwotKedF1lCpmfn+Md4Hcd64Pvq 53T+VEldKXPWfJf564VCIX88sVTwkQV7VZFoKka8ISKL46pUWMvBUtU+sOUV3YvUtpq5 WbtbeldnfThHoCrT36t1ItsUU0GCXrR/lMUqkCKS/6Z3YwZIVvH3I7iAgb2m5sUNzSM7 95ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=XVXk2J0zDtxw+0Qou5QUMtzlXSrHNQ48trwuAxglr6Q=; b=bGlO2WRenF0sM9gen9lFnY3+3r5/N79i3ZO84ss8B+hnEP6uqv1bAp7GmRmWBMCpHL rEZi3BShjTQ88P9Vk4uC9S3zCRSObMBE/ZQws2Rqq9hnQWdrxJE0paYrw1iOL4vW9Aqz LlLStr+ngG0Yv6QjonLe7bCIRnWJcQr+X8tvLk4JE305H1UmZ6/Ha05GOR85z5G3GzFE H+HWWM0DhJM8F/VHSE7JyJYy3GYSDoe6csY8/ZZMftCuAF6HZHrxVE3qSCz995/6jMRL 5DwNJYdUdq79RlZjfeienRtV210PGQ22Ha4WdR4iowLtG7cd4RgRTNgb+WgYtz1zmQtF EylQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="SY4zlhD/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q3-20020aa79823000000b00644c38feecfsi1087713pfl.68.2023.05.18.00.36.08; Thu, 18 May 2023 00:36:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="SY4zlhD/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230156AbjERH2u (ORCPT + 99 others); Thu, 18 May 2023 03:28:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230088AbjERH2Z (ORCPT ); Thu, 18 May 2023 03:28:25 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D3D22D55 for ; Thu, 18 May 2023 00:28:11 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-96f0678de80so292210766b.3 for ; Thu, 18 May 2023 00:28:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684394890; x=1686986890; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XVXk2J0zDtxw+0Qou5QUMtzlXSrHNQ48trwuAxglr6Q=; b=SY4zlhD/Ae3NqKWMgCYMmnInKUuz8aaW8w1LrZj140mUYU5ssSsPDI2EaABgQV9yap Ernl5l+MQeuF813vs5dgtI3WN3/XEiNudVVFA0hkaEZ04MQ1bZCxFSWxvUdn6kImX9+V IgVBEGaTPpfiGrTgAqGxD32MVO3InaXImAWE2u9wbz7HoXqOsm+0equhQfc5EpKrAtEO stmHcBuSxYTR4GnFSv0T6INTHLSjpLcWbXQOs/KvYprUoPnIioiimgAKeyhBOhy+brFc tR0btKWih37xTmEtBAEVCjy5nGMy4zD622zLbnzNYpyK4K6T85rxfEQtxaaLr7X45K6F 9nGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684394890; x=1686986890; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XVXk2J0zDtxw+0Qou5QUMtzlXSrHNQ48trwuAxglr6Q=; b=Rhe/6vI2sEsTum8W/KyI4SB4/ITbEqP7ks2nHhONax+6GVT/jaMFXSjh4Zq14Jc11q /++A9as9AsdZsBAUYT+jm7AeUzKY/7IXDk/LOv53FQsw+VdcLucrB5AEZ1Neb7qUK/A5 lACszwa8/VmEJgeuQm933IW/hDhJtU+jO6jkbf9OJok+ha0NJ86ykWwQQq9EiHGp7T6Y P+BQJFPJWnFevD5PvtUPhUcjZRv9CQb3YHw+pr7rwqBRBbJoEEgf59PTHSNgLUmyiTCQ Kz2cqYYdxIBJd4XmPXEz6fLKLIl6rfTvpvT0FMjII1Lu5AqV7DByqL4Gm5EuA4alBKBf lqAw== X-Gm-Message-State: AC+VfDx2M5Kvu5NLjmE7ONHEy4E6OJ87kBnf3WtbWHEVcG9Xpn8X3DSi QIrt/sgz/DXrBVPQ1mEHHhkaNDJnOKqpyTGGF9epHw== X-Received: by 2002:a17:907:80e:b0:94e:9a73:1637 with SMTP id wv14-20020a170907080e00b0094e9a731637mr36831708ejb.75.1684394889884; Thu, 18 May 2023 00:28:09 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a2b:c408:5834:f48e]) by smtp.gmail.com with ESMTPSA id g17-20020a17090669d100b00965aee5be9asm594241ejs.170.2023.05.18.00.28.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 May 2023 00:28:09 -0700 (PDT) From: Krzysztof Kozlowski To: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , Pierre-Louis Bossart Subject: [RESEND PATCH 11/12] ASoC: codecs: rt715: do not store status in state container Date: Thu, 18 May 2023 09:27:52 +0200 Message-Id: <20230518072753.7361-12-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230518072753.7361-1-krzysztof.kozlowski@linaro.org> References: <20230518072753.7361-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766216571814450408?= X-GMAIL-MSGID: =?utf-8?q?1766216571814450408?= Driver in its update status callback stores Soundwire device status in state container but it never uses it later. Simplify the code a bit. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Pierre-Louis Bossart --- sound/soc/codecs/rt715-sdw.c | 4 +--- sound/soc/codecs/rt715.h | 1 - 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/sound/soc/codecs/rt715-sdw.c b/sound/soc/codecs/rt715-sdw.c index 5ffe9a00dfd8..6db87442b783 100644 --- a/sound/soc/codecs/rt715-sdw.c +++ b/sound/soc/codecs/rt715-sdw.c @@ -417,13 +417,11 @@ static int rt715_update_status(struct sdw_slave *slave, { struct rt715_priv *rt715 = dev_get_drvdata(&slave->dev); - /* Update the status */ - rt715->status = status; /* * Perform initialization only if slave status is present and * hw_init flag is false */ - if (rt715->hw_init || rt715->status != SDW_SLAVE_ATTACHED) + if (rt715->hw_init || status != SDW_SLAVE_ATTACHED) return 0; /* perform I/O transfers required for Slave initialization */ diff --git a/sound/soc/codecs/rt715.h b/sound/soc/codecs/rt715.h index 17a8d041c1c3..12a0ae656d09 100644 --- a/sound/soc/codecs/rt715.h +++ b/sound/soc/codecs/rt715.h @@ -18,7 +18,6 @@ struct rt715_priv { int dbg_nid; int dbg_vid; int dbg_payload; - enum sdw_slave_status status; struct sdw_bus_params params; bool hw_init; bool first_hw_init;