From patchwork Thu May 18 02:18:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Fernandes X-Patchwork-Id: 95620 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp189222vqo; Wed, 17 May 2023 19:24:29 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6BCArkMeqbcd6WUz2jqn1Ij7QvzDBKTY1lL26pQROb5QXIC+s+Mf+rfEm8O0BGmXfWis80 X-Received: by 2002:a17:903:32cc:b0:1a9:581b:fbb1 with SMTP id i12-20020a17090332cc00b001a9581bfbb1mr570154plr.32.1684376669304; Wed, 17 May 2023 19:24:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684376669; cv=none; d=google.com; s=arc-20160816; b=tmcEs7r6QUJFJimtKuhYes8rDHEy+XMeB7cRX1HDZPYSG5nZpbJvhh8U/l7TSeHD9y MykbB44vfYmcg599202RvvLC+ZQqGoC2CzgKcJ8xZQWH/ft3opBKBRyLEUzgPr/IPtj0 V7qUFejxFkkNNgpp+mgJDuzCh4UepX4XdZRUg2kBzkbSwXHcXS3GuoCyiHfoKYU6Lit4 MF3eUYz9suVCWPvHAyz6t/XaxjOlbwhbhkvq24rxbeuFve+PF9jDCVpBMRMAn9eagGjb bljb6vJWqC1FP0YRqJZBvDQb8QHlHUQdiDjJwES3MFvZqBMIi2NHljKiETrbwc88k6+d yWXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=RjDDJEmMByrSrRAzAnrYD81CTFNgsqIfOqapJ9IGu5M=; b=HEyvyo4BJRZTDZc0nTY+2DOtSBFtZV8L4hu6rm8hDVhaJw+gmt3peGNovdXw1F/21i aCphxTnARhioc5UZZxHw0lzdzTYTXiwGJdPmfEMXTr3GCR5XEe+CUHAD/Wyv/pzDVuNv zYoJWW0ymjFmBNwwKMxPz0Z+HLiFIe6yoCdeZH6lH78bI6/D2xSlZZ3EyRE3klqnAPMy 4SD0WO4AZujMfBTMTEkjj0jn1DVN+EmnoLw2YPZhvD5xXiJdUi6LYiPgsS7wSlcvv6C8 lxo5a8FySXPG82EumPvMAe8tPjbcTPCowen2BaSW8vbN4jxN4TXAj/eYpa0hrEurqjkI FDYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=mQQrGh4h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t9-20020a170902e84900b001aadb1147e4si133686plg.456.2023.05.17.19.24.14; Wed, 17 May 2023 19:24:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=mQQrGh4h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229901AbjERCTF (ORCPT + 99 others); Wed, 17 May 2023 22:19:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229851AbjERCSs (ORCPT ); Wed, 17 May 2023 22:18:48 -0400 Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63FAA210C for ; Wed, 17 May 2023 19:18:47 -0700 (PDT) Received: by mail-qt1-x82f.google.com with SMTP id d75a77b69052e-3f52009f79dso3739871cf.1 for ; Wed, 17 May 2023 19:18:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1684376326; x=1686968326; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RjDDJEmMByrSrRAzAnrYD81CTFNgsqIfOqapJ9IGu5M=; b=mQQrGh4h/KNWIK2PoMB6Pztwf3cVCXmBMz0qqgOhBsvYUoYmvpqwqduJIzlAMMC7YK ZrUS/hiBuG72PkbcadbIrnygdqpWVUoSGwOt1fIX6LFaYv2ZtLweuzoryGI5e/lbAEvj QAZwZXY/iYOPxIXmup+iJ05KpzCFPd+H+MV7k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684376326; x=1686968326; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RjDDJEmMByrSrRAzAnrYD81CTFNgsqIfOqapJ9IGu5M=; b=Q/S1KR0foY6LzmuZjYDbtMUopnF9s0nhgASiCTYbTDub1bxXqkieaK2RucSC7ofZLk 6LFTklhpxd9B2mCUC+PqP9Ey6UQ1m42JIsXBmVCpcZHkcZ1yhZtLzyseDQ7eza3Vfu2u EgKe/bRJ2JcvNhziXnUaK4TM1F8M3alB2bpNGKvyVxgKAN4lM05Lt3Uo69nFEgbX3IGU loPxhgVkMNwuZDsF3Wy1xsDayUAwlGmDHknJl86u5qCK2fxgwJYOSesmwd/Il5uWZT9e gku0AQtgHw1DvU0lyTvGgGIAWOSi1/645fwDeShHWXkQTmQCPRpLZbKDLoWITwy1bsLJ qcIg== X-Gm-Message-State: AC+VfDxpU3uThaMKlrog+pkByD0g80ySWbCkf9LShPFIF5KNgP2mcg72 ZpUUeIymaPg6K5eYIT6Hbi8w/MV4bAudSNFM8aE= X-Received: by 2002:ac8:588f:0:b0:3f5:2fa4:43bd with SMTP id t15-20020ac8588f000000b003f52fa443bdmr3399132qta.3.1684376325860; Wed, 17 May 2023 19:18:45 -0700 (PDT) Received: from joelboxx.c.googlers.com.com (129.239.188.35.bc.googleusercontent.com. [35.188.239.129]) by smtp.gmail.com with ESMTPSA id j13-20020a05620a000d00b007577ccf566asm85082qki.93.2023.05.17.19.18.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 19:18:45 -0700 (PDT) From: "Joel Fernandes (Google)" To: linux-kernel@vger.kernel.org Cc: "Joel Fernandes (Google)" , linux-kselftest@vger.kernel.org, linux-mm@kvack.org, Shuah Khan , Vlastimil Babka , Michal Hocko , Linus Torvalds , Lorenzo Stoakes , Kirill A Shutemov , "Liam R. Howlett" , "Paul E. McKenney" Subject: [PATCH RFC 2/4] selftests: mm: Fix failure case when new remap region was not found Date: Thu, 18 May 2023 02:18:23 +0000 Message-ID: <20230518021825.712742-3-joel@joelfernandes.org> X-Mailer: git-send-email 2.40.1.606.ga4b1b128d6-goog In-Reply-To: <20230518021825.712742-1-joel@joelfernandes.org> References: <20230518021825.712742-1-joel@joelfernandes.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766196950654792634?= X-GMAIL-MSGID: =?utf-8?q?1766196950654792634?= When a valid remap region could not be found, the source mapping is not cleaned up. Fix the goto statement such that the clean up happens. Signed-off-by: Joel Fernandes (Google) --- tools/testing/selftests/mm/mremap_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/mremap_test.c b/tools/testing/selftests/mm/mremap_test.c index 5c3773de9f0f..6822d657f589 100644 --- a/tools/testing/selftests/mm/mremap_test.c +++ b/tools/testing/selftests/mm/mremap_test.c @@ -316,7 +316,7 @@ static long long remap_region(struct config c, unsigned int threshold_mb, if (addr + c.dest_alignment < addr) { ksft_print_msg("Couldn't find a valid region to remap to\n"); ret = -1; - goto out; + goto clean_up_src; } addr += c.dest_alignment; }