From patchwork Wed May 17 20:31:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alice Ryhl X-Patchwork-Id: 95543 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp37265vqo; Wed, 17 May 2023 13:34:21 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6NLm1xnV2VdyPL6mj5cwd0lPVw8NNRT+Vpz2tWcDyoMAliir9UCMx50poOazG/3D3v7bPR X-Received: by 2002:a17:902:c410:b0:1ab:2034:26da with SMTP id k16-20020a170902c41000b001ab203426damr34263plk.51.1684355661575; Wed, 17 May 2023 13:34:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684355661; cv=none; d=google.com; s=arc-20160816; b=TAP9GrT6EV5aBLCtGRXrBwr+2crILtmZJ970TbwbKlhWuJ+NYAtk4G7aBc33S0D5WG R5HqYfJ+itrEP8jqp2T/Tl3MjGlpMBVsf7lAibqRgZ6Ec5kh/OEclBsLN/RQLzcm1etL Xz5/HdT1T231J0NUJo79moPH09NA5z92ZzjaFGEQMhzkInq0bK/x0t3EmNyHK8Jnvk1n Xqmf/H3ELgt8Bi0e3V/auVyN+yqItcr+1jOsTVU28EgyKNh0tGJUy6xnZJJYi9Ao4EI2 nZkatUvceMBWtO3sw39OFmTlA2lSC4GpUsgpBFiInkNi3RR9Nicn668nWhnNwJeUgqbz DCxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:dkim-signature; bh=jLXiUUyXZrTzMck4adUmLD4E9Fc4RhEDENIXEJkaNoM=; b=fgxdEWQM5l8HADmHNrN7KdFFPYAful+Vw7kBcrm7mZM7/bfVDc6mp4WlR304XaZ1z5 Wb7ZUxWWorz00c0hiHtKXlccCn3ONBGEqy9P4vCfQrpd4VIe6kS2fHT1/4u8HIow7sw5 g+AEBrXM+oibRIpaXd66v6VbPPuW+gicpwvEWDWOtnsX8+3hcDpqJyToydyFZCDJ4uUt /BGJHdUkiO5otC1pddd30WM67PVHZCpfsh8jDRRjirwF5c7f5wZ9lJKAY3ZA38EGoIDG 8AtfLao5gU7KewykFC1VEmMS+CLeZnB25GlD6m8clpxin8vHWyT4EfhwSpjPuZ0ZaOzu kSkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=znudaE6I; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c17-20020a170902d49100b0019b090e497esi23065539plg.298.2023.05.17.13.34.08; Wed, 17 May 2023 13:34:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=znudaE6I; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229882AbjEQUb7 (ORCPT + 99 others); Wed, 17 May 2023 16:31:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229829AbjEQUbr (ORCPT ); Wed, 17 May 2023 16:31:47 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACFA29ED1 for ; Wed, 17 May 2023 13:31:39 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-ba2526a8918so2080886276.1 for ; Wed, 17 May 2023 13:31:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1684355498; x=1686947498; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=jLXiUUyXZrTzMck4adUmLD4E9Fc4RhEDENIXEJkaNoM=; b=znudaE6IMsPT1uZOZAWZvlBQ4z18gWvrpr8fQ4zqjHZn7//aWo6ZQ16KmYAioUALok 80CFBTCmDmR4fNUzZUBj27X6ZgckRry3Fu5AZp45GYmXV2veHpWjjyrtCSQoQqXfFt1B 4Ij33s7K67FQEiNQAKgTwoZzNOk6K5OasuA+WzfFmKEab16aipOvC9AC4a0oMtyQ6k7d 0k7oZtWs6TculeG1g/RbFchNLUWoLMWBAR5qgp3kvjsBryBPOkhTeRwWPYYZyfgxVK1t k9AxgpmoHL+5TCJq+1CuAf/e7QXSrYKn7oaL9C7P43K27eB9YFHabF88nKM/ykhEAczq 6k0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684355498; x=1686947498; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jLXiUUyXZrTzMck4adUmLD4E9Fc4RhEDENIXEJkaNoM=; b=K8hHTwfyWIxauhLpxaamRzqk9tm0ixKHSXhkSziifubEmuJD3fZc2jJKuQ0RpztBGG Va400BwcA4IoKi2epqhY8b4c9JypzXApiF9krYS0HADNxTCTR6TLo0FYAwr2+WJ656wm BNTOc827PFx/diNw9euZx6i+QePXx6Y+VXtVWElgvBfYLKWi3vliVXmhKm2iz0wGVg4U eVjTM9xEhq48W4vPCbWfc3WfGJSaftLP6/FbhBC/3OKAaWYxJFe2W8krii0JgYrDvZzI gEbH1QRNlmFEaTNMLiXfASPDobz8BI++/ljNd7TfX6dox6E7zNDiYIy9LWieVvInSSFO JB9g== X-Gm-Message-State: AC+VfDzaxri4ag2XgD74N0YVMeSbN6+Q1WCTqEEQxieRzQGs55Kw+ap1 joYWqlztKibRQDXRo5sxBl9LqtB6OVcukl4= X-Received: from aliceryhl.c.googlers.com ([fda3:e722:ac3:cc00:31:98fb:c0a8:6c8]) (user=aliceryhl job=sendgmr) by 2002:a25:9309:0:b0:ba8:2e79:c193 with SMTP id f9-20020a259309000000b00ba82e79c193mr2630490ybo.12.1684355498779; Wed, 17 May 2023 13:31:38 -0700 (PDT) Date: Wed, 17 May 2023 20:31:19 +0000 In-Reply-To: <20230517203119.3160435-1-aliceryhl@google.com> Mime-Version: 1.0 References: <20230517203119.3160435-1-aliceryhl@google.com> X-Mailer: git-send-email 2.40.1.606.ga4b1b128d6-goog Message-ID: <20230517203119.3160435-8-aliceryhl@google.com> Subject: [PATCH v1 7/7] rust: workqueue: add `try_spawn` helper method From: Alice Ryhl To: rust-for-linux@vger.kernel.org Cc: Miguel Ojeda , Wedson Almeida Filho , Tejun Heo , Lai Jiangshan , Alex Gaynor , Boqun Feng , Gary Guo , " =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= " , Benno Lossin , Alice Ryhl , linux-kernel@vger.kernel.org, patches@lists.linux.dev X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_PDS_OTHER_BAD_TLD,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766174922103618054?= X-GMAIL-MSGID: =?utf-8?q?1766174922103618054?= This adds a convenience method that lets you spawn a closure for execution on a workqueue. This will be the most convenient way to use workqueues, but it is fallible because it needs to allocate memory. Signed-off-by: Alice Ryhl Reviewed-by: Martin Rodriguez Reboredo --- rust/kernel/workqueue.rs | 40 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+) diff --git a/rust/kernel/workqueue.rs b/rust/kernel/workqueue.rs index 007005ddcaf0..303b72efd95f 100644 --- a/rust/kernel/workqueue.rs +++ b/rust/kernel/workqueue.rs @@ -57,6 +57,42 @@ impl Queue { }) } } + + /// Tries to spawn the given function or closure as a work item. + /// + /// This method can fail because it allocates memory to store the work item. + pub fn try_spawn(&self, func: T) -> Result { + let init = pin_init!(ClosureWork { + work <- Work::new(), + func: Some(func), + }); + + self.enqueue(Box::pin_init(init)?); + Ok(()) + } +} + +/// A helper type used in `try_spawn`. +#[pin_data] +struct ClosureWork { + #[pin] + work: Work>>>, + func: Option, +} + +impl ClosureWork { + fn project(self: Pin<&mut Self>) -> &mut Option { + // SAFETY: The `func` field is not structurally pinned. + unsafe { &mut self.get_unchecked_mut().func } + } +} + +impl BoxWorkItem for ClosureWork { + fn run(mut self: Pin>) { + if let Some(func) = self.as_mut().project().take() { + (func)() + } + } } /// A work item. @@ -280,6 +316,10 @@ macro_rules! impl_has_work { )*}; } +impl_has_work! { + impl HasWork>> for ClosureWork { self.work } +} + /// Declares that [`Arc`] should implement [`WorkItem`]. /// /// # Examples