From patchwork Wed May 17 16:37:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 95421 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1273564vqo; Wed, 17 May 2023 09:42:07 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5Pc7z5bxaka0okXYquPYijoANLAaRIE7TkuyyjvP+H7m7PnL7emwTLdZ3We49XgAM4FAT2 X-Received: by 2002:a05:6a00:808b:b0:64a:e8a2:bb26 with SMTP id eh11-20020a056a00808b00b0064ae8a2bb26mr288809pfb.0.1684341726866; Wed, 17 May 2023 09:42:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684341726; cv=none; d=google.com; s=arc-20160816; b=Z3d2xHEvUrKlnRxKCzuSMcBXaHyIeaRJ2aN4nwmTnEvNjHfTcueN56LV0eUDq98YyS cVu9St1NdVUZxZfgK8Qd3YIw/ZgWdJPQ4SDHqZcMU8ua/r3JRav1vrlt/ktikDZf1Uut bRFkokHMwNOZzsHfIW5+vcNtZ1bcm2FdqhlmTe5Ic1LTBqBOyaWzlwCO71If2eYqu95M Py+9q9OitfVYNTuDfRMOkBspdrxI6C/Z43FGr/EP3q0WxeAJL3nZbnz5l8fUu5rMkr91 uvcz2+Tl6qGwTpFHYgqUN7ISYDW+ItGO0fHda6jjoH44z5+F87L0UJi5vAIhs5IpSfbS FdJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=oxFHTRCKX1b6ZPvp5Tbzp6uL023q77o/sho/DiHZlF0=; b=YwDOngQ3mpjc0bj8nNcB+l3Zg/OtVG/g4tP1vybbKt/xy8qt7gqRt6yUQ/Xss5cWwH OPEqI76dzB08uagwvxACtpQma7/F4coN0+bKmjYs0Gfvmrv5pmc5yR6rtVQbYcGIBEP4 N91P2a77Y9sp7ErKdEVuXnaP3sWxqF6ICwzkOXBDJMYlWnjgfGSYmZq7HGwPI7taaUxa +X9thJejKYQzP/yKBEJINXSsEiQNanBEnVMPFBN6uGcbqiJtTmxdy8XMU1K7n57+i0Gm w2Xq/iz+aLt/JeZPR3tnHD+6Bus/2pLu4dBNqsa4z62w3GlEG5KXfA5cps3NJ5IiTlvV 4Osg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZlTl28Xa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a15-20020aa78e8f000000b00643aa8d2548si22155134pfr.120.2023.05.17.09.41.54; Wed, 17 May 2023 09:42:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZlTl28Xa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229816AbjEQQiH (ORCPT + 99 others); Wed, 17 May 2023 12:38:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229794AbjEQQiD (ORCPT ); Wed, 17 May 2023 12:38:03 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5BCFE93C3 for ; Wed, 17 May 2023 09:37:55 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-510db954476so585900a12.0 for ; Wed, 17 May 2023 09:37:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684341474; x=1686933474; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oxFHTRCKX1b6ZPvp5Tbzp6uL023q77o/sho/DiHZlF0=; b=ZlTl28XaVoUXtK1R34OnJkyaUON8lN7ZqEl9xlLeb2F1+VNKzXQlqUBUy3hYRe4+Xi ybUetVhyCtCPth5UUo3OCKa6R+YiCxy1IwqvcrwWikT73tdqJ49b672dd7+Z8F4UM9g7 +794RuU2affLlGgyft4JZzow4imJSjLkSG2szqvX5pIw69/0w6ygLxEhAr+YTxUBwRe2 Ug9i/gcRmusm2cYeUth3Vp9EBacAnars4fWV+8HIUk2j2Vh8nuWVObwz34XOlD7n2pLa +M+i4hpBfOIvxZ/z9Ty72PK3C0UgnGdUASeQYcjc7NBSmxP9IyfyF6qNMiD+noYB8xQc ufYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684341474; x=1686933474; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oxFHTRCKX1b6ZPvp5Tbzp6uL023q77o/sho/DiHZlF0=; b=NFq6WobxMRV3Qegf0cM/uNknh+sgfIAepYCMMZbtfdvtgdpL55O+vsbKRt09GaQRG8 NG5htwrIsFR3ezsz7z18BWmbCJpU8qPNr7RkPkfxkuNWphSCKyH6EhqnMU3csQs5ck8v xO+x10ih9gngUz4nyiqkDL7+J4PoUo6DQ0nv7Wqtq1V1Zu9v1IWG4qwg37jwQmt7XNvG XLMpKRWsWPI2uOPyEVeCoXyaYi6UQSWac8DwDYaaXUgJWsGo+V7FI3kaCwBSw0NtBEAs woeIMz7zQ1uO+rhxtgG6NDsgPuzlrX5J0ggr7KvE2vcv7gzN+NuuCiRyFsw1AWyPD1ze xFvQ== X-Gm-Message-State: AC+VfDwNcuXOooZlTyv5Fz9xd6JW4TN6yFPjNxgEz4igkDagZfxWhGeE HNneeZS5TV92UjNDMlreFrEajA== X-Received: by 2002:a05:6402:1209:b0:50b:d26d:c57e with SMTP id c9-20020a056402120900b0050bd26dc57emr2431904edw.12.1684341473752; Wed, 17 May 2023 09:37:53 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:c9ff:4c84:dd21:568d]) by smtp.gmail.com with ESMTPSA id t21-20020aa7d715000000b0050bc041d2a8sm9284827edq.15.2023.05.17.09.37.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 09:37:53 -0700 (PDT) From: Krzysztof Kozlowski To: Vinod Koul , Bard Liao , Pierre-Louis Bossart , Sanyog Kale , Andy Gross , Bjorn Andersson , Konrad Dybcio , =?utf-8?q?P=C3=A9ter_Ujfalusi?= , Srinivas Kandagatla , Charles Keepax , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 2/2] soundwire: debugfs: fix unbalanced pm_runtime_put() Date: Wed, 17 May 2023 18:37:50 +0200 Message-Id: <20230517163750.997629-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230517163750.997629-1-krzysztof.kozlowski@linaro.org> References: <20230517163750.997629-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766160310536393608?= X-GMAIL-MSGID: =?utf-8?q?1766160310536393608?= If pm_runtime_resume_and_get() failed with -EACCES, the driver continued execution and finally called pm_runtime_put_autosuspend(). Since pm_runtime_resume_and_get() drops the usage counter on every error, this lead to double decrement of that counter. Fixes: b275bf45ba1d ("soundwire: debugfs: Switch to sdw_read_no_pm") Signed-off-by: Krzysztof Kozlowski Reviewed-by: Pierre-Louis Bossart --- drivers/soundwire/debugfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/soundwire/debugfs.c b/drivers/soundwire/debugfs.c index dea782e0edc4..c3a1a359ee5c 100644 --- a/drivers/soundwire/debugfs.c +++ b/drivers/soundwire/debugfs.c @@ -56,8 +56,9 @@ static int sdw_slave_reg_show(struct seq_file *s_file, void *data) if (!buf) return -ENOMEM; - ret = pm_runtime_resume_and_get(&slave->dev); + ret = pm_runtime_get_sync(&slave->dev); if (ret < 0 && ret != -EACCES) { + pm_runtime_put_noidle(&slave->dev); kfree(buf); return ret; }