From patchwork Wed May 17 15:56:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "D. Starke" X-Patchwork-Id: 95395 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1246223vqo; Wed, 17 May 2023 09:03:29 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4LOPySf3razhXl83MxYBcDS2JEnGatuQk2qMij558BC5gpgfHpkZz/XVhNrOHMCBjzXDIs X-Received: by 2002:a17:90b:4c89:b0:250:43a6:fb02 with SMTP id my9-20020a17090b4c8900b0025043a6fb02mr121881pjb.20.1684339409644; Wed, 17 May 2023 09:03:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684339409; cv=none; d=google.com; s=arc-20160816; b=Tkhx72KR1wTxp3bjtiOCWt54KksVs3KpEtyryPsmwVggMmQFGoWyjYhK+QmutXf4bT 1shhqmlzSkfUQ3Qx22xp3Qdn7t67v9Zc3USdvGFANXJrL4TjSEbtm2wzUdYQ9l3GlXf5 ak6YEhErOgG1dtoFXB0sdKdVq+X5HCSbZvMid2B2Uds5nE/wRps4JyW3PXHETe36IdRv eMo0K0O4ZKRVZJ3H8AIofUMmPixfXpMvhoMQBbZqGkKfTTBM71xlnDeSPdznybUR8/d1 xp7utDfME/7iX0Z9L7fKkW1KTvrg/3zJk7InGrMB3gbvML7uAGic9ZVfH5qfFk6d+Ht8 HE7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:feedback-id:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=E9IwZtdfkhkPpswS1gYiZOwz+Ap7dZzs6d4A7WBwoPE=; b=pEXOxqvSypPQpN2cKhkQqjD/gmAYMLCeUsYhl13FbVIKXO1wVPgza4tJ4vBnZCvAIC Wj9l/54Tn5iqDUSKiQMm0uUG+ej7OmqQZPZ7+g9teuYKN3MsQjXMAzE8DdWY1WMn7AK+ oZYUUwtd1agYP6AAVf2lOGt7N6Ko4ae0N4vf6j7mUPTwOGELjbcUr13v/qv5ZKW6AK50 n+Ixen+UeRk8YoGjOA8i/vvHiLLyq014k2NMQIegiwWWsnZQ/t9tnLlwUNRVt0jQsj87 NQ1SwsuAr4SWvuqeal3+uwgfTMq1JR69fPfFAk8LY4jqtQUYRTViqhIN6JKkhBvR8Gb4 /2Vg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=ioRufgCk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s15-20020a17090aad8f00b002532933832csi2005695pjq.78.2023.05.17.09.03.08; Wed, 17 May 2023 09:03:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=ioRufgCk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231774AbjEQP64 (ORCPT + 99 others); Wed, 17 May 2023 11:58:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231749AbjEQP6i (ORCPT ); Wed, 17 May 2023 11:58:38 -0400 Received: from mta-64-228.siemens.flowmailer.net (mta-64-228.siemens.flowmailer.net [185.136.64.228]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0AA4A72B4 for ; Wed, 17 May 2023 08:58:31 -0700 (PDT) Received: by mta-64-228.siemens.flowmailer.net with ESMTPSA id 20230517155829611cda8f53bbc3aa43 for ; Wed, 17 May 2023 17:58:29 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=fm1; d=siemens.com; i=daniel.starke@siemens.com; h=Date:From:Subject:To:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Cc:References:In-Reply-To; bh=E9IwZtdfkhkPpswS1gYiZOwz+Ap7dZzs6d4A7WBwoPE=; b=ioRufgCk8NB5DNeaUoJVm9cmWHMmWgBGFMClospy6Ao5HltN4+fhPsfdnk4znAq71vXbac tgRBS3uEJXEPJHwq1kSKiEsSR4ARUTcXTw00Vqz7NEKYYXdkewOrGg9tEZMXsK+mLwjlZzCY inSnh6ULQ45hbJaaWRWJY9ewOoBpc=; From: "D. Starke" To: linux-serial@vger.kernel.org, gregkh@linuxfoundation.org, jirislaby@kernel.org, ilpo.jarvinen@linux.intel.com, felix-haase@siemens.com Cc: linux-kernel@vger.kernel.org, Daniel Starke Subject: [PATCH v5 05/10] tty: n_gsm: increase malformed counter for malformed control frames Date: Wed, 17 May 2023 17:56:59 +0200 Message-Id: <20230517155704.5701-5-daniel.starke@siemens.com> In-Reply-To: <20230517155704.5701-1-daniel.starke@siemens.com> References: <20230517155704.5701-1-daniel.starke@siemens.com> MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-314044:519-21489:flowmailer X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766157880673019153?= X-GMAIL-MSGID: =?utf-8?q?1766157880673019153?= From: Daniel Starke The malformed counter in gsm_mux is already increased in case of errors detected in gsm_queue() and gsm1_receive(). gsm_dlci_command() also detects a case for a malformed frame but does not increase the malformed counter yet. Fix this by also increasing the gsm_mux malformed counter in case of a malformed frame in gsm_dlci_command(). Note that the malformed counter is not yet exposed and only set internally. Signed-off-by: Daniel Starke --- drivers/tty/n_gsm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) v4 -> v5: No changes. Please note that I cannot response to emails until August 7th. Felix Haase will take over from our side for questions regarding this patch series or the n_gsm. Link: https://lore.kernel.org/all/20230426080315.7595-5-daniel.starke@siemens.com/ diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c index 186f463f0f11..5b6a03668c78 100644 --- a/drivers/tty/n_gsm.c +++ b/drivers/tty/n_gsm.c @@ -2455,8 +2455,10 @@ static void gsm_dlci_command(struct gsm_dlci *dlci, const u8 *data, int len) data += dlen; /* Malformed command? */ - if (clen > len) + if (clen > len) { + dlci->gsm->malformed++; return; + } if (command & 1) gsm_control_message(dlci->gsm, command, data, clen);