From patchwork Wed May 17 15:26:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Desnoyers X-Patchwork-Id: 95359 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:6358:3046:b0:115:7a1d:dabb with SMTP id p6csp1104118rwl; Wed, 17 May 2023 08:32:02 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4YAVrGShA94q2+0Lz8dC0CASVh7o7w7lhibo/XIW1lrnSoyFpQUwpsPUdXa5fdYdLBemJQ X-Received: by 2002:a17:903:2448:b0:1ab:1a6:34bc with SMTP id l8-20020a170903244800b001ab01a634bcmr52046472pls.9.1684337522559; Wed, 17 May 2023 08:32:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684337522; cv=none; d=google.com; s=arc-20160816; b=fVMnMxOR6E/MctdIB8mNejtOpum/1FnVkXMQgmOp2CgTDNtGTy1rd5ZCPo87se2aod y37+o4QR876U0TJW3KI0mnaJpTw/1jLF6ZGPuv0YUYepKHLoaM+a+K+bL5i6s5N5S5nn k5Z98WcBflukHMaqrBe2yp4ylPdR+8CBLSaWTawosPYC5H/fj9vAxvIHAToWcMGpzTzo t7AK1Cd96w6FDD4rZLU++nUCgKK3hOOCciumH3xWKAQ81RjjJibQTfwjF7qsV9+LCwXA v4xvoPfgd/JX4re/0IQNd+2efJS7rGhhVVOFodAAb6qudGshsACx34DI9HL2HO93R7HX nGWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Qq1wVDIs+dVwNXnwpFr/UOrPE+dVUEsiQ9P+MK/TCNQ=; b=tuwfhxkjKYd4+fI5I+BVZ5KURRMp8isGoJru5j1rv3sZLinLGNmM2T1lzi2kfzy11g SvA9hRhGcf30vsRjTfDtJ9NPZ+EM15k+9I7xILCE6lI1FDLwDoNfEQl8HdDazgCGkZcp Jilp9nETQvzBv6vtp1Va8gTj8WpVAfkZpya0OnUvEaVN9+g6id1rGJpQNFMt/SFLKJx6 Qd4p5iUCQXx/iZ69xWpUNrBjzvWxh4siMAtg1ybqiSfj6Ezi3LiuaRxYHi5Ya/aA9OHc SAb8X9/wp2f1jlCi+aYXjH7h98nvm6eqIEuVhJcrj/o+Y0OSjoJWrjxIjoyBWwhoEHZD EXcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@efficios.com header.s=smtpout1 header.b="Pf/uwYxx"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=efficios.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e9-20020a17090301c900b001a6d4eab490si22748497plh.63.2023.05.17.08.31.48; Wed, 17 May 2023 08:32:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@efficios.com header.s=smtpout1 header.b="Pf/uwYxx"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=efficios.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232430AbjEQP2D (ORCPT + 99 others); Wed, 17 May 2023 11:28:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232357AbjEQP1V (ORCPT ); Wed, 17 May 2023 11:27:21 -0400 Received: from smtpout.efficios.com (unknown [IPv6:2607:5300:203:b2ee::31e5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63E669ECC; Wed, 17 May 2023 08:27:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1684337225; bh=oUBWD3uXfnEFaLFPKw63JibCtJN1wNcWvTTMTt7WX2U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Pf/uwYxxbU/O++e8hVjspgx9b82crpxKgs6qVzKTYkrKAz+57jx+u5zvEZCnclksb 5x0sd3aETZoQFT6ZAHAhXzEagqOkpzW3Tl9WOA1VlptN2JOdiRS9Jqv9EvSlvc25hM y1TxBLPyYXGnAkMv9BPQVoDojU9oK83/x8NL+zzZQ1kfh6j8Le+h01F/4T3VrDkWkY UJXHx43mewfzDxxOTBQqMc1CuXoPbXiE2N7oCPQrOmz8clHWjaZpE6SHpqL1roOGQD RU2JyfoAYjoOFovgNap6MI/rdZL+DSo5q5Ic/ncCjQyfLM4XaKanXKYxN/zGXodtI2 QCwlzi20GPCWg== Received: from localhost.localdomain (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4QLxmT1RBCz12rG; Wed, 17 May 2023 11:27:05 -0400 (EDT) From: Mathieu Desnoyers To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, Thomas Gleixner , "Paul E . McKenney" , Boqun Feng , "H . Peter Anvin" , Paul Turner , linux-api@vger.kernel.org, Christian Brauner , Florian Weimer , David.Laight@ACULAB.COM, carlos@redhat.com, Peter Oskolkov , Alexander Mikhalitsyn , Chris Kennelly , Ingo Molnar , Darren Hart , Davidlohr Bueso , =?utf-8?q?Andr=C3=A9_Almeida?= , libc-alpha@sourceware.org, Steven Rostedt , Jonathan Corbet , Mathieu Desnoyers Subject: [RFC PATCH 4/4] selftests/rseq: Implement rseq_mutex test program Date: Wed, 17 May 2023 11:26:54 -0400 Message-Id: <20230517152654.7193-5-mathieu.desnoyers@efficios.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230517152654.7193-1-mathieu.desnoyers@efficios.com> References: <20230517152654.7193-1-mathieu.desnoyers@efficios.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RDNS_NONE,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766155902176174440?= X-GMAIL-MSGID: =?utf-8?q?1766155902176174440?= Example use of the rseq sched state. Signed-off-by: Mathieu Desnoyers --- tools/testing/selftests/rseq/.gitignore | 1 + tools/testing/selftests/rseq/Makefile | 3 +- tools/testing/selftests/rseq/rseq_mutex.c | 120 ++++++++++++++++++++++ 3 files changed, 123 insertions(+), 1 deletion(-) create mode 100644 tools/testing/selftests/rseq/rseq_mutex.c diff --git a/tools/testing/selftests/rseq/.gitignore b/tools/testing/selftests/rseq/.gitignore index a8db9f7a7cec..38d5b2fe5905 100644 --- a/tools/testing/selftests/rseq/.gitignore +++ b/tools/testing/selftests/rseq/.gitignore @@ -10,3 +10,4 @@ param_test_mm_cid param_test_mm_cid_benchmark param_test_mm_cid_compare_twice sched_state_test +rseq_mutex diff --git a/tools/testing/selftests/rseq/Makefile b/tools/testing/selftests/rseq/Makefile index 7c8f4f2be74c..a9d7ceb5b79b 100644 --- a/tools/testing/selftests/rseq/Makefile +++ b/tools/testing/selftests/rseq/Makefile @@ -14,7 +14,8 @@ OVERRIDE_TARGETS = 1 TEST_GEN_PROGS = basic_test basic_percpu_ops_test basic_percpu_ops_mm_cid_test param_test \ param_test_benchmark param_test_compare_twice param_test_mm_cid \ - param_test_mm_cid_benchmark param_test_mm_cid_compare_twice sched_state_test + param_test_mm_cid_benchmark param_test_mm_cid_compare_twice sched_state_test \ + rseq_mutex TEST_GEN_PROGS_EXTENDED = librseq.so diff --git a/tools/testing/selftests/rseq/rseq_mutex.c b/tools/testing/selftests/rseq/rseq_mutex.c new file mode 100644 index 000000000000..7e580fc6eebf --- /dev/null +++ b/tools/testing/selftests/rseq/rseq_mutex.c @@ -0,0 +1,120 @@ +// SPDX-License-Identifier: LGPL-2.1 + +#define _GNU_SOURCE +#include +#include +#include +#include +#include +#include +#include + +#include "rseq.h" + +#define RSEQ_MUTEX_MAX_BUSY_LOOP 100 + +struct rseq_mutex { + /* + * NULL: unlocked. When non-NULL, owner points to per-thread rseq_abi + * of owner thread. + */ + struct rseq_abi *owner; +}; + +static struct rseq_mutex lock = { .owner = NULL }; + +static int testvar; + +static void rseq_lock_slowpath(struct rseq_mutex *lock) +{ + int i = 0; + + for (;;) { + struct rseq_abi *expected = NULL, *self = rseq_get_abi(); + + if (__atomic_compare_exchange_n(&lock->owner, &expected, self, false, + __ATOMIC_ACQUIRE, __ATOMIC_RELAXED)) + break; + //TODO: use rseq critical section to protect dereference of owner thread's + //rseq_abi, combined with rseq fence at thread reclaim. + if ((RSEQ_ACCESS_ONCE(expected->sched_state) & RSEQ_SCHED_STATE_ON_CPU) && + i < RSEQ_MUTEX_MAX_BUSY_LOOP) { + rseq_barrier(); /* busy-wait, e.g. cpu_relax(). */ + i++; + } else { + //TODO: Enqueue waiter in a wait-queue, and integrate + //with sys_futex rather than waiting for 10ms. + (void) poll(NULL, 0, 10); /* wait 10ms */ + } + } +} + +static void rseq_lock(struct rseq_mutex *lock) +{ + struct rseq_abi *expected = NULL, *self = rseq_get_abi(); + + if (rseq_likely(__atomic_compare_exchange_n(&lock->owner, &expected, self, false, + __ATOMIC_ACQUIRE, __ATOMIC_RELAXED))) + return; + rseq_lock_slowpath(lock); +} + +static void rseq_unlock(struct rseq_mutex *lock) +{ + __atomic_store_n(&lock->owner, NULL, __ATOMIC_RELEASE); + //TODO: integrate with sys_futex and wakeup oldest waiter. +} + +static +void *test_thread(void *arg) +{ + int i; + + if (rseq_register_current_thread()) { + fprintf(stderr, "Error: rseq_register_current_thread(...) failed(%d): %s\n", + errno, strerror(errno)); + abort(); + } + + for (i = 0; i < 1000; i++) { + int var; + + rseq_lock(&lock); + var = RSEQ_READ_ONCE(testvar); + if (var) { + fprintf(stderr, "Unexpected value %d\n", var); + abort(); + } + RSEQ_WRITE_ONCE(testvar, 1); + if (!(i % 10)) + (void) poll(NULL, 0, 10); + else + rseq_barrier(); + RSEQ_WRITE_ONCE(testvar, 0); + rseq_unlock(&lock); + } + + if (rseq_unregister_current_thread()) { + fprintf(stderr, "Error: rseq_unregister_current_thread(...) failed(%d): %s\n", + errno, strerror(errno)); + abort(); + } + return NULL; +} + +int main(int argc, char **argv) +{ + int nr_threads = 5; + pthread_t test_thread_id[nr_threads]; + int i; + + for (i = 0; i < nr_threads; i++) { + pthread_create(&test_thread_id[i], NULL, test_thread, NULL); + } + + for (i = 0; i < nr_threads; i++) { + pthread_join(test_thread_id[i], NULL); + } + + return 0; +}