From patchwork Wed May 17 13:41:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 95272 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1159715vqo; Wed, 17 May 2023 07:03:22 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5u+mSZcmYVX1zLgQHWcwjJ6KpZFfXiKGz4MeSRkzlgwAzYrD/02pByHChs30o+t4do8iRM X-Received: by 2002:a05:6a00:a24:b0:643:b8c2:b577 with SMTP id p36-20020a056a000a2400b00643b8c2b577mr1150008pfh.22.1684332201890; Wed, 17 May 2023 07:03:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684332201; cv=none; d=google.com; s=arc-20160816; b=SRrRt3cjkN5m6eTT2Jka2TNXnp/EnkyYvXzqktczz9vJE45tvYP9xXl4EiZ98gU07q efK5cQizSgcQIORZ6G3Mlc2Eb7vGxhJlBBzDjpu7JLANlzdE8CZzxqPfVe/N+UZGdsmP ECVFH9CfMWCCKQnbmsCrJoC6VR+NEHZoIn3zjCqYdWHVoAZHivOgHgeXnBqEqT4x2DVu DBLQlNMgfoqYUJ5yfhEtMWPMwIPlVIPA4wii3AzmYdcF6cRIY1K/BiIiB7H8kG1c2+GU HXpjXqS8Gi2kiDrH16hNiG3Yvi4QpDz/Qt7bb2E1mpCLL2YzhZCVaOXSne1yHp1cFd+F NJ5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=wHcGhYBK2iclIlw+sklydiMn/Pjzv3gm7joUyvqgdBY=; b=ToEHMXg4tvblIp9Gz8EEL6JgqsqR6ypUWM9hywxu0iQfKVAOBHqusxRr9CRY3JGP+S 95W92HJEspgOQiVZwwYjsTK5EfZeQ320eVgcLGUENmrnIWfPBM0gzFchDpSImQuLa6II JfmIEM5g5dyakVzox/E8so3xQI2tR5ykGeE/Cag8ckGdhjgw2eglcfByzwP62tJfYdgU VFGrtmEEkepFdpTW78MdI8XGGW6GAPHDby1AXf+e6ZdQWxPHIXcFa6Mb6d2bZyQGxMa/ xXUPVzMBSzAuiy5tXMJt7gmBwZaZ2f93tp0+dhGwJY6P89MbJ0nUNNeoQTDIdt+LsDDn SNUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UR9Yg27q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t2-20020a63a602000000b0052feffab90esi11070892pge.93.2023.05.17.07.02.47; Wed, 17 May 2023 07:03:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UR9Yg27q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229707AbjEQNmj (ORCPT + 99 others); Wed, 17 May 2023 09:42:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230527AbjEQNmh (ORCPT ); Wed, 17 May 2023 09:42:37 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08ABD269A for ; Wed, 17 May 2023 06:41:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684330910; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=wHcGhYBK2iclIlw+sklydiMn/Pjzv3gm7joUyvqgdBY=; b=UR9Yg27qPzfpwLo2x+ZmLXS/S6r2BAFdAUuF2NJvAqUe7IdrBmBBHmwlxaAI9E6+SpiGKw NzQU098BOADGJUDh4m3JE9kxalWsj/forVZ8PSyoSCTCgP1Z5kmvSPPMt5edu35b2n2FLL NHkqXTKx0BALNXCHAzx7AtM0K9w+Oek= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-354-GrCMVhKmPuyzXYeXlnjAZA-1; Wed, 17 May 2023 09:41:49 -0400 X-MC-Unique: GrCMVhKmPuyzXYeXlnjAZA-1 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-75784a27e8fso100964785a.0 for ; Wed, 17 May 2023 06:41:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684330907; x=1686922907; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wHcGhYBK2iclIlw+sklydiMn/Pjzv3gm7joUyvqgdBY=; b=SCq3UA14+uJppu/3mceaSXYT494cMjEaBofG2WrXL83S/xeRl29GqWD2D/wG+EeSeQ Mp5YuM2rBGhJ9yLT49jK5UlZRjMfzPonifH1/Ahbm/985t8YamNf8mUtI0he0ElVhLi0 KQSw1dTNa3B4rpuw8IIDI1f9FH7SkQZfq074X4ykIOS54Y94STMZGXCsuvs92kA+W3qk FPPjcTPznjBdrZLtNtrdJAabTgRoGB22btDwcz8gjm6Acdy+EhpyUFrI23ve/wn7ptda 1QD2EVUKYcq7lwxMddH1kdUhB6ocmkUZ3Wqny8BqxH1fpK214/P5edOjKjxXRQobFrP9 ay+g== X-Gm-Message-State: AC+VfDxmcx/TntTkn6ZIDUzsCEMsnxPYq1kaEUrHxEFuAITLlqny/VZN yqlOBgpJMxGcn22OyPgQxn8rjcqGXhMRGSszIw0cKGNo2Q0ZUDRmRh9xCCWknIgLP7e5sPqvjpW NZuluV4fXzYSxgHfR/onuoWfT X-Received: by 2002:a05:622a:202:b0:3f3:89cb:55dd with SMTP id b2-20020a05622a020200b003f389cb55ddmr59160089qtx.10.1684330906972; Wed, 17 May 2023 06:41:46 -0700 (PDT) X-Received: by 2002:a05:622a:202:b0:3f3:89cb:55dd with SMTP id b2-20020a05622a020200b003f389cb55ddmr59160055qtx.10.1684330906619; Wed, 17 May 2023 06:41:46 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id a13-20020a05620a16cd00b007591cc41ed6sm627842qkn.25.2023.05.17.06.41.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 06:41:46 -0700 (PDT) From: Tom Rix To: airlied@redhat.com, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Tom Rix Subject: [PATCH] drm/mgag200: set variable mgag200_modeset storage-class-specifier to static Date: Wed, 17 May 2023 09:41:40 -0400 Message-Id: <20230517134140.874179-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766150323003735044?= X-GMAIL-MSGID: =?utf-8?q?1766150323003735044?= smatch reports drivers/gpu/drm/mgag200/mgag200_drv.c:23:5: warning: symbol 'mgag200_modeset' was not declared. Should it be static? This variable is only used in its defining file, so it should be static Signed-off-by: Tom Rix Reviewed-by: Jocelyn Falempe Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c b/drivers/gpu/drm/mgag200/mgag200_drv.c index 976f0ab2006b..abddf37f0ea1 100644 --- a/drivers/gpu/drm/mgag200/mgag200_drv.c +++ b/drivers/gpu/drm/mgag200/mgag200_drv.c @@ -20,7 +20,7 @@ #include "mgag200_drv.h" -int mgag200_modeset = -1; +static int mgag200_modeset = -1; MODULE_PARM_DESC(modeset, "Disable/Enable modesetting"); module_param_named(modeset, mgag200_modeset, int, 0400);