diff mbox series

drm/drm_atomic.h: fixup typos

Message ID 20230517082322.3230271-1-suijingfeng@loongson.cn
State New
Headers
Series drm/drm_atomic.h: fixup typos |

Commit Message

Sui Jingfeng May 17, 2023, 8:23 a.m. UTC 
  Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
---
 include/drm/drm_atomic.h | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Javier Martinez Canillas May 17, 2023, 8:38 a.m. UTC | #1 
Hello Sui,

I would still add something to the commit description even when your
changes are trivial.

Sui Jingfeng <suijingfeng@loongson.cn> writes:

> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
> ---

The fixes look good to me though

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Sui Jingfeng May 17, 2023, 8:48 a.m. UTC | #2 
Hi, thanks a lot


On 2023/5/17 16:38, Javier Martinez Canillas wrote:
> Hello Sui,
>
> I would still add something to the commit description even when your
> changes are trivial.
Ok, I remember this, I will respin patch with this instruction in mind 
in the future.
>
> Sui Jingfeng <suijingfeng@loongson.cn> writes:
>
>> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
>> ---
> The fixes look good to me though
>
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
>
Sui Jingfeng May 17, 2023, 8:53 a.m. UTC | #3 
On 2023/5/17 16:38, Javier Martinez Canillas wrote:
> Hello Sui,
>
> I would still add something to the commit description even when your
> changes are trivial.


OK, that sounds fine. I'm agree.


> Sui Jingfeng <suijingfeng@loongson.cn> writes:
>
>> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
>> ---
> The fixes look good to me though
>
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
>
diff mbox series

Patch

diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h
index c023c682301b..0b5271cfb029 100644
--- a/include/drm/drm_atomic.h
+++ b/include/drm/drm_atomic.h
@@ -394,8 +394,7 @@  struct drm_atomic_state {
 	 *
 	 * Indicates whether or not this atomic state was duplicated using
 	 * drm_atomic_helper_duplicate_state(). Drivers and atomic helpers
-	 * should use this to fixup normal  inconsistencies in duplicated
-	 * states.
+	 * should use this to fixup inconsistencies in duplicated states.
 	 */
 	bool duplicated : 1;
 	struct __drm_planes_state *planes;
@@ -412,7 +411,7 @@  struct drm_atomic_state {
 	 *
 	 * Used for signaling unbound planes/connectors.
 	 * When a connector or plane is not bound to any CRTC, it's still important
-	 * to preserve linearity to prevent the atomic states from being freed to early.
+	 * to preserve linearity to prevent the atomic states from being freed too early.
 	 *
 	 * This commit (if set) is not bound to any CRTC, but will be completed when
 	 * drm_atomic_helper_commit_hw_done() is called.