Message ID | 20230517054756.11119-1-zev@bewilderbeest.net |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp909169vqo; Tue, 16 May 2023 23:10:29 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5KLwxGG+YvLs+QR5qrZQj4GRncv0Pe2jRSeK3clkGj0iDtEwxzEhX69/hkhTqzNMJuVIZp X-Received: by 2002:a17:90b:3755:b0:250:a909:d96c with SMTP id ne21-20020a17090b375500b00250a909d96cmr28545279pjb.9.1684303829098; Tue, 16 May 2023 23:10:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684303829; cv=none; d=google.com; s=arc-20160816; b=qeZK2b1MH0knWhTtOV4/adwe3e7DJ6WYGke1BcGF7KHrQcYaflOflIzx3ycFhmY877 oUIQW7Vsog1pNUHbhiToQE8sWtTx9zyBgZB71cCxfqxu2w2a/gjaZy6Jbm0aqYXh8xWB tWbAGFxmqbxt9eHYVanhFpF9rUob2E/lpK4TUhGihMe9hl2OBzrnz22xzhBI9v5p4C/R /GD9qRAwlcyPkenZo+edydlIzzA4z2od3y6H+GANVdnso1eYEBFG/J9mCCrs9ogDMp4G HNdG+iHmXahyIXall5eBfv+kuyNr/dlXrFn1HVmGy7XlZIpqfhXiCewXEkeKlQNWE/fB yahQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=+tnO7BfGQlwxHNrnSuMx4B9JwM2zlElAG5v5xkIN+3I=; b=GHiPXi8rruY0d8AeRRxA5QVYDKqO6hiQozuOaMrRXIPV8lmleIk75aJymgkLhNuYJ+ l6kRvTXdDvrnjnyXpZvFyph/w1epORpY5vBNVInduVNQiRmdDaLd5mfq2KbstL0B5Xy/ H+IXOUBlfchkGMLdOdCe1ztF07quBaO1ogt/jfvMyoQSpU42wMnKQQrpaG6IA+78sgP6 2D/ooSPXRZHKD9RVyBAuQuWTzWFLYwI713XLqEa1Awm6+PmneF3sUZbtptvRZ4Vd3X4I EQtVHRHf5zVtmEC4XIWo3T+Ao3VIsBmciNw8dZ56sGVuy0EaJUniTZzPV7t3s3sWjBgA I+yA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bewilderbeest.net header.s=thorn header.b=ktyoLfJK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=bewilderbeest.net Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lw14-20020a17090b180e00b0022915b6dd7asi1096549pjb.145.2023.05.16.23.10.14; Tue, 16 May 2023 23:10:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bewilderbeest.net header.s=thorn header.b=ktyoLfJK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=bewilderbeest.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232562AbjEQF6f (ORCPT <rfc822;pacteraone@gmail.com> + 99 others); Wed, 17 May 2023 01:58:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232558AbjEQF6c (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 17 May 2023 01:58:32 -0400 X-Greylist: delayed 453 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 16 May 2023 22:58:31 PDT Received: from thorn.bewilderbeest.net (thorn.bewilderbeest.net [IPv6:2605:2700:0:5::4713:9cab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22C202729; Tue, 16 May 2023 22:58:30 -0700 (PDT) Received: from hatter.bewilderbeest.net (174-21-172-149.tukw.qwest.net [174.21.172.149]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: zev) by thorn.bewilderbeest.net (Postfix) with ESMTPSA id 99B0F6DF; Tue, 16 May 2023 22:50:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bewilderbeest.net; s=thorn; t=1684302655; bh=+tnO7BfGQlwxHNrnSuMx4B9JwM2zlElAG5v5xkIN+3I=; h=From:To:Cc:Subject:Date:From; b=ktyoLfJKpbYfN2B3AvyqFhl3/c3kf+aDNoHoiEsmcuj0tBaaXlib2p5HoV+9fkqYD iw7Gb4JZGpRBRxGEYo3b1c4DgbU8LrGBFrkN3YNKtENofZ4nNvh5bvopi1Lr7SXxHl H5pAI55ICD7/aEugtJ1io23O3N1OhWogfRw4lQOU= From: Zev Weiss <zev@bewilderbeest.net> To: Bamvor Jian Zhang <bamv2005@gmail.com>, Linus Walleij <linus.walleij@linaro.org>, Bartosz Golaszewski <brgl@bgdev.pl> Cc: Zev Weiss <zev@bewilderbeest.net>, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, stable@kernel.org Subject: [PATCH] gpio: mockup: Fix mode of debugfs files Date: Tue, 16 May 2023 22:47:56 -0700 Message-Id: <20230517054756.11119-1-zev@bewilderbeest.net> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766120571866474496?= X-GMAIL-MSGID: =?utf-8?q?1766120571866474496?= |
Series |
gpio: mockup: Fix mode of debugfs files
|
|
Commit Message
Zev Weiss
May 17, 2023, 5:47 a.m. UTC
This driver's debugfs files have had a read operation since commit
2a9e27408e12 ("gpio: mockup: rework debugfs interface"), but were
still being created with write-only mode bits. Update them to
indicate that the files can also be read.
Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Fixes: 2a9e27408e12 ("gpio: mockup: rework debugfs interface")
Cc: stable@kernel.org # v5.1+
---
drivers/gpio/gpio-mockup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Wed, May 17, 2023 at 7:50 AM Zev Weiss <zev@bewilderbeest.net> wrote: > > This driver's debugfs files have had a read operation since commit > 2a9e27408e12 ("gpio: mockup: rework debugfs interface"), but were > still being created with write-only mode bits. Update them to > indicate that the files can also be read. > > Signed-off-by: Zev Weiss <zev@bewilderbeest.net> > Fixes: 2a9e27408e12 ("gpio: mockup: rework debugfs interface") > Cc: stable@kernel.org # v5.1+ > --- > drivers/gpio/gpio-mockup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c > index e6a7049bef64..b32063ac845a 100644 > --- a/drivers/gpio/gpio-mockup.c > +++ b/drivers/gpio/gpio-mockup.c > @@ -369,7 +369,7 @@ static void gpio_mockup_debugfs_setup(struct device *dev, > priv->offset = i; > priv->desc = gpiochip_get_desc(gc, i); > > - debugfs_create_file(name, 0200, chip->dbg_dir, priv, > + debugfs_create_file(name, 0600, chip->dbg_dir, priv, > &gpio_mockup_debugfs_ops); > } > } > -- > 2.40.1 > Good catch, applied, thanks! Bart
diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c index e6a7049bef64..b32063ac845a 100644 --- a/drivers/gpio/gpio-mockup.c +++ b/drivers/gpio/gpio-mockup.c @@ -369,7 +369,7 @@ static void gpio_mockup_debugfs_setup(struct device *dev, priv->offset = i; priv->desc = gpiochip_get_desc(gc, i); - debugfs_create_file(name, 0200, chip->dbg_dir, priv, + debugfs_create_file(name, 0600, chip->dbg_dir, priv, &gpio_mockup_debugfs_ops); } }