From patchwork Tue May 16 19:56:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 94904 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp673000vqo; Tue, 16 May 2023 13:07:31 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4s5XbGwt0hFdgvDMrYH4GPCa2MiTWZeSKxAi4ZEFOG109Z74/Z8dYO1jqSatTV80baokKQ X-Received: by 2002:a17:903:234e:b0:1ac:a9c1:b61d with SMTP id c14-20020a170903234e00b001aca9c1b61dmr31857200plh.11.1684267650942; Tue, 16 May 2023 13:07:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684267650; cv=none; d=google.com; s=arc-20160816; b=UUaOvoIArnVON6+1HC+0EYMelJ3AqqeoIEPYPaGF/Ec5PFzR+YdVPpqhTezx4bnjLP SMEhv/MUymMna+Jg9dqSUa1QEhN/K0udJ0J0lnz0HONWVi22/OaqYIhXpF1y9JDgTxzd Aa4J9f44T7YKo/T9lF0fBR8NQGjO8afFXX4fiZ5kVgRqfM3gjKTwlBcnW0T964Yx+bC7 a9K9jr81kLS1QTWIH37VQumM5jT+FISo/xNEVH8V4EOqAEIzyJXaGtnTOkJ6f7WgJ7I5 MvlSVLHqeIuwfHL+9UTAlTwJddsml6wDrtcQCK/FPohyE5mJOhC9ciLBr1EW2JU+bsrZ kOow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=IYcOUO92D1eXdCvSiUYt+ZtTo/loIdm7ZRcE/DQbRzA=; b=tVMKxRU2z+qOWQiJPzNuedq6yPUToIGtWPgpJUXhwI2/Jwd3PjiMH9SoECqXxoQ3pQ 9GZQ2cLySTE5qkjeF+VYbAP8b0Y49mfDCZfYfH6uZ4TEsBjX5muINEDqDBez9ZIJcuvd NeZaixHGyP/QIxpzlHoyuWgja5WMCqD93ke36RhuTe/Qp85DwYXVTu2TYr3aO2NNEGSs px99CwlgHHKX4rPb3TRhnuXLgLz1RpITi/easxiNjcPbtjIecdGeWyJ/FuMOrFh3C5YR WpzgIQaVTV6xNzQZFQdRElTr2fb+NrlcX65Yr6MI0VDLlwiBtisUxdeRwSKrz8nvDmt5 KdoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tf3mGJYb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jc15-20020a17090325cf00b001a6fe422894si9293941plb.200.2023.05.16.13.07.07; Tue, 16 May 2023 13:07:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tf3mGJYb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229999AbjEPT4j (ORCPT + 99 others); Tue, 16 May 2023 15:56:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229923AbjEPT4h (ORCPT ); Tue, 16 May 2023 15:56:37 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACA8B7ABE; Tue, 16 May 2023 12:56:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 334E4633A0; Tue, 16 May 2023 19:56:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 283ACC4339B; Tue, 16 May 2023 19:56:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684266994; bh=ZU2Zyf0H03rXKE9YvXFofcikO93Ns0RFs8ZYRp3OsaA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tf3mGJYbfXDUuKzpYVC5dBWll5p0S5N9WMNdtJ2iqua20Z0hH2+at4Hys1CA5/sxb 7P4NZQIaQd3ePO75ufKBX/LinFDNMXdX8hgScHPgH6wtoglVscXDYpsLMUs2cO882L AK7P/lDH6t2IwAltA04Ffi/oUidP9yht9vqPFrwZ4/dSSqsrov48xn++4QuyMBWnHw jHVCAyLwdl0nFMEn5hWEMzeh4huCRcYId+bahUgj2UidiWqva7Db8/9DA3LxdjPpre 2GsLHhTSqOIrwMQB21Ym2n8cFLla0kRyfAWrC2kJmTZGAZlsqFg+pRq8aAcmcfXXSf u/d0gVkvAGV4Q== From: Arnd Bergmann To: viro@zeniv.linux.org.uk, brauner@kernel.org, David Howells Cc: linux-fsdevel@vger.kernel.org, Arnd Bergmann , linux-kernel@vger.kernel.org Subject: [PATCH 2/2] fs: pipe: reveal missing function protoypes Date: Tue, 16 May 2023 21:56:12 +0200 Message-Id: <20230516195629.551602-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230516195444.551461-1-arnd@kernel.org> References: <20230516195444.551461-1-arnd@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766082636025636962?= X-GMAIL-MSGID: =?utf-8?q?1766082636025636962?= From: Arnd Bergmann A couple of functions from fs/pipe.c are used both internally and for the watch queue code, but the declaration is only visible when the latter is enabled: fs/pipe.c:1254:5: error: no previous prototype for 'pipe_resize_ring' fs/pipe.c:758:15: error: no previous prototype for 'account_pipe_buffers' fs/pipe.c:764:6: error: no previous prototype for 'too_many_pipe_buffers_soft' fs/pipe.c:771:6: error: no previous prototype for 'too_many_pipe_buffers_hard' fs/pipe.c:777:6: error: no previous prototype for 'pipe_is_unprivileged_user' Make the visible unconditionally to avoid these warnings. Fixes: c73be61cede5 ("pipe: Add general notification queue support") Signed-off-by: Arnd Bergmann --- include/linux/pipe_fs_i.h | 4 ---- 1 file changed, 4 deletions(-) diff --git a/include/linux/pipe_fs_i.h b/include/linux/pipe_fs_i.h index d2c3f16cf6b1..02e0086b10f6 100644 --- a/include/linux/pipe_fs_i.h +++ b/include/linux/pipe_fs_i.h @@ -261,18 +261,14 @@ void generic_pipe_buf_release(struct pipe_inode_info *, struct pipe_buffer *); extern const struct pipe_buf_operations nosteal_pipe_buf_ops; -#ifdef CONFIG_WATCH_QUEUE unsigned long account_pipe_buffers(struct user_struct *user, unsigned long old, unsigned long new); bool too_many_pipe_buffers_soft(unsigned long user_bufs); bool too_many_pipe_buffers_hard(unsigned long user_bufs); bool pipe_is_unprivileged_user(void); -#endif /* for F_SETPIPE_SZ and F_GETPIPE_SZ */ -#ifdef CONFIG_WATCH_QUEUE int pipe_resize_ring(struct pipe_inode_info *pipe, unsigned int nr_slots); -#endif long pipe_fcntl(struct file *, unsigned int, unsigned long arg); struct pipe_inode_info *get_pipe_info(struct file *file, bool for_splice);