From patchwork Tue May 16 19:14:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wander Lairson Costa X-Patchwork-Id: 94870 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp652154vqo; Tue, 16 May 2023 12:24:01 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7pAZbbDpFggKSdk1/B/x+elszyIZevFLy9Wf24GanubFJJAnXcKLwFYEc3RyqMjdmOlSx/ X-Received: by 2002:a05:6a21:329c:b0:102:8f0a:5acf with SMTP id yt28-20020a056a21329c00b001028f0a5acfmr29487520pzb.62.1684265041255; Tue, 16 May 2023 12:24:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684265041; cv=none; d=google.com; s=arc-20160816; b=BLEU7Ul/9YPZxvsJ4OB/00gXdOdemXG7LUOs1bBN2Fd7fckuyaF2OTXuEQaaL1hG+v LwOx5XejsOytmu7PNAkfdH7ArF3XnBuaZj/IJZmtxSXTDBtudAppYuhsgI2rwlklCX+M PPWncGlAUIMPrJl+E5KINxVXropdTElwKCNceFw/UZA6PrKq/Z0n0TWOJKHH41xGvezc fxLDL/Mn+o4LyJPVL34+FscwdXI1AN4QK5JCgGEnL/QoWxT6BiBv/vMbUTnpJnVW9kpW M5VMQMIQ+71jl1THdiUVC35qytfhCbIImPD2CNuQ+NMSnn+nswuX6EakdNz0bwGItco1 F5Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=5L1aJYtcbR7dHch+1g8syxuuSJfOlW1pxYhUzrmVLTw=; b=lMDb5ANZI1N9oWF72qT+FDhDyc5gMnQYZSgrP1PgM0J84WIgrKtciedIPSq87HOiek dOVU4H3Ly1q3c6xh1H0tYcfcGH5goxSaadzkNo3B5DDJdk5ltPGGCOvY1QbSp7mUqm5F ppMvDLyroMzIv/x77oer4oPALq383NIuSxBbnzQa2/ifjZeremhkHPs2AhWT0/tWOyK6 39seBSm2byya3ZV+q7c+lCP0Ylvgly6IBS2RLLSRL8C4uKmuBS/ztNpgtZE2E8S+cDLg cQiNiO2cwiJfwp5kQgxjLz87TQWWalkLIZCJJkFD5J1+QGm6gjT076qr/cJP/ESvhh+k gt3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=IsnFrOg9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 76-20020a63004f000000b005303b23ed6csi19489776pga.531.2023.05.16.12.23.48; Tue, 16 May 2023 12:24:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=IsnFrOg9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229539AbjEPTPr (ORCPT + 99 others); Tue, 16 May 2023 15:15:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229568AbjEPTPp (ORCPT ); Tue, 16 May 2023 15:15:45 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51FDA49EF for ; Tue, 16 May 2023 12:15:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684264499; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=5L1aJYtcbR7dHch+1g8syxuuSJfOlW1pxYhUzrmVLTw=; b=IsnFrOg9Q/WVv2Bsr+abbocaRKO2iBSXaqMn2PeCQ0ydqVrGJv1Ngh1nbvGYK9mxUCgIZz ncZbNkxZg4zX3lJVSDxFQvSSgqhuHLGbhpNRoKNkFrCMdYhPTFTID0NyDQr2bkNPt2TLzs 6DIbfjx+ODnKD9w5Z3mkOBZcvs3qNNg= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-228-Cgpq0UWTNzKc8Fd-rELAiA-1; Tue, 16 May 2023 15:14:52 -0400 X-MC-Unique: Cgpq0UWTNzKc8Fd-rELAiA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B70751C060CB; Tue, 16 May 2023 19:14:50 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.22.9.87]) by smtp.corp.redhat.com (Postfix) with ESMTP id D0B8F2166B31; Tue, 16 May 2023 19:14:44 +0000 (UTC) From: Wander Lairson Costa To: Oleg Nesterov , "Russell King (Oracle)" , Brian Cain , Michael Ellerman , Stafford Horne , Kefeng Wang , Wander Lairson Costa , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , "Matthew Wilcox (Oracle)" , "Eric W. Biederman" , Andrei Vagin , Peter Zijlstra , "Paul E. McKenney" , Daniel Bristot de Oliveira , Yu Zhao , Alexey Gladkov , Mike Kravetz , Yang Shi , linux-kernel@vger.kernel.org (open list) Cc: Hu Chunyu , Valentin Schneider , Sebastian Andrzej Siewior , Steven Rostedt , Luis Goncalves Subject: [PATCH v9] kernel/fork: beware of __put_task_struct calling context Date: Tue, 16 May 2023 16:14:41 -0300 Message-Id: <20230516191441.34377-1-wander@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766079900048804221?= X-GMAIL-MSGID: =?utf-8?q?1766079900048804221?= Under PREEMPT_RT, __put_task_struct() indirectly acquires sleeping locks. Therefore, it can't be called from an non-preemptible context. One practical example is splat inside inactive_task_timer(), which is called in a interrupt context: CPU: 1 PID: 2848 Comm: life Kdump: loaded Tainted: G W --------- Hardware name: HP ProLiant DL388p Gen8, BIOS P70 07/15/2012 Call Trace: dump_stack_lvl+0x57/0x7d mark_lock_irq.cold+0x33/0xba ? stack_trace_save+0x4b/0x70 ? save_trace+0x55/0x150 mark_lock+0x1e7/0x400 mark_usage+0x11d/0x140 __lock_acquire+0x30d/0x930 lock_acquire.part.0+0x9c/0x210 ? refill_obj_stock+0x3d/0x3a0 ? rcu_read_lock_sched_held+0x3f/0x70 ? trace_lock_acquire+0x38/0x140 ? lock_acquire+0x30/0x80 ? refill_obj_stock+0x3d/0x3a0 rt_spin_lock+0x27/0xe0 ? refill_obj_stock+0x3d/0x3a0 refill_obj_stock+0x3d/0x3a0 ? inactive_task_timer+0x1ad/0x340 kmem_cache_free+0x357/0x560 inactive_task_timer+0x1ad/0x340 ? switched_from_dl+0x2d0/0x2d0 __run_hrtimer+0x8a/0x1a0 __hrtimer_run_queues+0x91/0x130 hrtimer_interrupt+0x10f/0x220 __sysvec_apic_timer_interrupt+0x7b/0xd0 sysvec_apic_timer_interrupt+0x4f/0xd0 ? asm_sysvec_apic_timer_interrupt+0xa/0x20 asm_sysvec_apic_timer_interrupt+0x12/0x20 RIP: 0033:0x7fff196bf6f5 Instead of calling __put_task_struct() directly, we defer it using call_rcu(). A more natural approach would use a workqueue, but since in PREEMPT_RT, we can't allocate dynamic memory from atomic context, the code would become more complex because we would need to put the work_struct instance in the task_struct and initialize it when we allocate a new task_struct. Changelog ========= v1: * Initial implementation fixing the splat. v2: * Isolate the logic in its own function. * Fix two more cases caught in review. v3: * Change __put_task_struct() to handle the issue internally. v4: * Explain why call_rcu() is safe to call from interrupt context. v5: * Explain why __put_task_struct() doesn't conflict with put_task_sruct_rcu_user. v6: * As per Sebastian's review, revert back the implementation of v2 with a distinct function. * Add a check in put_task_struct() to warning when called from a non-sleepable context. * Address more call sites. v7: * Fix typos. * Add an explanation why the new function doesn't conflict with delayed_free_task(). v8: * Bring back v5. * Fix coding style. v9: * Reorganize to not need ___put_task_struct() by Oleg's suggestion. Signed-off-by: Wander Lairson Costa Reported-by: Hu Chunyu Suggested-by: Oleg Nesterov Suggested-by: Valentin Schneider Suggested-by: Peter Zijlstra Cc: Sebastian Andrzej Siewior Cc: Paul McKenney Cc: Steven Rostedt Cc: Luis Goncalves --- include/linux/sched/task.h | 28 +++++++++++++++++++++++++++- kernel/fork.c | 8 ++++++++ 2 files changed, 35 insertions(+), 1 deletion(-) diff --git a/include/linux/sched/task.h b/include/linux/sched/task.h index d6c48163c6de..9bcb9535d4e1 100644 --- a/include/linux/sched/task.h +++ b/include/linux/sched/task.h @@ -112,10 +112,36 @@ static inline struct task_struct *get_task_struct(struct task_struct *t) } extern void __put_task_struct(struct task_struct *t); +extern void __put_task_struct_rcu_cb(struct rcu_head *rhp); static inline void put_task_struct(struct task_struct *t) { - if (refcount_dec_and_test(&t->usage)) + if (!refcount_dec_and_test(&t->usage)) + return; + + /* + * under PREEMPT_RT, we can't call put_task_struct + * in atomic context because it will indirectly + * acquire sleeping locks. + * + * call_rcu() will schedule delayed_put_task_struct_rcu() + * to be called in process context. + * + * __put_task_struct() is called when + * refcount_dec_and_test(&t->usage) succeeds. + * + * This means that it can't "conflict" with + * put_task_struct_rcu_user() which abuses ->rcu the same + * way; rcu_users has a reference so task->usage can't be + * zero after rcu_users 1 -> 0 transition. + * + * delayed_free_task() also uses ->rcu, but it is only called + * when it fails to fork a process. Therefore, there is no + * way it can conflict with put_task_struct(). + */ + if (IS_ENABLED(CONFIG_PREEMPT_RT) && !preemptible()) + call_rcu(&t->rcu, __put_task_struct_rcu_cb); + else __put_task_struct(t); } diff --git a/kernel/fork.c b/kernel/fork.c index 08969f5aa38d..fd3bb4a554c4 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -846,6 +846,14 @@ void __put_task_struct(struct task_struct *tsk) } EXPORT_SYMBOL_GPL(__put_task_struct); +void __put_task_struct_rcu_cb(struct rcu_head *rhp) +{ + struct task_struct *task = container_of(rhp, struct task_struct, rcu); + + __put_task_struct(task); +} +EXPORT_SYMBOL_GPL(__put_task_struct_rcu_cb); + void __init __weak arch_task_cache_init(void) { } /*