From patchwork Tue May 16 07:57:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: JiaJie Ho X-Patchwork-Id: 94500 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp256690vqo; Tue, 16 May 2023 01:09:18 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5YIUhfrTMxuWf+RcvU29xVRK7ds/r2r9tnlMqRAowHAMXn3sIWEVd6nUc32I6qYXrKurBU X-Received: by 2002:a05:6a20:3d82:b0:104:2200:8949 with SMTP id s2-20020a056a203d8200b0010422008949mr21618618pzi.56.1684224558590; Tue, 16 May 2023 01:09:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684224558; cv=none; d=google.com; s=arc-20160816; b=DtcBQQ1s1KVujfcHXD1pevf1eKw80ZGTXFK3OVHKBUmgZgAWtRuNlwTkcjdkwH46C2 fuMnZz3l1p5nDIpj28P8sH7fb1ySg+1DNybetUAwpUqhmFdxStBI0Ow7t0ehYQ7E4YkU mTqvS5YCkthbYkS2B9TpAk6jcG+fhPJ4ftPxVax+I/waxs3YwaA6HAZzGv3pOd3//iou GxTo+roqWDhoUNTQ/5mdMpFKns9HC7qkRoaa2F+QIWbj0UJ2ayyM5U46GcxGRBb4lhtI X4T9hrvcEKdqxt32ngR+t9QtImlAByMxPqlYJevlLLwfHUPygm4MFOj+Ib6MIsOBhAyD LeuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=0A4gTIpm/lZXYlnzIMFigWVlhHM9mr0NCG2dMxV9ulU=; b=y61qvEi17Il0ZJi7LEB2itYnFVq96Crv6ypiJi0dbIg/zvrcrDVPq7rYmpteYWkxWN gdNUc/SU4UmnvOYjvGQz4w9hTRnpIn0qPxirGNC6Uzg8tOshV1CNxE+5vkZwJ47K0Jv8 xJdFfl3Yn+Nfv6kFTPwt0Fg/fSqs75kQ13hZY8MxHLzUBYxg8bnNH4oF4Du8f/C1tY/X +9A0O0KpDglnt7Wiz7MQdctKDqKqOLQsX8mccVtJOFipw0fvtLW2jRp3x6fitG5007Dw HVRaHHdiQwMRFWewPJMx1/nvKA3tbEZwy6fVgrzQm/WTvx/n93mO/V9VJBZaamAF334y Rasw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j5-20020a637a45000000b005303a26dbf8si18155364pgn.408.2023.05.16.01.09.02; Tue, 16 May 2023 01:09:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231169AbjEPH6J convert rfc822-to-8bit (ORCPT + 99 others); Tue, 16 May 2023 03:58:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230504AbjEPH6D (ORCPT ); Tue, 16 May 2023 03:58:03 -0400 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0591A30C2; Tue, 16 May 2023 00:58:01 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 1E33E24E302; Tue, 16 May 2023 15:58:00 +0800 (CST) Received: from EXMBX168.cuchost.com (172.16.6.78) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 16 May 2023 15:58:00 +0800 Received: from ubuntu.localdomain (202.188.176.82) by EXMBX168.cuchost.com (172.16.6.78) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 16 May 2023 15:57:57 +0800 From: Jia Jie Ho To: Herbert Xu , "David S . Miller" CC: , Subject: [PATCH 1/2] crypto: starfive - Update hash module irq handling Date: Tue, 16 May 2023 15:57:51 +0800 Message-ID: <20230516075752.659287-2-jiajie.ho@starfivetech.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230516075752.659287-1-jiajie.ho@starfivetech.com> References: <20230516075752.659287-1-jiajie.ho@starfivetech.com> MIME-Version: 1.0 X-Originating-IP: [202.188.176.82] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX168.cuchost.com (172.16.6.78) X-YovoleRuleAgent: yovoleflag X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766037450230680001?= X-GMAIL-MSGID: =?utf-8?q?1766037450230680001?= Hash driver needs to check the value of irq mask register before writing as it will mask irq of other modules. Co-developed-by: Huan Feng Signed-off-by: Huan Feng Signed-off-by: Jia Jie Ho --- drivers/crypto/starfive/jh7110-hash.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/starfive/jh7110-hash.c b/drivers/crypto/starfive/jh7110-hash.c index 3801e44f2f33..5064150b8a1c 100644 --- a/drivers/crypto/starfive/jh7110-hash.c +++ b/drivers/crypto/starfive/jh7110-hash.c @@ -39,6 +39,7 @@ #define STARFIVE_HASH_SHAWKLEN (STARFIVE_HASH_REGS_OFFSET + 0x24) #define STARFIVE_HASH_BUFLEN SHA512_BLOCK_SIZE +#define STARFIVE_HASH_RESET 0x2 static inline int starfive_hash_wait_busy(struct starfive_cryp_ctx *ctx) { @@ -95,6 +96,7 @@ static void starfive_hash_start(void *param) struct starfive_cryp_dev *cryp = ctx->cryp; union starfive_alg_cr alg_cr; union starfive_hash_csr csr; + u32 stat; dma_unmap_sg(cryp->dev, rctx->in_sg, rctx->in_sg_len, DMA_TO_DEVICE); @@ -107,7 +109,9 @@ static void starfive_hash_start(void *param) csr.firstb = 0; csr.final = 1; - writel(~STARFIVE_IE_MASK_HASH_DONE, cryp->base + STARFIVE_IE_MASK_OFFSET); + stat = readl(cryp->base + STARFIVE_IE_MASK_OFFSET); + stat &= ~STARFIVE_IE_MASK_HASH_DONE; + writel(stat, cryp->base + STARFIVE_IE_MASK_OFFSET); writel(csr.v, cryp->base + STARFIVE_HASH_SHACSR); } @@ -223,6 +227,9 @@ void starfive_hash_done_task(unsigned long param) if (!err) err = starfive_hash_copy_hash(cryp->req.hreq); + /* Reset to clear hash_done in irq register*/ + writel(STARFIVE_HASH_RESET, cryp->base + STARFIVE_HASH_SHACSR); + crypto_finalize_hash_request(cryp->engine, cryp->req.hreq, err); }