From patchwork Mon May 15 18:23:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hugo Villeneuve X-Patchwork-Id: 94299 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp7128047vqo; Mon, 15 May 2023 12:00:13 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5Vdwp4KDlFQnzuCQr0JLGvPox4mNpZVMjcfdBuSoV+lTOEIjCgDQPAHoNgeoJTHL9ezame X-Received: by 2002:a05:6a20:3ca2:b0:104:144:dbdc with SMTP id b34-20020a056a203ca200b001040144dbdcmr20439772pzj.33.1684177213172; Mon, 15 May 2023 12:00:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684177213; cv=none; d=google.com; s=arc-20160816; b=VjgHscR9P6Q41bYwCT/xplmK/5Zcfv0PvIuDivy/mzgj+antJ1b2PnnVha+pooA8qB j1Y4I+nit9Q4EwzdvjLmwordNucVxdguNZkA+nkvS03mvmJ8PNC+gdKnf2+GnUtcEKOf sRPwTIQHk1csV4KyYYPewJFiib8NZkeFFR36xJl9KAy2E+p/HWW/tURG2YhV3vFMY1E+ fujzvMM8x02FKqkN3fj29Qy9Orzs4cEWXeV/Z5wwZeYJU57B0lgGLdUdlen3xkD9t9BS aGrYkizMS4KiGCVpSrWmrbxuUluoCN4SG9RmXNZCbwDNLw0rJVTA9MfZYUzEwOD4bV14 Ro9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:mime-version :message-id:date:cc:to:from:dkim-signature; bh=xv65otAZpwQe0poNNXfHJow6UPxE0aTdH/CgQXwd/GM=; b=wHg6mOwfV2PFRKuEM+lDoahezNQzx0Aq0KY9p+ZZ2+xAG6gEEormQwqZdJqqOAtaVa UD9ksmmcQBWSmgzIKLUpoO4sZ6RYP0GEZL+m7CHoqyLKtEf6jVfAr4PsAlsBk54ef1z5 EH4mSL3Ngwce17qeKiRI4O8n1y4ThuyhyTvLkNiX1O3qoohMJqN5jGS5BMVPlgygtUpD KyNBES7FE0rOzfHYaw8LX9PK1HktRCohMq1NyOjf8PvLFH2l8Zv8j+5VHWAu2Qmf2Vae KdV9GQELQI2p+6+wEp7GgNUWk7qdOnI7QBzMwrvl0gtB71Ig/buSJjjX+WMSYxqm8nNH aXUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@hugovil.com header.s=x header.b=xESn0Ixi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e3-20020a17090a818300b00246a75f49desi176681pjn.112.2023.05.15.11.59.58; Mon, 15 May 2023 12:00:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@hugovil.com header.s=x header.b=xESn0Ixi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242335AbjEOSZX (ORCPT + 99 others); Mon, 15 May 2023 14:25:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243318AbjEOSZF (ORCPT ); Mon, 15 May 2023 14:25:05 -0400 Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9FB31BFD; Mon, 15 May 2023 11:25:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Cc:To :From:Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=xv65otAZpwQe0poNNXfHJow6UPxE0aTdH/CgQXwd/GM=; b=x ESn0IxihlZCerMfMRPWlN90vJTk2/Y6YrR1aGBf2bcepWHqjoDn9kKZf7WsRahbCkwlMmBii6OkdX qFnv0KXaGoOmUK3GZeEJGUiXfCZwcQSaC3MIdVK3cipvuNttv0KNxZ5txud1sE+BYeYBGfE0LQoZQ fKYSWo5dTYd460Kw=; Received: from modemcable168.174-80-70.mc.videotron.ca ([70.80.174.168]:38650 helo=pettiford.lan) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from ) id 1pycsW-0004X8-Q5; Mon, 15 May 2023 14:25:01 -0400 From: Hugo Villeneuve To: Alessandro Zummo , Alexandre Belloni Cc: hugo@hugovil.com, Hugo Villeneuve , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 15 May 2023 14:23:47 -0400 Message-Id: <20230515182347.2939997-1-hugo@hugovil.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 70.80.174.168 X-SA-Exim-Mail-From: hugo@hugovil.com X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 Subject: [PATCH v2] rtc: pcf2127: add error checking when disabling POR0 X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1765987805325286895?= X-GMAIL-MSGID: =?utf-8?q?1765987805325286895?= From: Hugo Villeneuve If PCF2127 device is absent from the I2C bus, or if there is a communication problem, disabling POR0 may fail silently and we still continue with probing the device. In that case, abort probe operation. Signed-off-by: Hugo Villeneuve --- V1 -> V2: Removed error message drivers/rtc/rtc-pcf2127.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) base-commit: e99ab4abebf825de2ce65f6c6c32ee30e00bb077 diff --git a/drivers/rtc/rtc-pcf2127.c b/drivers/rtc/rtc-pcf2127.c index 87f4fc9df68b..d9d3ef373c03 100644 --- a/drivers/rtc/rtc-pcf2127.c +++ b/drivers/rtc/rtc-pcf2127.c @@ -703,8 +703,10 @@ static int pcf2127_probe(struct device *dev, struct regmap *regmap, * The "Power-On Reset Override" facility prevents the RTC to do a reset * after power on. For normal operation the PORO must be disabled. */ - regmap_clear_bits(pcf2127->regmap, PCF2127_REG_CTRL1, + ret = regmap_clear_bits(pcf2127->regmap, PCF2127_REG_CTRL1, PCF2127_BIT_CTRL1_POR_OVRD); + if (ret < 0) + return ret; ret = regmap_read(pcf2127->regmap, PCF2127_REG_CLKOUT, &val); if (ret < 0)