Message ID | 20230515180138.591710284@redhat.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp7108025vqo; Mon, 15 May 2023 11:19:49 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7y1we4MjCxxydzmvJgKu9Ut9vWiPMsSXWpDsQGypzcRJasYto2HIBJ5iv4Z+HqkkBZs77o X-Received: by 2002:a05:6a00:2401:b0:63d:3339:e967 with SMTP id z1-20020a056a00240100b0063d3339e967mr43882556pfh.19.1684174789607; Mon, 15 May 2023 11:19:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684174789; cv=none; d=google.com; s=arc-20160816; b=MDvYe2TyJ7h639q++01Tjivwp6owNAJiHP8aI6rPxtCZjEJIHqNKqCkLMY5AbCte8B 984VoA+hpba38vcvxObtof8l6rIasDDUund0hZiLf+6h4cbXIsvakm02dkM6uZFNvgk4 9Xoc+ELx2PbL7fwU+Sb23me81iY0nPNHYOKROyTkLLoEwkuUqH/OEKaIeo5384PKaM9M EiItmNyG5ntG8VQ7BR1J8+s9f+K1KQlHSi42HO/18Oz6DthYECyNNZR0xiLbF0zuIkrX KtdWyYTI3/KGsep01ZIW9zeekx0ocGfZ/qPDAGlw2k5N9YMn9uNYKN7TMNYWcn113bQ/ 0l3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id:dkim-signature; bh=BJ6i2oDSiY3YdcuHRj+4qVRIpmZay1wZiVJ33jyxj48=; b=tUH0CdHmWuDKWdnTWEV9wVD2a2yWNRnU3Cy6+UkB4dLijXcjWddTM2ykDjsWyXqDie h6QOypyq5FrnctkHjOwc4RtSk4i+HSUBWC8lrArqH9lA80ccOrUV5uH8NEHzmAnasTNV V/lo4YIq1har1GmI1uLLRU/W8nbraI/Ngx5MGYGricb4tsTeZ90sIyV9UHClbik2wcFJ RynsZFicJTx7EDa9Ckjylz6qJJ0H9TpoHZvumdDewt5hOcl317t8dRXLjznzPuPeShTS yIdfJNUGB8cVmbBdgxByH2vpI8ClgPuly23DmTMT9XfCxIKNqFmTTsSdVnfZg8Lp4lB8 aN4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PjSIb+Ln; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z23-20020aa79597000000b0063b85b18764si17716532pfj.219.2023.05.15.11.19.37; Mon, 15 May 2023 11:19:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PjSIb+Ln; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244994AbjEOSHl (ORCPT <rfc822;peekingduck44@gmail.com> + 99 others); Mon, 15 May 2023 14:07:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245020AbjEOSGr (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 15 May 2023 14:06:47 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A968F659B for <linux-kernel@vger.kernel.org>; Mon, 15 May 2023 11:03:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684173827; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=BJ6i2oDSiY3YdcuHRj+4qVRIpmZay1wZiVJ33jyxj48=; b=PjSIb+LnT91LxWlqsyWhcdESZ9VlPFgya2xGxH8emPMgoTgXS8CONHs3Xl5vKmaAkaFmCC H+CxZfaEBtEtPMBeFoeKPf34gJGx1iVvHFRRe4gjYhpS0QJinxBIOZ1W3JQp2k9VEEY9dy 7EgEWmQt5Mhd6b9a6h5gOnD8tpRuFdQ= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-159-HcyxXZ_fOKim-3NV21rk8g-1; Mon, 15 May 2023 14:03:42 -0400 X-MC-Unique: HcyxXZ_fOKim-3NV21rk8g-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 64E8A382C96A; Mon, 15 May 2023 18:03:41 +0000 (UTC) Received: from tpad.localdomain (ovpn-112-4.gru2.redhat.com [10.97.112.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2E3102026D25; Mon, 15 May 2023 18:03:41 +0000 (UTC) Received: by tpad.localdomain (Postfix, from userid 1000) id 65C8A4161E529; Mon, 15 May 2023 15:02:17 -0300 (-03) Message-ID: <20230515180138.591710284@redhat.com> User-Agent: quilt/0.67 Date: Mon, 15 May 2023 15:00:22 -0300 From: Marcelo Tosatti <mtosatti@redhat.com> To: Christoph Lameter <cl@linux.com> Cc: Aaron Tomlin <atomlin@atomlin.com>, Frederic Weisbecker <frederic@kernel.org>, Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Russell King <linux@armlinux.org.uk>, Huacai Chen <chenhuacai@kernel.org>, Heiko Carstens <hca@linux.ibm.com>, x86@kernel.org, Vlastimil Babka <vbabka@suse.cz>, Michal Hocko <mhocko@suse.com>, Peter Xu <peterx@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com> Subject: [PATCH v8 07/13] convert this_cpu_cmpxchg users to this_cpu_cmpxchg_local References: <20230515180015.016409657@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1765985264162966343?= X-GMAIL-MSGID: =?utf-8?q?1765985264162966343?= |
Series |
fold per-CPU vmstats remotely
|
|
Commit Message
Marcelo Tosatti
May 15, 2023, 6 p.m. UTC
this_cpu_cmpxchg was modified to atomic version, which can be more costly than non-atomic version. Switch users of this_cpu_cmpxchg to this_cpu_cmpxchg_local (which preserves pre-non-atomic this_cpu_cmpxchg behaviour). Acked-by: Peter Xu <peterx@redhat.com> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com> ---
Index: linux-vmstat-remote/kernel/fork.c =================================================================== --- linux-vmstat-remote.orig/kernel/fork.c +++ linux-vmstat-remote/kernel/fork.c @@ -205,7 +205,7 @@ static bool try_release_thread_stack_to_ unsigned int i; for (i = 0; i < NR_CACHED_STACKS; i++) { - if (this_cpu_cmpxchg(cached_stacks[i], NULL, vm) != NULL) + if (this_cpu_cmpxchg_local(cached_stacks[i], NULL, vm) != NULL) continue; return true; } Index: linux-vmstat-remote/kernel/scs.c =================================================================== --- linux-vmstat-remote.orig/kernel/scs.c +++ linux-vmstat-remote/kernel/scs.c @@ -83,7 +83,7 @@ void scs_free(void *s) */ for (i = 0; i < NR_CACHED_SCS; i++) - if (this_cpu_cmpxchg(scs_cache[i], 0, s) == NULL) + if (this_cpu_cmpxchg_local(scs_cache[i], 0, s) == NULL) return; kasan_unpoison_vmalloc(s, SCS_SIZE, KASAN_VMALLOC_PROT_NORMAL);