| Message ID | 20230515114043.3452010-1-trix@redhat.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp6866448vqo;
Mon, 15 May 2023 05:07:04 -0700 (PDT)
X-Google-Smtp-Source:
ACHHUZ6xPQ606nAXCHva54zUXdDvGlZzTOp2g+5TF0BjvBBvvWFr+uxaHCbQwFj0R4iOg6Xpw2V0
X-Received: by 2002:a05:6870:7301:b0:192:cb3d:c069 with SMTP id
q1-20020a056870730100b00192cb3dc069mr14178095oal.2.1684152424471;
Mon, 15 May 2023 05:07:04 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1684152424; cv=none;
d=google.com; s=arc-20160816;
b=fYDJvhm+WlYm+d3z7y/zhp6BfQZFUh2tm9bmCGGL1JHGZ1WofUrUjFkD6EZMqRYfJ0
Y/bVUAJQYp0/eFtcuUp8/DaZRHvegkgSicabYvjtjuVqJ5p5I7Tu8+NNjreaOaTx6vUo
zMOvG9asaFBCWjfmJUtInomg8ln4NR3wHu+g4kpnhNs4NTXzy1S5r5KUeUcWH0qE9kWf
XTuW2VjaygK5epN7rF4eIZPWVe9gPQJ7r38IGKT8wR/l1nF1gsWfmqj2WQpJWsGb9Fzu
LjgI/EXkJYfcx6O6sSbw/YSABbqaYGQ4+JnVanjtOBAwSmyImW8tp3dZHawbpdTdCHjb
BVsg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=/HfDmifvLEGL+myxWzfdruEc+v2HKRtI9dyoUcoziAo=;
b=Qu6IXkdD4mYPpAbm7h0kCc9n+es7Rt1Rd0B0jRMYfQaHkufmHAAD1Eeoh15SeO/YCQ
HJiMkT8OdpAcHSRsOKejTVfoW+8i+pMLE5/qHr7OTtA1DbBBfR5yBBLyHtYylY8yBo52
sVwQOz2RnMa3fLXratA79eI5BnQuNLS54wqkhAoC4vXT78tqyUtXw+Au89oARx578B6V
LMN36QayyxhOs7w/Ei7PmnFVqPEjMZJPTHjk4FkiEjur2SQTHVhSXSlkR90nBUs1/P+/
36cwqT3AEXDuhEUtdExRWIXJmiELaJn3Wjp1lIidzIz1vPSqWc1KISMdwmKKsToF43hL
RhgA==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@redhat.com header.s=mimecast20190719
header.b=A4rRvO5m;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
u26-20020a056871009a00b00199c258d416si1966796oaa.309.2023.05.15.05.06.50;
Mon, 15 May 2023 05:07:04 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@redhat.com header.s=mimecast20190719
header.b=A4rRvO5m;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S241430AbjEOLyc (ORCPT <rfc822;peekingduck44@gmail.com>
+ 99 others); Mon, 15 May 2023 07:54:32 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50478 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S241256AbjEOLyL (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Mon, 15 May 2023 07:54:11 -0400
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [170.10.133.124])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EAF8A5273
for <linux-kernel@vger.kernel.org>;
Mon, 15 May 2023 04:40:48 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1684150847;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:
content-transfer-encoding:content-transfer-encoding;
bh=/HfDmifvLEGL+myxWzfdruEc+v2HKRtI9dyoUcoziAo=;
b=A4rRvO5m79mqYdz9HC3L0AfX6r5hd4GUxT5gZ1Jlbs60+bs6S605HA6u6OK2X3VMfmX1vy
bUsIG42Wj0iwM+HLWXZdic7iqjh9A9sLcnV5RwDhEI4hUwBVfDK4QaUAG/GxkvxG9IbSV1
7TyKPygrLo42Prt9fL9CueuGRXEopcE=
Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com
[209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS
(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id
us-mta-550-OhLJSILZNYCztVeRagbc4Q-1; Mon, 15 May 2023 07:40:46 -0400
X-MC-Unique: OhLJSILZNYCztVeRagbc4Q-1
Received: by mail-qv1-f70.google.com with SMTP id
6a1803df08f44-61b1dbdb2f9so170812946d6.3
for <linux-kernel@vger.kernel.org>;
Mon, 15 May 2023 04:40:46 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20221208; t=1684150846; x=1686742846;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=/HfDmifvLEGL+myxWzfdruEc+v2HKRtI9dyoUcoziAo=;
b=CW+wvDewTvg4lDk7BI/JPbAzIUmKngWD8if+qBqGc5PqJ5cOrfBqzG+wc9ECyQTCIM
J/5k4hvEGEVfvr5c12Dhcx8EoAk5m1Tl8h+gl1GYyYjJd86EFF0M/8e0/pUhhW3aSNNP
SsniJr9K4+Ym0ZpIscwmuX/TX6gFLsmhKo+JDNxLJ0toOHIfPgQFbh5u4xaiBvh8SGXJ
ptL0ALT4Y/OMuWLi6ptApP+GjjxcJmakJhX62MNsCbyBgL0SkpDNxO7giK1UiV6cJto4
z3GA325K9pNZTdeYZ2iiMFVMAZda8m/PBk/9VdT2TSzb4ODWy1SZpbpf6mkwt8CLcmzj
yVdg==
X-Gm-Message-State: AC+VfDz1QEtRMdPRMIIGQ79b4pB9sIluCe3WRs9I9//oi2y/UWvMmtN6
QmJFKL0+4H5VzZbJbmDwc6/U3qClh+vsoXvOrj3xp0IG4+sUN/RLm93kP0WnvcC+or0qbTHq5+k
ok8TgJmsV7yu/rtXzvRg2rf9j9Bb0/PQR
X-Received: by 2002:a05:6214:1304:b0:616:5a74:4577 with SMTP id
pn4-20020a056214130400b006165a744577mr54341298qvb.11.1684150846151;
Mon, 15 May 2023 04:40:46 -0700 (PDT)
X-Received: by 2002:a05:6214:1304:b0:616:5a74:4577 with SMTP id
pn4-20020a056214130400b006165a744577mr54341271qvb.11.1684150845813;
Mon, 15 May 2023 04:40:45 -0700 (PDT)
Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com
(nat-pool-bos-t.redhat.com. [66.187.233.206])
by smtp.gmail.com with ESMTPSA id
s29-20020a05621412dd00b0061693e61dbfsm4794108qvv.63.2023.05.15.04.40.44
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 15 May 2023 04:40:45 -0700 (PDT)
From: Tom Rix <trix@redhat.com>
To: bryan.odonoghue@linaro.org, linux@roeck-us.net,
heikki.krogerus@linux.intel.com, agross@kernel.org,
andersson@kernel.org, konrad.dybcio@linaro.org,
gregkh@linuxfoundation.org
Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, Tom Rix <trix@redhat.com>
Subject: [PATCH] usb: typec: qcom: set pm8150b_typec_res
storage-class-specifier to static
Date: Mon, 15 May 2023 07:40:43 -0400
Message-Id: <20230515114043.3452010-1-trix@redhat.com>
X-Mailer: git-send-email 2.27.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1765961543112801466?=
X-GMAIL-MSGID: =?utf-8?q?1765961813151695583?=
|
| Series |
usb: typec: qcom: set pm8150b_typec_res storage-class-specifier to static
|
|
Commit Message
Tom Rix
May 15, 2023, 11:40 a.m. UTC
smatch reports
drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c:323:29: warning: symbol
'pm8150b_typec_res' was not declared. Should it be static?
This variable is only used in its defining file, so it should be static
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Mon, May 15, 2023 at 07:40:43AM -0400, Tom Rix wrote: > smatch reports > drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c:323:29: warning: symbol > 'pm8150b_typec_res' was not declared. Should it be static? > > This variable is only used in its defining file, so it should be static > > Signed-off-by: Tom Rix <trix@redhat.com> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c > index 191458ce4a06..937e855a6c4c 100644 > --- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c > +++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c > @@ -320,7 +320,7 @@ static struct pmic_typec_port_resources pm8150b_port_res = { > .nr_irqs = 7, > }; > > -struct pmic_typec_resources pm8150b_typec_res = { > +static struct pmic_typec_resources pm8150b_typec_res = { > .pdphy_res = &pm8150b_pdphy_res, > .port_res = &pm8150b_port_res, > };
On Mon, May 15, 2023 at 07:40:43AM -0400, Tom Rix wrote: > smatch reports > drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c:323:29: warning: symbol > 'pm8150b_typec_res' was not declared. Should it be static? > > This variable is only used in its defining file, so it should be static > > Signed-off-by: Tom Rix <trix@redhat.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> Guenter > --- > drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c > index 191458ce4a06..937e855a6c4c 100644 > --- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c > +++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c > @@ -320,7 +320,7 @@ static struct pmic_typec_port_resources pm8150b_port_res = { > .nr_irqs = 7, > }; > > -struct pmic_typec_resources pm8150b_typec_res = { > +static struct pmic_typec_resources pm8150b_typec_res = { > .pdphy_res = &pm8150b_pdphy_res, > .port_res = &pm8150b_port_res, > }; > -- > 2.27.0 >
diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c index 191458ce4a06..937e855a6c4c 100644 --- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c +++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c @@ -320,7 +320,7 @@ static struct pmic_typec_port_resources pm8150b_port_res = { .nr_irqs = 7, }; -struct pmic_typec_resources pm8150b_typec_res = { +static struct pmic_typec_resources pm8150b_typec_res = { .pdphy_res = &pm8150b_pdphy_res, .port_res = &pm8150b_port_res, };