From patchwork Sun May 14 15:27:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 93712 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp6367825vqo; Sun, 14 May 2023 08:29:25 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6FGI0KHBftMi3sPAuodHBaqK5epc1aC2d2kGpLMAJmvIcCCBk6pHL/BtRyDHCJh6UuBl4D X-Received: by 2002:a05:6a20:728d:b0:100:47a5:d754 with SMTP id o13-20020a056a20728d00b0010047a5d754mr33050817pzk.23.1684078164908; Sun, 14 May 2023 08:29:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684078164; cv=none; d=google.com; s=arc-20160816; b=od22cj9ocgmUk6GrZnE/LLEqDvW77ulKZqvQP9xWdYKf/MXyXfqwe8CxF8ofNxoHhj 6ZijsnHpwHBt5fLIIZpFkyMIrMZbm1jNIxbDQTtlTu6rKW7cCZXxiI6HXrS6kTy4J5nv tGm0N6hAngjxlJht0b+ak9BSXNQzBVI2RuV8rg3v/vZUawcVSni/HZaijKLXS9l8kxeu m5Ofjb0jUWXo53RrlHYlAQrUidjwW+ncJAYMc24UvbptTOM5aH1y5bGDJO6BfHEMyd6o 2BHLpRZoUcivXL6CUnrK54wi7Exjs3dwaLGXNzfnW58JzLm20V7CYXicXaFUUJ+M3axT c06Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=bVsZUKH2Xm294GM9wSy02Sv4nssmzINu+HF8I3TDtiI=; b=vouEapRwtYXtUH5GcHcvGnpw0BHxh6YG/vnonN/4VkwNU2jghrzGYFAktCukJXqJl+ h/+u4MaH7dY8uK30bhA2f+mYTDTvwzb230koFcXJHAWcYPgVyugaMHsrX8Jdi0bxd/ru 6U29t9TvtZ/0hTciIvt+4nxBSJHt/KRTObsYZpPubvEx+yxCaBYgJgOq/mAAptkQ8ZvS 2a5eGg6u+ByEkfzXiyuGEzz3gy13a7iBdU9WamJ/0SIJIms2XxNI0v37OwJrRmdpsoYc q/G77tU1nCOX54r+kbGQJfQFnmh38LtAI8NgKTXTIpC+Tl9PX+vJcVy74S9mX8+H3TeB W9/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=S7QqEpCF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f6-20020a17090ab94600b002528f697d12si8830876pjw.160.2023.05.14.08.29.09; Sun, 14 May 2023 08:29:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=S7QqEpCF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237407AbjENP16 (ORCPT + 99 others); Sun, 14 May 2023 11:27:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236997AbjENP1w (ORCPT ); Sun, 14 May 2023 11:27:52 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5BDD2699; Sun, 14 May 2023 08:27:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 67EB060B77; Sun, 14 May 2023 15:27:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1EA72C433D2; Sun, 14 May 2023 15:27:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684078070; bh=2aCCAYUy59MXOZb6fuub05KBE88TJEBAi9SnqqDDSg4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=S7QqEpCFoeRZNqOrnfzeQLpYQFTQqTbmg0ZL1Wdwm5oP3pJDCkXD4guB3pYWZGNmZ dXL14oLeKDMgLG3XnjD+0m1KIgLuaSSCWu7bOqMZD0/v32wuAFuePSQXud3HTyUWWV Vyt8NYGMTC5WMw3sVimQpSXXjI5kGPOStRcaGPFMJOUbf+MfMbfr4NOi0mp8eZpXEr Txf6alqZV0Fbg5XpbGubbBZ7M9HVD+h08VF6cG9550F1yKEDjgQKWxzIFGHbbEPsm6 JVXgODJhXxd0npI3D/PC0NF/ty/j2KrFUAVAs7/3JS6c/YE7KYQ0bx+bz0/z7o7CRg ZELtmr30R3TSA== From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Nathan Chancellor , Nick Desaulniers , Nicolas Pitre , Nicolas Schier , Masahiro Yamada Subject: [PATCH v5 02/21] modpost: remove fromsym info in __ex_table section mismatch warning Date: Mon, 15 May 2023 00:27:20 +0900 Message-Id: <20230514152739.962109-3-masahiroy@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230514152739.962109-1-masahiroy@kernel.org> References: <20230514152739.962109-1-masahiroy@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1765883945704583275?= X-GMAIL-MSGID: =?utf-8?q?1765883945704583275?= report_extable_warnings() prints "from" in a pretty form, but we know it is always located in the __ex_table section, i.e. a collection of struct exception_table_entry. It is very likely to fail to get the symbol name and ends up with meaningless message: ... in reference from the (unknown reference) (unknown) to ... Signed-off-by: Masahiro Yamada --- scripts/mod/modpost.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index ba4577aa4f1d..bbe066f7adbc 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -1297,23 +1297,16 @@ static void report_extable_warnings(const char* modname, struct elf_info* elf, Elf_Rela* r, Elf_Sym* sym, const char* fromsec, const char* tosec) { - Elf_Sym* fromsym = find_elf_symbol2(elf, r->r_offset, fromsec); - const char* fromsym_name = sym_name(elf, fromsym); Elf_Sym* tosym = find_elf_symbol(elf, r->r_addend, sym); const char* tosym_name = sym_name(elf, tosym); - const char* from_pretty_name; - const char* from_pretty_name_p; const char* to_pretty_name; const char* to_pretty_name_p; - get_pretty_name(is_function(fromsym), - &from_pretty_name, &from_pretty_name_p); get_pretty_name(is_function(tosym), &to_pretty_name, &to_pretty_name_p); - warn("%s(%s+0x%lx): Section mismatch in reference from the %s %s%s to the %s %s:%s%s\n", - modname, fromsec, (long)r->r_offset, from_pretty_name, - fromsym_name, from_pretty_name_p, + warn("%s(%s+0x%lx): Section mismatch in reference to the %s %s:%s%s\n", + modname, fromsec, (long)r->r_offset, to_pretty_name, tosec, tosym_name, to_pretty_name_p); if (!match(tosec, mismatch->bad_tosec) &&