From patchwork Sat May 13 04:31:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 93476 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp5566728vqo; Fri, 12 May 2023 22:06:32 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4Pj3em+TN9TMc02X8Ngn8PrDvzRonUUuLvTt8O+cceZHJyfxYR4FkPP69wqLhX1Ts25kfI X-Received: by 2002:a17:903:1248:b0:1ab:224b:d1fc with SMTP id u8-20020a170903124800b001ab224bd1fcmr35554025plh.41.1683954392097; Fri, 12 May 2023 22:06:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683954392; cv=none; d=google.com; s=arc-20160816; b=YVTnt8g7md8Bzkpj/VgnCWRBrA9zWmO5Znze0ey0q954oNOFpuGc8sXeJnECoxUYDG mn5tvyvobeDfQdMzl6ZKvs1oEBVT1EIeWcK3F83MSU2K4KMJD535U/dtWe4sQ9fnMwY1 sJfizd2EGTpcrcvOK9zMH9ExvycJBpMYza+vv7HsLNUA0JLJgdfcvleDOsB7RbvCLimH eWFvVbjNybD0+ff7VJxAeSnqbASHU7GFvVhmKDjkQMHJnSz/EjhRiaolXsANL1h7pBqW gCJtnY5q9ywOgs07lefNprSQO4TOaO/WQaKR+iEteAzFamFXp4DxBiHLCUW+rBIRb6Ut rahg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=9Xg26FQraBSMG0MMhYiyu1iEgUv/WTNcURfydXNCXls=; b=He4bSRBETq1MPlh/egzGfimNAD81WMQkCqPIF6vXUqc7wi+eV3p/huoq70+aSLnJql Pf/n0tEKeflWznhMV1cL1B5hRdE7U/j9s/TIyrrDjiGu03vTyeeoODiIedAWheN/tVK9 V2PR5LzVuB3qZbLgt1vpET127G3wVxi6PSF0UVwcRJil4n+5taBy5kf/+dvdCqAbBJ39 FWHKCWCXXNiYaRGVopRzmaNAcv/tIcFdurZilp6QmxfujIBvPhZqR6t1A3JUCnY0vZEd a77Yn6/7CXFJFaHtCOyEN5mLc87jEJ6qIVpiDBuI7/O3YLn0p6cwywhiny9jV1JC8xCD 8cTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=yyvAvDUn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q2-20020a63bc02000000b00528d0d8b7bbsi10837167pge.595.2023.05.12.22.06.01; Fri, 12 May 2023 22:06:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=yyvAvDUn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229921AbjEMEbT (ORCPT + 99 others); Sat, 13 May 2023 00:31:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229449AbjEMEbR (ORCPT ); Sat, 13 May 2023 00:31:17 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 289EE3C2F for ; Fri, 12 May 2023 21:31:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=9Xg26FQraBSMG0MMhYiyu1iEgUv/WTNcURfydXNCXls=; b=yyvAvDUnQwz+z6Jd01AOxRwYei dzNu/pifelAdEo9rFqWbACBBGKEOjIYJDPjfkun8QvrGkTqjVS3Y0WHi3T6SzW0MS5aBYvoIzlXAJ QwWGXL5tjTi+Fa+UGyqLGwvK1tqDWa3ocBdD0gySJ8d5yQnDfsseQ7ZW0HruckgIXdJ0fd7PWn6nK ZK7T080AE5xU3UU8URTFjM23LviQAAWrXN4v3HW47dvrGlXUzugnAUH+H8o1hteyt8W+hmq/Ib1I0 xrvBtvr17xaCXAqLrzTZgbJl+kofq+h8hhpHLOny5ltAOoCsFt5oOZG2o1g/e1duLCqB4WUzZXKYP 2wuEiTaA==; Received: from [2601:1c2:980:9ec0::2764] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1pxguW-00Degk-1M; Sat, 13 May 2023 04:31:14 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Michael Ellerman , Nicholas Piggin , Christophe Leroy , linuxppc-dev@lists.ozlabs.org Subject: [PATCH v2] powerpc/embedded6xx: select MPC10X_BRIDGE only if PCI is set Date: Fri, 12 May 2023 21:31:11 -0700 Message-Id: <20230513043111.10550-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1765754160782812497?= X-GMAIL-MSGID: =?utf-8?q?1765754160782812497?= When CONFIG_SMP is not set, CONFIG_BROKEN_ON_SMP is set, and CONFIG_PCI is not set, there can be a kconfig warning: WARNING: unmet direct dependencies detected for PPC_INDIRECT_PCI Depends on [n]: PCI [=n] Selected by [y]: - MPC10X_BRIDGE [=y] To fix that, make the selects of MPC10X_BRIDGE be conditional on PCI and use "imply" instead of "select". Signed-off-by: Randy Dunlap Cc: Michael Ellerman Cc: Nicholas Piggin Cc: Christophe Leroy Cc: linuxppc-dev@lists.ozlabs.org Suggested-by: Michael Ellerman # use "imply" --- v2: use imply instead of select (mpe) arch/powerpc/platforms/embedded6xx/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -- a/arch/powerpc/platforms/embedded6xx/Kconfig b/arch/powerpc/platforms/embedded6xx/Kconfig --- a/arch/powerpc/platforms/embedded6xx/Kconfig +++ b/arch/powerpc/platforms/embedded6xx/Kconfig @@ -10,7 +10,7 @@ config LINKSTATION select FSL_SOC select PPC_UDBG_16550 if SERIAL_8250 select DEFAULT_UIMAGE - select MPC10X_BRIDGE + imply MPC10X_BRIDGE if PCI help Select LINKSTATION if configuring for one of PPC- (MPC8241) based NAS systems from Buffalo Technology. So far only @@ -24,7 +24,7 @@ config STORCENTER select MPIC select FSL_SOC select PPC_UDBG_16550 if SERIAL_8250 - select MPC10X_BRIDGE + imply MPC10X_BRIDGE if PCI help Select STORCENTER if configuring for the iomega StorCenter with an 8241 CPU in it.