From patchwork Sat May 13 00:35:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Christopherson X-Patchwork-Id: 93461 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp5486874vqo; Fri, 12 May 2023 17:57:37 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5qN0rqEIQ3jR18l5A51jQFJY3XzcOcQoLkb3wioBsh/cMpEZ7V0mjHkbewxnVpC312yWGv X-Received: by 2002:a05:6a20:1445:b0:f3:b7:b10a with SMTP id a5-20020a056a20144500b000f300b7b10amr33679853pzi.15.1683939456847; Fri, 12 May 2023 17:57:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683939456; cv=none; d=google.com; s=arc-20160816; b=t/ECewmTWW7Gb9RHfWK8uYQ2wO97SAGUxeSYHBkRFCdwX5v9pf5XEwTVXfSu/AMKi4 tDmJ0F3ue4Tcgxu0NK7KLDhpbMU4iujsTiABbIx81j1FlbhRy07DnJoappaDJWb4D+MR 5dDFckXgbSQIoHle394X2KXtjI6vCu1fr3JhzweQ/WNPQ//1Py7Y8Fe46QCRCuCkOy4Y Tyo5Q/aqcFi7k/kOVafJh0hocoeUGuGyGbtEJdP4yk0N+iAtmA/zwRelJyz/WoPxisK7 4TREfTWffhMEBC/aZ1gyLYWH5M1mtpT5FkKc3SOcmlUJB4NgM7VjW+84K/cyquUXlHGD wFYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:reply-to:dkim-signature; bh=xOh8270aHmhQkt9lEUjS49SPgiz7MiCgITarxX9E6A4=; b=C7uLUiDpXxbvouJ4XY+jHaQb4ja1eN0cYC3gLs1VpI1ZICAmvRUij+4Q67H8/Zgdh9 Zv3UmAnzuukWGQ/5/1lu1zA4YAwAfeBX9BnKBJmLPrZyLMAv/I++iwmZpL0rK+QCWj2e R1m5ddTq0FQu7Gn6utmIj/ApmCTVxTVcFJvqXX5h3jbWWSTJcaBniWj4y+9jTkGdk+6s fwcCIiZdvx+dyUW9IT2GSc44dXFRnJPBAbE4Ii3GEQec2fUwCqwKV4UIExR15EXPmfCd gxQZMCPXhVbFY7OB3y4xihiPB7iLB+P3o+bQ4d094kyylIhmIB6f9rHMf0O3kd2Ff9TU cXqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=0jqUD1zj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e5-20020a63aa05000000b00528595a1390si10882248pgf.588.2023.05.12.17.57.21; Fri, 12 May 2023 17:57:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=0jqUD1zj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241505AbjEMAgs (ORCPT + 99 others); Fri, 12 May 2023 20:36:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241506AbjEMAgb (ORCPT ); Fri, 12 May 2023 20:36:31 -0400 Received: from mail-pf1-x44a.google.com (mail-pf1-x44a.google.com [IPv6:2607:f8b0:4864:20::44a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE80C7695 for ; Fri, 12 May 2023 17:36:22 -0700 (PDT) Received: by mail-pf1-x44a.google.com with SMTP id d2e1a72fcca58-6435b851de0so6328262b3a.0 for ; Fri, 12 May 2023 17:36:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1683938182; x=1686530182; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=xOh8270aHmhQkt9lEUjS49SPgiz7MiCgITarxX9E6A4=; b=0jqUD1zjEi55ZfhAIwMWNWENT9MRrpNqKPwfQ1O+9RvhBF4O2kdCyXExTphM2+/m9k /jnyyeFCDa3H2au4xyKDmwQ25q0BQadY/AQ5keaYUsgrQKFeyRVTbA64tAv2mHUVd79F MA1woP6wnOSriWMc3ixbrjlmsjIvDoDt2FMBhOh/vWdW0IYpXN+YySWq8QleQOn1OCNY zaA45ZWqVu8O+rYagST5vwdnd2n7ifjmb0xsLWIRl0HT3SzfiTn9LZMpvRUt0vUY023R scxbCiPEhmmQYIdSQSSJVaEk7yZ8fAWjNetppIAeHmtlBBJ2ncdcrr67LCrk49c7ptKV AVOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683938182; x=1686530182; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xOh8270aHmhQkt9lEUjS49SPgiz7MiCgITarxX9E6A4=; b=fZHd/ObjIEO+GxwkJ7XrOAYmvCPLfAUUcP2s4dW6+AkFGNG4kqJ5L41VgMIhZDGwNx 06VsI2hUGWLUYYCEr8kBtnVIHaJ3YmHfSXLPcSbPO8HMPLjIlxjJCHQCMYG2Hdq7yQTO 1G4npL7S53D2ap4f0Tz3D4XamDIofQ6T3dII305rXWLSG3koqu6mRV7LSG8ctt0DlSZj c9A5AVSxRijJA8tqpyzN7k2d/XtqgxUhT64AggdiEtlxSZgjD1AdPx+laK/kaTwszvu5 yYY52xHiA9BVT/e+0vXrKTAM5P8vewwDtf9mIHYNAwKb1DTfWfcKEUF4lEvaPjQR5J0z ZOwg== X-Gm-Message-State: AC+VfDxCNGgo+Rf909Qr5V4CK9HzerHBKHD4+NNv299eipqQJzWz9NyF fps+bfS904Tf8n8e5/G2ezOe9Tq+k94= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6a00:1790:b0:64a:f4ac:3433 with SMTP id s16-20020a056a00179000b0064af4ac3433mr565273pfg.6.1683938181992; Fri, 12 May 2023 17:36:21 -0700 (PDT) Reply-To: Sean Christopherson Date: Fri, 12 May 2023 17:35:40 -0700 In-Reply-To: <20230513003600.818142-1-seanjc@google.com> Mime-Version: 1.0 References: <20230513003600.818142-1-seanjc@google.com> X-Mailer: git-send-email 2.40.1.606.ga4b1b128d6-goog Message-ID: <20230513003600.818142-9-seanjc@google.com> Subject: [PATCH v3 08/28] drm/i915/gvt: Use an "unsigned long" to iterate over memslot gfns From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini , Zhenyu Wang , Zhi Wang Cc: kvm@vger.kernel.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yan Zhao , Ben Gardon X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1765738499731311741?= X-GMAIL-MSGID: =?utf-8?q?1765738499731311741?= Use an "unsigned long" instead of an "int" when iterating over the gfns in a memslot. The number of pages in the memslot is tracked as an "unsigned long", e.g. KVMGT could theoretically break if a KVM memslot larger than 16TiB were deleted (2^32 * 4KiB). Reviewed-by: Yan Zhao Signed-off-by: Sean Christopherson --- drivers/gpu/drm/i915/gvt/kvmgt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c index 92ceefe1e6fb..117bac85ac2c 100644 --- a/drivers/gpu/drm/i915/gvt/kvmgt.c +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c @@ -1619,7 +1619,7 @@ static void kvmgt_page_track_flush_slot(struct kvm *kvm, struct kvm_memory_slot *slot, struct kvm_page_track_notifier_node *node) { - int i; + unsigned long i; gfn_t gfn; struct intel_vgpu *info = container_of(node, struct intel_vgpu, track_node);