From patchwork Sat May 13 00:35:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Christopherson X-Patchwork-Id: 93444 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp5480289vqo; Fri, 12 May 2023 17:37:22 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ70ZnReDeO4ulDovYURCWzgO+1GpHL/exTTvTfw0KcYFD6Gvpq9NF36J0O8eLZRuYg3J/iJ X-Received: by 2002:a17:902:c412:b0:1ab:25a6:a54b with SMTP id k18-20020a170902c41200b001ab25a6a54bmr35335405plk.4.1683938241871; Fri, 12 May 2023 17:37:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683938241; cv=none; d=google.com; s=arc-20160816; b=P/YAmkW3pbcfyfSDYIZbL0sDYkCzY/MTfnt3UVx4R8xpRoHqyMLia3wt62c1798ofl I3V2NNgLU4zRhrsVtSNKUjTjEZTC2cU/P5EH9wpvbrCc/XGvquqRDIB/PrfSxchABmMi i5TmwNeGJNhI5iQgKSqwRYVzxziGpf4tUcFuicztcB6oRmAeu3C+aIcXxWRRrhszFDZH 2zLLAy47AkAwZjP+Xvfm3VpnCtfXJHG7B5geWJXXwg2xNs4B2EWGp2SMSZwf2QdYUktH igL5NcbnBSEu0s7tMh5IWLUckniv8PChvq1OFiRZjA98BLk/QAUeiZ+lCVVi9uHgNzeG Z5sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:reply-to:dkim-signature; bh=imcOaGkZAhtv0KvByjHYg/L+5O3EycYmRlnN5iZFB4Y=; b=geIgVVVSmS9iK1H8M7/Gl50zxZl3eVTcluu97iDkOXo8LgZpugTmXMkefLw7JkDry7 fBw0TYWP5kHFf3XG7SCrQeqRODZ9bcS//GuLgyxBdvMNzpEoG15r4iDFEGSTtgOpbEVF CSOxx5W1Z/wYYzRX7zrhYjR7xUvF3Fde9Hu2yoqb7zfzynT6HHx3DhYVSX1fJPLPW1yo I78H1YTDWsoMihCxsWaGXssM+azHYaKfz0tnbNYuEvmRk8amtTQqX7+q3oAb1CoxDpil lIIZCmSMUQLpnNl7mk6AyOvtJiDWJJh8ifR7Bod058P3HOfN00Gjn1m5KTDhaM1VbTOi nDYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=U5+Q5AXJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f11-20020a170902ab8b00b001ab1a00d95dsi9760834plr.250.2023.05.12.17.37.09; Fri, 12 May 2023 17:37:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=U5+Q5AXJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241016AbjEMAgN (ORCPT + 99 others); Fri, 12 May 2023 20:36:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240890AbjEMAgJ (ORCPT ); Fri, 12 May 2023 20:36:09 -0400 Received: from mail-pf1-x449.google.com (mail-pf1-x449.google.com [IPv6:2607:f8b0:4864:20::449]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FE864EFE for ; Fri, 12 May 2023 17:36:08 -0700 (PDT) Received: by mail-pf1-x449.google.com with SMTP id d2e1a72fcca58-643a9203dc2so5890873b3a.1 for ; Fri, 12 May 2023 17:36:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1683938167; x=1686530167; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=imcOaGkZAhtv0KvByjHYg/L+5O3EycYmRlnN5iZFB4Y=; b=U5+Q5AXJHkAU35wpnGLBPjphoKZTaHkEJDuj5UMIwyqKaq6mJuEU/6neP+0/SWCsb5 NFesLARPQGcYZENv7TNTcjy4a5Rawvaq1zSQzjqS85yJCnvRPjQNxUoYKjrUwmWdAwRl ferixHNQ08N4q/G3XE/ZSOUCDOrmMzXMiJzZDM+uJRNzJMQEjPTlaPWvDzhYvfXzI/FM YtLSzbNzKOyKXXtQuh/Ucl+SagOra0HjqcetFJbXHnwTDK4FzH1iQX/RH1iIvX2IqiM+ 9ggCnY4bYnmh0gVz5Qa+0Nmsu8298HQZMepAoUQTXTaxZ/VoMcpUt+FH6CaI+e7WDf7O 4tuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683938167; x=1686530167; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=imcOaGkZAhtv0KvByjHYg/L+5O3EycYmRlnN5iZFB4Y=; b=XNkBMYTZcn7jBeUrfWnqZJmZVwgSKORM8VVasNgAjGWkW0/Y9oFwoFHTRVDEgmdsW6 iiXw6LkN/EsPN0m2dKxPB7WfTsZNp3E9/H9cG0JkOP+qbzUW45FCTF+NGZ3yKsPQt/fe WzLR4XghsWOh3zqtgXHUvK/NsCzmx2YsqWowkFK4GZVAtRaU0JX7Q52y8HShx6vc1tK9 d7Vl/tUMUz70+9ccIjp1Z9Grawv3p3a7VmVM8Hf2IQlb6fqN4R+s2ZZNiY5EOQaC0hpa zY6WdUyvA0zeTWOHjHABlrCd/gwTtTVecsB667VkpLfCwWwdogGXMQOI6ZklgrY0SzLJ CbcA== X-Gm-Message-State: AC+VfDxDTAm901SDiy/HavulE0QLLfFDQPcX2ISOiquP3SreQ4WaAUj3 +ro14UIkzF7FT6pDX53oznXxIB97vlY= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6a00:d5a:b0:643:536b:e764 with SMTP id n26-20020a056a000d5a00b00643536be764mr7181559pfv.4.1683938167743; Fri, 12 May 2023 17:36:07 -0700 (PDT) Reply-To: Sean Christopherson Date: Fri, 12 May 2023 17:35:33 -0700 In-Reply-To: <20230513003600.818142-1-seanjc@google.com> Mime-Version: 1.0 References: <20230513003600.818142-1-seanjc@google.com> X-Mailer: git-send-email 2.40.1.606.ga4b1b128d6-goog Message-ID: <20230513003600.818142-2-seanjc@google.com> Subject: [PATCH v3 01/28] drm/i915/gvt: Verify pfn is "valid" before dereferencing "struct page" From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini , Zhenyu Wang , Zhi Wang Cc: kvm@vger.kernel.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yan Zhao , Ben Gardon X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1765737225832138769?= X-GMAIL-MSGID: =?utf-8?q?1765737225832138769?= Check that the pfn found by gfn_to_pfn() is actually backed by "struct page" memory prior to retrieving and dereferencing the page. KVM supports backing guest memory with VM_PFNMAP, VM_IO, etc., and so there is no guarantee the pfn returned by gfn_to_pfn() has an associated "struct page". Fixes: b901b252b6cf ("drm/i915/gvt: Add 2M huge gtt support") Reviewed-by: Yan Zhao Signed-off-by: Sean Christopherson --- drivers/gpu/drm/i915/gvt/gtt.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gtt.c index 4ec85308379a..58b9b316ae46 100644 --- a/drivers/gpu/drm/i915/gvt/gtt.c +++ b/drivers/gpu/drm/i915/gvt/gtt.c @@ -1183,6 +1183,10 @@ static int is_2MB_gtt_possible(struct intel_vgpu *vgpu, pfn = gfn_to_pfn(vgpu->vfio_device.kvm, ops->get_pfn(entry)); if (is_error_noslot_pfn(pfn)) return -EINVAL; + + if (!pfn_valid(pfn)) + return -EINVAL; + return PageTransHuge(pfn_to_page(pfn)); }