diff mbox series

[3/3] arm64: defconfig: enable J721e PCIe controller

Message ID 20230512070510.1873171-4-a-verma1@ti.com
State New
Headers
Series Add support to build pci-j721e as a kernel module |

Commit Message

Achal Verma May 12, 2023, 7:05 a.m. UTC 
  Enable Cadence PCIe controller and pci-j721e drivers to be built as
kernel modules.

Signed-off-by: Achal Verma <a-verma1@ti.com>
---
 arch/arm64/configs/defconfig | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Krzysztof Kozlowski May 12, 2023, 7:23 a.m. UTC | #1 
On 12/05/2023 09:05, Achal Verma wrote:
> Enable Cadence PCIe controller and pci-j721e drivers to be built as
> kernel modules.

Why? IOW, who needs them. Please provide rationale in the commit msg. I
am pretty sure I asked for this...


Best regards,
Krzysztof
Achal Verma May 13, 2023, 5:58 p.m. UTC | #2 
Hello Krzysztof,
On 5/12/2023 12:53 PM, Krzysztof Kozlowski wrote:
> On 12/05/2023 09:05, Achal Verma wrote:
>> Enable Cadence PCIe controller and pci-j721e drivers to be built as
>> kernel modules.
> 
> Why? IOW, who needs them. Please provide rationale in the commit msg. I
> am pretty sure I asked for this...
> 
On TI's J7 SOCs, PCIe is composed of PCIe core from Cadence and TI 
wrapper. It is desired to have J7 PCIe working on upstream kernel by 
default. So to enable this I have pushed these defconfig changes.

BTW, I am planning to hold this change until PCIe code changes (rest of 
the patches in this series) gets merged.

Please let me know if there are more concern to this.
Sorry, for this time.

Thanks,
Achal Verma
> 
> Best regards,
> Krzysztof
>
Krzysztof Kozlowski May 13, 2023, 6:39 p.m. UTC | #3 
On 13/05/2023 19:58, Verma, Achal wrote:
> 
> Hello Krzysztof,
> On 5/12/2023 12:53 PM, Krzysztof Kozlowski wrote:
>> On 12/05/2023 09:05, Achal Verma wrote:
>>> Enable Cadence PCIe controller and pci-j721e drivers to be built as
>>> kernel modules.
>>
>> Why? IOW, who needs them. Please provide rationale in the commit msg. I
>> am pretty sure I asked for this...
>>
> On TI's J7 SOCs, PCIe is composed of PCIe core from Cadence and TI 
> wrapper. It is desired to have J7 PCIe working on upstream kernel by 
> default. So to enable this I have pushed these defconfig changes.
> 
> BTW, I am planning to hold this change until PCIe code changes (rest of 
> the patches in this series) gets merged.
> 
> Please let me know if there are more concern to this.

The concerns are that commit msg does not explain this. Please always
provide in commit msg answer to "why you are doing this". In case of
defconfig the answer to "why" is: "board foo bar with SoC baz uses it".

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index a24609e14d50..a4cf973e0aaa 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -230,9 +230,16 @@  CONFIG_PCIE_HISI_STB=y
 CONFIG_PCIE_TEGRA194_HOST=m
 CONFIG_PCIE_VISCONTI_HOST=y
 CONFIG_PCIE_LAYERSCAPE_GEN4=y
+CONFIG_PCIE_CADENCE=m
+CONFIG_PCIE_CADENCE_HOST=m
+CONFIG_PCIE_CADENCE_EP=m
+CONFIG_PCI_J721E=m
+CONFIG_PCI_J721E_HOST=m
+CONFIG_PCI_J721E_EP=m
 CONFIG_PCI_ENDPOINT=y
 CONFIG_PCI_ENDPOINT_CONFIGFS=y
 CONFIG_PCI_EPF_TEST=m
+CONFIG_PCI_EPF_NTB=m
 CONFIG_DEVTMPFS=y
 CONFIG_DEVTMPFS_MOUNT=y
 CONFIG_FW_LOADER_USER_HELPER=y