From patchwork Thu May 11 13:21:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ryan Roberts X-Patchwork-Id: 92585 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp4371219vqo; Thu, 11 May 2023 06:28:10 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5S3tRJFiR7lPClY9x24Kyz2QPNEQsUBjja/fVlFDXuc33AXbrmmLuakA6s8OBhWWQgMkuQ X-Received: by 2002:a17:903:1110:b0:1a6:8ed5:428a with SMTP id n16-20020a170903111000b001a68ed5428amr25603178plh.22.1683811689792; Thu, 11 May 2023 06:28:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683811689; cv=none; d=google.com; s=arc-20160816; b=wN+4awCu86westwcbKLDNBM6X+DLEPIxYQktgZMZA6B67AvaRm15udeUHufBWLMFGD sNcTynKCasv7pDG486B5fY4jhl2nyv15COeBoOHxy11kZmIa64i00cna3t0lku7pTPIE m9uCyNlbqH7bwVRts47LTgtK/i5kLW13++bQWgL3IJkk2BdkhXIoK5MTpf8DKRhblx2e hfH3OEOo/CynglIxT4CrfqtzLbfqXJUAcXzrCJKc9R3x9yVJETa7r8wb5BASoHO/5pIq 0n8zXnzv8ewUrAEohXohy+1CjoL3XAqESJjIKzUJl+69ffrFylFLgbjdWArqaVVnNKZv RJ1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=iJTCpwM3C7wRT8X7CgIcIwNcs7Jix29ply3bIuZCJeE=; b=AlDwpzjAdV/BBHMJpAUekGKfskk0YyLZN4pwBlZkJsYQJBCXOnFebW9hxrEJMiq2GW jiCUbimcQwtP6rF4kJSTFBRa2a1LSJgxiu+1GJlenqlCbPkNb0LaJPBcFhGuSr1alASj RCo202qDmrTej9rTwF3LsWDv4kD3RhMsXuNlvWekTwQ+bsPgSU1gn2PVSKfAD+fEnrSX S1ko8zmYFjR1atn9heKM1/eSLPRwhbPyjYeQ2SB1rnVSggbiSjLjUrWFBPidn3OmjNfL 8qpiRwKuKZO+u59CreG1bQ75adSAG5ezCItmBEbYwe7VCwRG5Cp58wmdVrPgmNeA26/Y 2Lig== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j8-20020a17090aeb0800b0024c1ddfa1bfsi20014627pjz.92.2023.05.11.06.27.54; Thu, 11 May 2023 06:28:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238137AbjEKNXe (ORCPT + 99 others); Thu, 11 May 2023 09:23:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238118AbjEKNXP (ORCPT ); Thu, 11 May 2023 09:23:15 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D56A71157A for ; Thu, 11 May 2023 06:21:37 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BA32B165C; Thu, 11 May 2023 06:22:08 -0700 (PDT) Received: from e125769.cambridge.arm.com (e125769.cambridge.arm.com [10.1.196.26]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1F4EA3F5A1; Thu, 11 May 2023 06:21:23 -0700 (PDT) From: Ryan Roberts To: Andrew Morton , "Matthew Wilcox (Oracle)" , "Kirill A. Shutemov" , SeongJae Park Cc: Ryan Roberts , linux-kernel@vger.kernel.org, linux-mm@kvack.org, damon@lists.linux.dev Subject: [RESEND PATCH v1 1/5] mm: vmalloc must set pte via arch code Date: Thu, 11 May 2023 14:21:09 +0100 Message-Id: <20230511132113.80196-2-ryan.roberts@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230511132113.80196-1-ryan.roberts@arm.com> References: <20230511132113.80196-1-ryan.roberts@arm.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1765604526288582739?= X-GMAIL-MSGID: =?utf-8?q?1765604526288582739?= It is bad practice to directly set pte entries within a pte table. Instead all modifications must go through arch-provided helpers such as set_pte_at() to give the arch code visibility and allow it to validate (and potentially modify) the operation. Fixes: 3e9a9e256b1e ("mm: add a vmap_pfn function") Signed-off-by: Ryan Roberts Reviewed-by: Christoph Hellwig Acked-by: Lorenzo Stoakes --- mm/vmalloc.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) -- 2.25.1 diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 9683573f1225..d8d2fe797c55 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -2899,10 +2899,13 @@ struct vmap_pfn_data { static int vmap_pfn_apply(pte_t *pte, unsigned long addr, void *private) { struct vmap_pfn_data *data = private; + pte_t ptent; if (WARN_ON_ONCE(pfn_valid(data->pfns[data->idx]))) return -EINVAL; - *pte = pte_mkspecial(pfn_pte(data->pfns[data->idx++], data->prot)); + + ptent = pte_mkspecial(pfn_pte(data->pfns[data->idx++], data->prot)); + set_pte_at(&init_mm, addr, pte, ptent); return 0; }