From patchwork Wed May 10 07:28:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anna-Maria Behnsen X-Patchwork-Id: 91916 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp3430028vqo; Wed, 10 May 2023 00:31:43 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4s/HoU/c7IeiZj5mkOMMZt+T0jdYd/au5yh7DIN3Z+LBbKasZpfzrqfd3EtFb5BAqVCAk0 X-Received: by 2002:a05:6a20:548a:b0:100:450c:6139 with SMTP id i10-20020a056a20548a00b00100450c6139mr10967453pzk.3.1683703902747; Wed, 10 May 2023 00:31:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683703902; cv=none; d=google.com; s=arc-20160816; b=XPR1tsts3f0kPDk0b9EdOLUqh1vaGA2ZIcNTwxR47g5SZLptGkamM6s4hQydRSaAes OH0uQJOcMbEx2tzlr6GcTVaiQhnkhNCxV0k68HDOyt4IFS/HiA20TMgTCBE1uOS2Dh9N +9iL0I+Nk6V9k1jYYGE29IP0lUhPiSvrnurgjRLU8Fl+jqk9+Piqs/LgLJGBDPw/Sbxc S0r8IJwDlkZE9alghoONXYtCBlFnOK1ZaxlTeKOh0h4vCfzzHKPbSx2/BJgZHNjCLUGf p8zEWsXj5eXgdlCpjr/jCRBsUe2tuyqoF2ptJ38Y3bE0KGqI1N4dah+PZ29nWQodqWmB UHMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:dkim-signature :dkim-signature:from; bh=K9e5Gmxnr1gXDBGeNuKaFQxHbcIQ5VBb6TocWugW/4Y=; b=PfhJddUh+o4w0DVYU7JjzWDzYggk8D3Rxlte2toZziuCm5OI/43jpIXPTGYvnAy9nT 8lvrZ4eifTSF8r96SIUmcZxKFd8QtqEapbNDkVFviKYJsMqU7wg5BwVII+9lVWR4ok1i 08mUOsjjUSKs4flATkz4gpcPKPXqHvVWbvSO1IyW0eyQ06zALlPFkhjeZg7BGtPa01Lz fNWRTeybyGsSwdByl5UH7K6be0GoHNPXLaCQ0RV0XYyiQQWSxS4RyJL1eZOs06l9YIjw KNFGXe2Qr7qAKnT+mFYwtBV080Q/AzhHP0q31xyCR/gtfAxtT8yH00ZZQpeWho2XMmpT p8CA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=MsGQx0Yn; dkim=neutral (no key) header.i=@linutronix.de header.b=qvE78fBh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v16-20020a63b950000000b00519858f0ac3si3428650pgo.157.2023.05.10.00.31.28; Wed, 10 May 2023 00:31:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=MsGQx0Yn; dkim=neutral (no key) header.i=@linutronix.de header.b=qvE78fBh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236349AbjEJH3j (ORCPT + 99 others); Wed, 10 May 2023 03:29:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236019AbjEJH3U (ORCPT ); Wed, 10 May 2023 03:29:20 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0439F76B7 for ; Wed, 10 May 2023 00:28:52 -0700 (PDT) From: Anna-Maria Behnsen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683703720; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K9e5Gmxnr1gXDBGeNuKaFQxHbcIQ5VBb6TocWugW/4Y=; b=MsGQx0Yn3nDgmGDCgRTElTTqZq5ZVBm+O7aBs6cBZdJknN2UAh8Ajtml5XCjiRL37fd9aA mDvQQoTfrX7iNDzNPyK0xRzsyAXIU6hxXY9cYZ/SjNrBdYG5NHaPEvVyvnLgnE6lzsyH+o snjJEoKNWPO5NiCgQ3EIHH/cuTR5G7bmVdpupfGHzHxAi1DlFq3Wjv/FKNMLmTjPzry9V3 lOg7lmtYGf09MkVzfXygW975sZ2AJHWxzR5ESxFRgolceaY1LBecEzprVWZIbHbsnC4PNJ qfl145y85d64c5FC8crX+XBHSvuC2VDKJFBf5or4Vr+5H5lGDLbIYZ79fxy4Xw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683703720; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K9e5Gmxnr1gXDBGeNuKaFQxHbcIQ5VBb6TocWugW/4Y=; b=qvE78fBh2zFxbasIL6LECFfoBK/7Ck0cpmzzkaXxBbikGdZke+zlN3OF2P17nIZTFOQ6A6 w7Op04FsBJ62r3DQ== To: linux-kernel@vger.kernel.org Cc: Peter Zijlstra , John Stultz , Thomas Gleixner , Eric Dumazet , "Rafael J . Wysocki" , Arjan van de Ven , "Paul E . McKenney" , Frederic Weisbecker , Rik van Riel , Steven Rostedt , Sebastian Siewior , Giovanni Gherdovich , Lukasz Luba , "Gautham R . Shenoy" , Anna-Maria Behnsen , Tejun Heo , Lai Jiangshan Subject: [PATCH v6 08/21] workqueue: Use global variant for add_timer() Date: Wed, 10 May 2023 09:28:04 +0200 Message-Id: <20230510072817.116056-9-anna-maria@linutronix.de> In-Reply-To: <20230510072817.116056-1-anna-maria@linutronix.de> References: <20230510072817.116056-1-anna-maria@linutronix.de> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1765491503882906917?= X-GMAIL-MSGID: =?utf-8?q?1765491503882906917?= The implementation of the NOHZ pull at expiry model will change the timer bases per CPU. Timers, that have to expire on a specific CPU, require the TIMER_PINNED flag. If the CPU doesn't matter, the TIMER_PINNED flag must be dropped. This is required for call sites which use the timer alternately as pinned and not pinned timer like workqueues do. Therefore use add_timer_global() to make sure TIMER_PINNED flag is dropped. Signed-off-by: Anna-Maria Behnsen Cc: Tejun Heo Cc: Lai Jiangshan Acked-by: Tejun Heo Reviewed-by: Frederic Weisbecker --- v6: - New patch: As v6 provides unconditially setting TIMER_PINNED flag in add_timer_on() workqueue requires new add_timer_global() variant. --- kernel/workqueue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/workqueue.c b/kernel/workqueue.c index 4666a1a92a31..5c529f19e709 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -1682,7 +1682,7 @@ static void __queue_delayed_work(int cpu, struct workqueue_struct *wq, if (unlikely(cpu != WORK_CPU_UNBOUND)) add_timer_on(timer, cpu); else - add_timer(timer); + add_timer_global(timer); } /**