From patchwork Wed May 10 07:27:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anna-Maria Behnsen X-Patchwork-Id: 91914 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp3429928vqo; Wed, 10 May 2023 00:31:31 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6JARRpCLU2pkmJLp7UuL2PcKWBQH5ZpCXZqE2bIjo4oEIr9et2zEfAUyAZ9I2Z2vlqnrwz X-Received: by 2002:a17:902:d2d1:b0:1a5:2377:c7e7 with SMTP id n17-20020a170902d2d100b001a52377c7e7mr20909113plc.44.1683703891139; Wed, 10 May 2023 00:31:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683703891; cv=none; d=google.com; s=arc-20160816; b=o3NYbD62mqIC/Dip9SEdtl5NdRnIbAWO0E+7Ddwuj09yT1Ys6R5XD4PIotgS1wXfAj hGbHfRKwo5S7d+CxRyTn+RrqMV1eRvR5WIZXzLF9r2qU5ZwtLmijbd8mi1ETF9coXSyp bDXWiqHBSh1iNM1OElzNlzoTW59mJ3pfW2Ppu4IhHsRtzuV3DSMV2JM0+46vGuhzqj2k N80MocKRfCRyWMWvGjeFny9A3WjehFldyf9H+fmTLfEiwGA+29ZEwgswoIoeFw9tz7h/ fE9OjCgz1iIlLh5DEI7sSVTSWSFNPMbYcELLPWVwnVpdB8UZUr/acMJYZwJwCJM0nm2x sENA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:dkim-signature :dkim-signature:from; bh=GmrO3nNzYfXwzb1RvZTjX+af+BCpvVn7WiRHJl4Z/10=; b=Tsf9dflSV89mS8lErWCAjgKHM6r/l+3Ny802h78JPh9GPGQ8NG0rkzCDW3oCcEuI7U 891DNgUqkafMwNrr8ImDT9kXflgGOeBauGEsQuLtvVmjRDlpQPXMVxiHR7xMGdABp/oi AnHXDs/ulmQmXbIGCbvDN0u1sJYBnM+K8PDpsdjhyCjpTpyGLLTJWgRjVW7JROyX1i1g oaAqQ+UOzBRbrxEVH89hzMsHWTnQtAt8SNxRE/jY2DFrQdBI+OcfEj4bdepZeuLLIc/d S4lUizrbD4XXg5xhENcmaKMh7bMmbzNqczdcUor8BYm9ws6Vfcib70NeujFyPi7Q1Tn5 tFxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=mvB7jTUK; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id rj14-20020a17090b3e8e00b002496b783923si14757690pjb.181.2023.05.10.00.31.15; Wed, 10 May 2023 00:31:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=mvB7jTUK; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236016AbjEJH3C (ORCPT + 99 others); Wed, 10 May 2023 03:29:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235893AbjEJH2y (ORCPT ); Wed, 10 May 2023 03:28:54 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C75277ABB for ; Wed, 10 May 2023 00:28:38 -0700 (PDT) From: Anna-Maria Behnsen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683703716; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GmrO3nNzYfXwzb1RvZTjX+af+BCpvVn7WiRHJl4Z/10=; b=mvB7jTUKw6TbLLm/JjP67bf9H1aDe/htU4cLAtTBDVcV8AyNpJnF8naF5oeCUujE1QYyAW 2CB9qg4CK0AZ01fPu3hJLVyZ5v/oKFRl0PDvwk/ymODIMB9y7QxY45dJZ57BVds+u91Rxf BVovJhT7F3uNszu5Qg9IKvLYEx0gz2Va9NTZGKNNMjeANIBfFphB0krM+RzFn0srjgZsyK GxoMtEuvvP1sqdgd25lWWPLbJS9RQVxwd9go+mf5bzBVlOkkOnN15Y/qSio1zbJ/1AjXv5 FaHRuscukbg7VCrhvNC6OdVtOwaFVW8MzuuS6/V3E41lGkO2n/z09QQCWFIqvA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683703716; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GmrO3nNzYfXwzb1RvZTjX+af+BCpvVn7WiRHJl4Z/10=; b=GeXvSHgEdrNVDfMalhmVSusi6PEvIuF42l/5bOphUg+Arq6I5oadIIE7EXPBkYOe78lQJR Fc6ASt1z3n4mAEAw== To: linux-kernel@vger.kernel.org Cc: Peter Zijlstra , John Stultz , Thomas Gleixner , Eric Dumazet , "Rafael J . Wysocki" , Arjan van de Ven , "Paul E . McKenney" , Frederic Weisbecker , Rik van Riel , Steven Rostedt , Sebastian Siewior , Giovanni Gherdovich , Lukasz Luba , "Gautham R . Shenoy" , Anna-Maria Behnsen Subject: [PATCH v6 02/21] timer: Do not IPI for deferrable timers Date: Wed, 10 May 2023 09:27:58 +0200 Message-Id: <20230510072817.116056-3-anna-maria@linutronix.de> In-Reply-To: <20230510072817.116056-1-anna-maria@linutronix.de> References: <20230510072817.116056-1-anna-maria@linutronix.de> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1765491491397829044?= X-GMAIL-MSGID: =?utf-8?q?1765491491397829044?= Deferrable timers do not prevent CPU from going idle and are not taken into account on idle path. Sending an IPI to a remote CPU when a new first deferrable timer was enqueued will wake up the remote CPU and but nothing will be done regarding the deferrable timers. Drop IPI completely when a new first deferrable timer was enqueued. Signed-off-by: Anna-Maria Behnsen --- v6: new patch --- kernel/time/timer.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/kernel/time/timer.c b/kernel/time/timer.c index 63a8ce7177dd..6e251e3cf659 100644 --- a/kernel/time/timer.c +++ b/kernel/time/timer.c @@ -571,18 +571,15 @@ static int calc_wheel_index(unsigned long expires, unsigned long clk, static void trigger_dyntick_cpu(struct timer_base *base, struct timer_list *timer) { - if (!is_timers_nohz_active()) - return; - /* - * TODO: This wants some optimizing similar to the code below, but we - * will do that when we switch from push to pull for deferrable timers. + * Deferrable timers do not prevent CPU from going idle and are not + * taken into account on idle path. An IPI when a new deferrable + * timer is enqueued will wake up the remote CPU but nothing will + * be done with the deferrable timer base. Therefore skip remote + * IPI for deferrable timers completely. */ - if (timer->flags & TIMER_DEFERRABLE) { - if (tick_nohz_full_cpu(base->cpu)) - wake_up_nohz_cpu(base->cpu); + if (!is_timers_nohz_active() || timer->flags & TIMER_DEFERRABLE) return; - } /* * We might have to IPI the remote CPU if the base is idle and the