From patchwork Wed May 10 07:28:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anna-Maria Behnsen X-Patchwork-Id: 91922 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp3431313vqo; Wed, 10 May 2023 00:34:43 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7B0aMXkrTvzI5NCLK0T/mhvgpKtMaPbSi1+Ggfd45VUnf0GkaWYjEdKjOP2T1ePcyzj5nO X-Received: by 2002:a17:902:d48d:b0:1ac:66c4:6071 with SMTP id c13-20020a170902d48d00b001ac66c46071mr16105863plg.57.1683704083056; Wed, 10 May 2023 00:34:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683704083; cv=none; d=google.com; s=arc-20160816; b=is7gBpFRvls0O3VRsdJuFbzlGL/1ZuCGS+xpMqE5O/63wr2fO1SsHqmZTcqd1NnFxm 9WK4PS4tpuGRv7tPlwJtCKJeX2YnKZdWkcHlDppyxq4za/kHpIsF0AdYvF3dQJW8rCXH licyIFGZNhy6+UtUFeQwFVgxcXXKgfsgX2Kig+gmFOmWsiCWg/+fNGztQS+tEAQDXkCb 7TUo5M2ezNerFYmmpS0hIExZ1Uusizbe5hhJz7Us47jBGy6knXZRf6OMPU5uuQp7jKh6 +OJavWxbs7einLPNwS56JGL8hlbfYsztqn6prx1UwZVTCCN+dd0qeR39hENCBTZVZbd4 NMVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:dkim-signature :dkim-signature:from; bh=ks/WY9IQKnnrJ4oAXztzW3W2SS5KA0htj+3VU2cT7Fw=; b=g3vU1j7336gX68QZaTrSx7YENrX1wJtMliMoQkgo2mqxW+qAzNa35ptmZ3tfq8tPMk WY1Dg4ikymyf+xJrOCmL0hS6DyFXfkOkzy4hbNPzFK5abDp/8hXixHZQaCZxGN4NniCY n/noMHrGB1AWdtVhGP9gBVWptyO6tj3NJDXBGD6vQXcKJBp+DyaSnT2cSwH2Kj8ehtGQ PBPsKOVoTGBLxFjlMk1jUBvOpUl40MTnW9XGzh5HiF5JtdJI1WHXqK0HJ2VrVTx2IEoL YJh2NI4i7xRgp2tstwTkx/sQ8vxPFMqZZxAopSAitslrHDbCG420OvCHaCqX/dBgOv+X Oa7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=YNWT00Vq; dkim=neutral (no key) header.i=@linutronix.de header.b=Usrabtos; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y5-20020a17090322c500b001ac718c3fc6si3649911plg.78.2023.05.10.00.34.27; Wed, 10 May 2023 00:34:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=YNWT00Vq; dkim=neutral (no key) header.i=@linutronix.de header.b=Usrabtos; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236513AbjEJHac (ORCPT + 99 others); Wed, 10 May 2023 03:30:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236047AbjEJH3p (ORCPT ); Wed, 10 May 2023 03:29:45 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C76017EF5 for ; Wed, 10 May 2023 00:29:16 -0700 (PDT) From: Anna-Maria Behnsen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683703725; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ks/WY9IQKnnrJ4oAXztzW3W2SS5KA0htj+3VU2cT7Fw=; b=YNWT00Vq66CX/uvbvDqcrmEizrZPabeQfbLr5M9TYIKCEaHPD6CVkw7Z4ng+SWQYKuXXXv +FdM8BTzucsORfCgtBtVMUG98+Z7+OTAYlJ3vMcgwjRY2AYTuWNrqysp5NKxDus9EezH7m AYMRWZs6Xl9PUAgYoDsAxu4GUuJyXMUcR+XVb1PnEwbjQ/AmtyHqXmDDhThY0OAWNbQ/1+ U78VhWr7jgohFzPT0QiTruP4E2hPmU3wI47yv+HNPbBzl4qBdXhKxxqaM+4fFjmeSV3XN/ B0mrAhwQKGDZx0JmIVqBEkl6rBNz5rXC8SQcyA45iQK6HU+WaO7dWn6MpcAB+A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683703725; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ks/WY9IQKnnrJ4oAXztzW3W2SS5KA0htj+3VU2cT7Fw=; b=UsrabtosjXaUg7XSvWhTA2Iq0tnfM/KpXHTqmO/9G4EL1RmH/cl7wxtE66z0MyWhDnRDp6 6qQE2tEWo9FushDg== To: linux-kernel@vger.kernel.org Cc: Peter Zijlstra , John Stultz , Thomas Gleixner , Eric Dumazet , "Rafael J . Wysocki" , Arjan van de Ven , "Paul E . McKenney" , Frederic Weisbecker , Rik van Riel , Steven Rostedt , Sebastian Siewior , Giovanni Gherdovich , Lukasz Luba , "Gautham R . Shenoy" , Anna-Maria Behnsen Subject: [PATCH v6 17/21] timer: Check if timers base is handled already Date: Wed, 10 May 2023 09:28:13 +0200 Message-Id: <20230510072817.116056-18-anna-maria@linutronix.de> In-Reply-To: <20230510072817.116056-1-anna-maria@linutronix.de> References: <20230510072817.116056-1-anna-maria@linutronix.de> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1765491692559628643?= X-GMAIL-MSGID: =?utf-8?q?1765491692559628643?= Due to the conversion of the NOHZ timer placement to a pull at expiry time model, the per CPU timer bases with non pinned timers are no longer handled only by the local CPU. In case a remote CPU already expires the non pinned timers base of the local cpu, nothing more needs to be done by the local CPU. A check at the begin of the expire timers routine is required, because timer base lock is dropped before executing the timer callback function. This is a preparatory work, but has no functional impact right now. Signed-off-by: Anna-Maria Behnsen --- v6: Drop double negation --- kernel/time/timer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kernel/time/timer.c b/kernel/time/timer.c index 61042f1e6f6a..1d7d0d28ef79 100644 --- a/kernel/time/timer.c +++ b/kernel/time/timer.c @@ -2198,6 +2198,9 @@ static inline void __run_timers(struct timer_base *base) lockdep_assert_held(&base->lock); + if (base->running_timer) + return; + while (time_after_eq(jiffies, base->clk) && time_after_eq(jiffies, base->next_expiry)) { levels = collect_expired_timers(base, heads);