diff mbox series

selftests/ftrace: Test toplevel-enable for instance

Message ID 20230509203659.1173917-1-zhengyejian1@huawei.com
State New
Headers
Series selftests/ftrace: Test toplevel-enable for instance |

Commit Message

Zheng Yejian May 9, 2023, 8:36 p.m. UTC 
  'available_events' is actually not required by
'test.d/event/toplevel-enable.tc' and its Existence has been tested in
'test.d/00basic/basic4.tc'.

So the require of 'available_events' can be dropped and then we can add
'instance' flag to test 'test.d/event/toplevel-enable.tc' for instance.

Test result show as below:
 # ./ftracetest test.d/event/toplevel-enable.tc
 === Ftrace unit tests ===
 [1] event tracing - enable/disable with top level files [PASS]
 [2] (instance)  event tracing - enable/disable with top level files [PASS]

 # of passed:  2
 # of failed:  0
 # of unresolved:  0
 # of untested:  0
 # of unsupported:  0
 # of xfailed:  0
 # of undefined(test bug):  0

Signed-off-by: Zheng Yejian <zhengyejian1@huawei.com>
---
 tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Steven Rostedt June 9, 2023, 9:46 p.m. UTC | #1 
On Wed, 10 May 2023 04:36:59 +0800
Zheng Yejian <zhengyejian1@huawei.com> wrote:

> 'available_events' is actually not required by
> 'test.d/event/toplevel-enable.tc' and its Existence has been tested in
> 'test.d/00basic/basic4.tc'.
> 
> So the require of 'available_events' can be dropped and then we can add
> 'instance' flag to test 'test.d/event/toplevel-enable.tc' for instance.
> 
> Test result show as below:
>  # ./ftracetest test.d/event/toplevel-enable.tc
>  === Ftrace unit tests ===
>  [1] event tracing - enable/disable with top level files [PASS]
>  [2] (instance)  event tracing - enable/disable with top level files [PASS]
> 
>  # of passed:  2
>  # of failed:  0
>  # of unresolved:  0
>  # of untested:  0
>  # of unsupported:  0
>  # of xfailed:  0
>  # of undefined(test bug):  0
> 
> Signed-off-by: Zheng Yejian <zhengyejian1@huawei.com>

Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>

-- Steve

> ---
>  tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc b/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc
> index 93c10ea42a68..8b8e1aea985b 100644
> --- a/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc
> +++ b/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc
> @@ -1,7 +1,8 @@
>  #!/bin/sh
>  # SPDX-License-Identifier: GPL-2.0
>  # description: event tracing - enable/disable with top level files
> -# requires: available_events set_event events/enable
> +# requires: set_event events/enable
> +# flags: instance
>  
>  do_reset() {
>      echo > set_event
Steven Rostedt July 10, 2023, 9:54 p.m. UTC | #2 
Hi Shuah,

I think this dropped through the cracks. Can you take this through your
tree?

-- Steve

On Fri, 9 Jun 2023 17:46:26 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Wed, 10 May 2023 04:36:59 +0800
> Zheng Yejian <zhengyejian1@huawei.com> wrote:
> 
> > 'available_events' is actually not required by
> > 'test.d/event/toplevel-enable.tc' and its Existence has been tested in
> > 'test.d/00basic/basic4.tc'.
> > 
> > So the require of 'available_events' can be dropped and then we can add
> > 'instance' flag to test 'test.d/event/toplevel-enable.tc' for instance.
> > 
> > Test result show as below:
> >  # ./ftracetest test.d/event/toplevel-enable.tc
> >  === Ftrace unit tests ===
> >  [1] event tracing - enable/disable with top level files [PASS]
> >  [2] (instance)  event tracing - enable/disable with top level files [PASS]
> > 
> >  # of passed:  2
> >  # of failed:  0
> >  # of unresolved:  0
> >  # of untested:  0
> >  # of unsupported:  0
> >  # of xfailed:  0
> >  # of undefined(test bug):  0
> > 
> > Signed-off-by: Zheng Yejian <zhengyejian1@huawei.com>  
> 
> Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> 
> -- Steve
> 
> > ---
> >  tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc b/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc
> > index 93c10ea42a68..8b8e1aea985b 100644
> > --- a/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc
> > +++ b/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc
> > @@ -1,7 +1,8 @@
> >  #!/bin/sh
> >  # SPDX-License-Identifier: GPL-2.0
> >  # description: event tracing - enable/disable with top level files
> > -# requires: available_events set_event events/enable
> > +# requires: set_event events/enable
> > +# flags: instance
> >  
> >  do_reset() {
> >      echo > set_event
diff mbox series

Patch

diff --git a/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc b/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc
index 93c10ea42a68..8b8e1aea985b 100644
--- a/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc
+++ b/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc
@@ -1,7 +1,8 @@ 
 #!/bin/sh
 # SPDX-License-Identifier: GPL-2.0
 # description: event tracing - enable/disable with top level files
-# requires: available_events set_event events/enable
+# requires: set_event events/enable
+# flags: instance
 
 do_reset() {
     echo > set_event