diff mbox series

[06/12] mm: page_alloc: remove alloc_contig_dump_pages() stub

Message ID 20230508071200.123962-7-wangkefeng.wang@huawei.com
State New
Headers
Series mm: page_alloc: misc cleanup and refector |

Commit Message

Kefeng Wang May 8, 2023, 7:11 a.m. UTC 
  DEFINE_DYNAMIC_DEBUG_METADATA and DYNAMIC_DEBUG_BRANCH already has
stub definitions without dynamic debug feature, remove unnecessary
alloc_contig_dump_pages() stub.

Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
 mm/page_alloc.c | 7 -------
 1 file changed, 7 deletions(-)

Comments

Mike Rapoport May 9, 2023, 4:48 p.m. UTC | #1 
On Mon, May 08, 2023 at 03:11:54PM +0800, Kefeng Wang wrote:
> DEFINE_DYNAMIC_DEBUG_METADATA and DYNAMIC_DEBUG_BRANCH already has
> stub definitions without dynamic debug feature, remove unnecessary
> alloc_contig_dump_pages() stub.
> 
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>

Reviewed-by: Mike Rapoport (IBM) <rppt@kernel.org>

> ---
>  mm/page_alloc.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 348dcbaca757..bc453edbad21 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -6161,8 +6161,6 @@ int percpu_pagelist_high_fraction_sysctl_handler(struct ctl_table *table,
>  }
>  
>  #ifdef CONFIG_CONTIG_ALLOC
> -#if defined(CONFIG_DYNAMIC_DEBUG) || \
> -	(defined(CONFIG_DYNAMIC_DEBUG_CORE) && defined(DYNAMIC_DEBUG_MODULE))
>  /* Usage: See admin-guide/dynamic-debug-howto.rst */
>  static void alloc_contig_dump_pages(struct list_head *page_list)
>  {
> @@ -6176,11 +6174,6 @@ static void alloc_contig_dump_pages(struct list_head *page_list)
>  			dump_page(page, "migration failure");
>  	}
>  }
> -#else
> -static inline void alloc_contig_dump_pages(struct list_head *page_list)
> -{
> -}
> -#endif
>  
>  /* [start, end) must belong to a single zone. */
>  int __alloc_contig_migrate_range(struct compact_control *cc,
> -- 
> 2.35.3
>
diff mbox series

Patch

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 348dcbaca757..bc453edbad21 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -6161,8 +6161,6 @@  int percpu_pagelist_high_fraction_sysctl_handler(struct ctl_table *table,
 }
 
 #ifdef CONFIG_CONTIG_ALLOC
-#if defined(CONFIG_DYNAMIC_DEBUG) || \
-	(defined(CONFIG_DYNAMIC_DEBUG_CORE) && defined(DYNAMIC_DEBUG_MODULE))
 /* Usage: See admin-guide/dynamic-debug-howto.rst */
 static void alloc_contig_dump_pages(struct list_head *page_list)
 {
@@ -6176,11 +6174,6 @@  static void alloc_contig_dump_pages(struct list_head *page_list)
 			dump_page(page, "migration failure");
 	}
 }
-#else
-static inline void alloc_contig_dump_pages(struct list_head *page_list)
-{
-}
-#endif
 
 /* [start, end) must belong to a single zone. */
 int __alloc_contig_migrate_range(struct compact_control *cc,