diff mbox series

[4/6] ARM: dts: msm8226: Add qfprom node

Message ID 20230507201225.89694-5-matti.lehtimaki@gmail.com
State New
Headers
Series Enable MSM8226 TSENS support |

Commit Message

Matti Lehtimäki May 7, 2023, 8:12 p.m. UTC 
  Add missing QFPROM definition for MSM8226 SoC.

Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com>
---
 arch/arm/boot/dts/qcom-msm8226.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Dmitry Baryshkov May 7, 2023, 8:50 p.m. UTC | #1 
On 07/05/2023 23:12, Matti Lehtimäki wrote:
> Add missing QFPROM definition for MSM8226 SoC.
> 
> Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com>
> ---
>   arch/arm/boot/dts/qcom-msm8226.dtsi | 7 +++++++
>   1 file changed, 7 insertions(+)

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Krzysztof Kozlowski May 10, 2023, 1:58 p.m. UTC | #2 
On 07/05/2023 22:12, Matti Lehtimäki wrote:
> Add missing QFPROM definition for MSM8226 SoC.
> 
> Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com>
> ---
>  arch/arm/boot/dts/qcom-msm8226.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-msm8226.dtsi b/arch/arm/boot/dts/qcom-msm8226.dtsi
> index c373081bc21b..c34b8f3139ae 100644
> --- a/arch/arm/boot/dts/qcom-msm8226.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8226.dtsi
> @@ -505,6 +505,13 @@ restart@fc4ab000 {
>  			reg = <0xfc4ab000 0x4>;
>  		};
>  
> +		qfprom: qfprom@fc4bc000 {

We usually call this efuse@

qfprom is Qualcomm specific.

Best regards,
Krzysztof
Dmitry Baryshkov May 10, 2023, 2:14 p.m. UTC | #3 
On Wed, 10 May 2023 at 16:59, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 07/05/2023 22:12, Matti Lehtimäki wrote:
> > Add missing QFPROM definition for MSM8226 SoC.
> >
> > Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com>
> > ---
> >  arch/arm/boot/dts/qcom-msm8226.dtsi | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/qcom-msm8226.dtsi b/arch/arm/boot/dts/qcom-msm8226.dtsi
> > index c373081bc21b..c34b8f3139ae 100644
> > --- a/arch/arm/boot/dts/qcom-msm8226.dtsi
> > +++ b/arch/arm/boot/dts/qcom-msm8226.dtsi
> > @@ -505,6 +505,13 @@ restart@fc4ab000 {
> >                       reg = <0xfc4ab000 0x4>;
> >               };
> >
> > +             qfprom: qfprom@fc4bc000 {
>
> We usually call this efuse@

We have 5 efuse@ and 14 qfprom@ (next/master). But that probably means
that we should rename existing qfprom@ to efuse@.

>
> qfprom is Qualcomm specific.
>
> Best regards,
> Krzysztof
>
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/qcom-msm8226.dtsi b/arch/arm/boot/dts/qcom-msm8226.dtsi
index c373081bc21b..c34b8f3139ae 100644
--- a/arch/arm/boot/dts/qcom-msm8226.dtsi
+++ b/arch/arm/boot/dts/qcom-msm8226.dtsi
@@ -505,6 +505,13 @@  restart@fc4ab000 {
 			reg = <0xfc4ab000 0x4>;
 		};
 
+		qfprom: qfprom@fc4bc000 {
+			compatible = "qcom,msm8226-qfprom", "qcom,qfprom";
+			reg = <0xfc4bc000 0x1000>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+		};
+
 		spmi_bus: spmi@fc4cf000 {
 			compatible = "qcom,spmi-pmic-arb";
 			reg-names = "core", "intr", "cnfg";