From patchwork Sun May 7 14:46:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 90838 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1610414vqo; Sun, 7 May 2023 07:50:25 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5XbyoumvXdrzFJeHX/1URv6ybyZ9OyQYgOdOdAWoW95NbYByGTRvFc5xbhOEueYJjEYVAF X-Received: by 2002:a17:90a:2ec7:b0:24e:456d:270a with SMTP id h7-20020a17090a2ec700b0024e456d270amr7805312pjs.43.1683471025490; Sun, 07 May 2023 07:50:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683471025; cv=none; d=google.com; s=arc-20160816; b=Es4KrX9L7g7buwBF+cGOF8KM/tKoTJLBTn6/clHOT9mJ/c6gCPIkgCkMRViksNKw5P oFgjsPeWGtos8qCtIWPRZCmDdKqnaYZCWFxgF/EG2NQ6H8d6wcczJfOe+bUwrvAOpDqO RYwIhG690T4MR48CTUbCfamfVDtYeBsAI+iXS3ihh3TiIUionmUPTFGeqinGTp/xUS2E YfY1fH3Rrz9bRFXwg9BEnv4rCpYIQOvUvRugIJQ/+VY7tKn1y2RmTtigclxybTrFPQr7 cGbcXNfnk0CNZin7lyC9bWYIZ2kWypoyEEmGJgSdP4itP2ZHeGDvFJS8ZRAGmgb3tM9c TTCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Axa9RQ68hsv/IILOP7fge12GPPTaIZB7pViml3ZGK3o=; b=BfTzRQS4jfRqoVwKHFFuEDki7ePQp64UcNZUHr1IqfYbpUia1fNLgjt8wIoj02h5+J 1/XklUPIZPQEDC/SsdkX5E4Kpbs+5VE/AKMZyHFKfJd3liylXlZWmrAzOXjfeE4VMJmX MN7PQW3fJaO+maR97lZJt0ApY7SSmvJ2DNO/FfJYKO3cS75RnsL/Lp1YEGUfZBc5MpEk vJSJGfbhBh5AjvxlkxOznlxvp4cT++6HjxqyPgvJGLr/ucXwbmwTG+vvquKfw5TBgxIn l+ZBN4Hm7nWdkrPjI+xwRD47L1wfz826UYZ0vfMnh+f6iiL5RW8WLqU2mtPXIEdAGxUv kKhA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZC5rF4Ww; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id rm7-20020a17090b3ec700b0024673e20957si17716259pjb.35.2023.05.07.07.50.10; Sun, 07 May 2023 07:50:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZC5rF4Ww; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231615AbjEGOrE (ORCPT + 99 others); Sun, 7 May 2023 10:47:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229472AbjEGOrC (ORCPT ); Sun, 7 May 2023 10:47:02 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09FF911D89 for ; Sun, 7 May 2023 07:47:01 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-9659f452148so637335966b.1 for ; Sun, 07 May 2023 07:47:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683470819; x=1686062819; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Axa9RQ68hsv/IILOP7fge12GPPTaIZB7pViml3ZGK3o=; b=ZC5rF4Ww89xsCnZB/W2qSgvkRurCeynQHDEJfJW6nuYDODQpHQrra4uAfylCuJyNCf ofm0Z+scRP7HdD0yp1ZAGstWkbZLk7sBzo/vHoOHcwA1ISu4QD5NOQvC9093Fer/MAiJ eQuG5uNWVqwQeC/jlEIj42fpC1cKCtcZhKeX+W1FJsZp6RhHqSALH2LOoEc3dGsYkB+F q05aOknNjx1hAjS/pVzAbhmFarm/BhNCY6++DxWEJg5vUje0alJSYDjQw0XVf0vpqi2T cSeVz8nkSeg39nYMWr0O4RYzSimgecqjAPa9akDajGNbCSx93fdRS6NK7zgSAQqRHFnr O82A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683470819; x=1686062819; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Axa9RQ68hsv/IILOP7fge12GPPTaIZB7pViml3ZGK3o=; b=LVp7bISp97NWDD1B74LAklBeQQ1Oa+4QUIJUr1HfoRj/sGVuOcYZM+gvlSZRYlfDsT M9ka3qcLgAP2xKlq9iCVillE6cw6/Qk5L6/FdPaOCTo/px5IEZJ3MRjIrlXb30nrmiTR CeDwgpfsttSnsYZb6FmL5B5SrcIYSpsD/M/CEgY2zq62RMNy7G2P1LYCQ6kIO0KDYaET tgwkAiO5ddi119ypVbKMWsDVar13OW17ZgZxj39CWhsiknoFSjBlpeXn+YVpmT9Azba6 YNLkIADu6k5W4MpfPyqp0o5Cl23NK3rFWj94nsv9j0KWXPfnOqROzw3ZgMZ4cMmEzjWs OsgA== X-Gm-Message-State: AC+VfDxkDElce31ctiCDGjGU/QoXMPj7b42AvmowjYcnEqSyxQfjhIdv ibxGI8f8lGDQlXSORWCMWiLb/g== X-Received: by 2002:a17:907:1687:b0:94e:1764:b0b5 with SMTP id hc7-20020a170907168700b0094e1764b0b5mr7742438ejc.69.1683470819525; Sun, 07 May 2023 07:46:59 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:1757:b51a:9965:e81]) by smtp.gmail.com with ESMTPSA id mm6-20020a170906cc4600b00958079b676asm3706913ejb.122.2023.05.07.07.46.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 May 2023 07:46:59 -0700 (PDT) From: Krzysztof Kozlowski To: Tony Lindgren , Liam Girdwood , Mark Brown , Jerome Neanne , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , stable@vger.kernel.org, khilman@baylibre.com, msp@baylibre.com, j-keerthy@ti.com Subject: [RESEND PATCH] regulator: tps65219: Fix matching interrupts for their regulators Date: Sun, 7 May 2023 16:46:56 +0200 Message-Id: <20230507144656.192800-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1765247313841932073?= X-GMAIL-MSGID: =?utf-8?q?1765247313841932073?= The driver's probe() first registers regulators in a loop and then in a second loop passes them as irq data to the interrupt handlers. However the function to get the regulator for given name tps65219_get_rdev_by_name() was a no-op due to argument passed by value, not pointer, thus the second loop assigned always same value - from previous loop. The interrupts, when fired, where executed with wrong data. Compiler also noticed it: drivers/regulator/tps65219-regulator.c: In function ‘tps65219_get_rdev_by_name’: drivers/regulator/tps65219-regulator.c:292:60: error: parameter ‘dev’ set but not used [-Werror=unused-but-set-parameter] Fixes: c12ac5fc3e0a ("regulator: drivers: Add TI TPS65219 PMIC regulators support") Cc: Signed-off-by: Krzysztof Kozlowski Reviewed-by: Markus Schneider-Pargmann --- Not tested. Sent two months ago and no comments, so resending. Cc: Jerome Neanne Cc: khilman@baylibre.com Cc: msp@baylibre.com Cc: j-keerthy@ti.com --- drivers/regulator/tps65219-regulator.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/tps65219-regulator.c b/drivers/regulator/tps65219-regulator.c index b1719ee990ab..8971b507a79a 100644 --- a/drivers/regulator/tps65219-regulator.c +++ b/drivers/regulator/tps65219-regulator.c @@ -289,13 +289,13 @@ static irqreturn_t tps65219_regulator_irq_handler(int irq, void *data) static int tps65219_get_rdev_by_name(const char *regulator_name, struct regulator_dev *rdevtbl[7], - struct regulator_dev *dev) + struct regulator_dev **dev) { int i; for (i = 0; i < ARRAY_SIZE(regulators); i++) { if (strcmp(regulator_name, regulators[i].name) == 0) { - dev = rdevtbl[i]; + *dev = rdevtbl[i]; return 0; } } @@ -348,7 +348,7 @@ static int tps65219_regulator_probe(struct platform_device *pdev) irq_data[i].dev = tps->dev; irq_data[i].type = irq_type; - tps65219_get_rdev_by_name(irq_type->regulator_name, rdevtbl, rdev); + tps65219_get_rdev_by_name(irq_type->regulator_name, rdevtbl, &rdev); if (IS_ERR(rdev)) { dev_err(tps->dev, "Failed to get rdev for %s\n", irq_type->regulator_name);