From patchwork Sat May 6 11:16:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoquan He X-Patchwork-Id: 90730 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp995569vqo; Sat, 6 May 2023 04:29:47 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6NOWy3jPzB1Qs8sK2kfi4LUPjR6nVSuYKZFOF5CDTOszAZXrX0qXRdQsYt2VOFSRXJGK3+ X-Received: by 2002:a05:6a20:3d94:b0:d9:6660:8746 with SMTP id s20-20020a056a203d9400b000d966608746mr6808275pzi.18.1683372586749; Sat, 06 May 2023 04:29:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683372586; cv=none; d=google.com; s=arc-20160816; b=cjKpSy4x8BTPXm8pXur8U8nHnMop0g4yflK7UowmiuP8Wj2LVn1ELAX3vv4/uZ2ZhS mr37PmxN995enaJ6LUbWiX2BbI1Gc7G0W7e7FX6kQkuk6AGNoq8PWni8T6y6w48sBJap IRqF6vlNpYVHi1GLYjKHRJCDE7fh2HznXIzvxhMSIFRgSUBiD/T+wrqHxkks63Y52IzN STOKtYmpC6zccRkLVQY5H69P8MnVHNCiwVIRToG9GA+r/6YhASzxloahMQqcivF8tbjU LO20P06jHFXsvNg45hcZjrA5Scz2u6BvLHYb0PiatUVY1w2ylXuZPP27OgCn0dp2FUvp bzfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Qy7lDPZv9XVIVeoAE9BllecWVloA7NmDgrIr51rk+t0=; b=kjj3efacwBWeLRrrELfBEv5RJEtWckVXfYPdPRGhz2+4Ks/7t0jhlUfBrayGr/Rrx1 mD/GG9Qtg30MaTW6GUK7emLFgNyICqJLrUtGVFb+mqgfq3xQpkHSa4T7dphm4yG74xrH dxzdKdU3SeYamwQ4NkvhzieyBdq6JlXYe13bQYjhBSLWD21LF/YmRQG51dSHj2AVUxYe olbGjMqu1wSPolc7/lIpT+9ePMy/msQAriJFQS+wayOvTrQ/zYzi24l9uj/hk4fyC6K9 s7NoP22av5r9V1hnlyxdyO8OyzssnViC9+XWvGd0waCG7RmYq4d87eh8a7013NzlQWOB FNmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="D8M/ujld"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z1-20020a633301000000b0050fad17282dsi3993791pgz.217.2023.05.06.04.29.33; Sat, 06 May 2023 04:29:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="D8M/ujld"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232243AbjEFLRj (ORCPT + 99 others); Sat, 6 May 2023 07:17:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232123AbjEFLRd (ORCPT ); Sat, 6 May 2023 07:17:33 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28E8955A9 for ; Sat, 6 May 2023 04:16:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683371809; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qy7lDPZv9XVIVeoAE9BllecWVloA7NmDgrIr51rk+t0=; b=D8M/ujldGXCmmzXYKpHJhWpxw3HTPJoJp3uktXWQaiMNWM6Kwu1zB3RXDhOCbudrmfuY6u VD2bNkprV9LCNyUcZVgCUfgUzuQK6mzApQqsojF82GEQrROLI6WYx3InNhJQ39IbGX0nqF TVZN1mgZE5Hdw8mXwegPseCHBibV3Ow= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-155-ju83Lpg3MyaunKYUwqTUig-1; Sat, 06 May 2023 07:16:47 -0400 X-MC-Unique: ju83Lpg3MyaunKYUwqTUig-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 161E4380664E; Sat, 6 May 2023 11:16:47 +0000 (UTC) Received: from MiWiFi-R3L-srv.redhat.com (ovpn-12-46.pek2.redhat.com [10.72.12.46]) by smtp.corp.redhat.com (Postfix) with ESMTP id B51692166B31; Sat, 6 May 2023 11:16:41 +0000 (UTC) From: Baoquan He To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, schnelle@linux.ibm.com, linux-s390@vger.kernel.org, Baoquan He , Andy Gross , Bjorn Andersson , Konrad Dybcio , Vinod Koul , linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org Subject: [PATCH RESEND 2/2] dmaengine: make QCOM_HIDMA depend on HAS_IOMEM Date: Sat, 6 May 2023 19:16:28 +0800 Message-Id: <20230506111628.712316-3-bhe@redhat.com> In-Reply-To: <20230506111628.712316-1-bhe@redhat.com> References: <20230506111628.712316-1-bhe@redhat.com> MIME-Version: 1.0 Content-type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1765144093531994724?= X-GMAIL-MSGID: =?utf-8?q?1765144093531994724?= On s390 systems (aka mainframes), it has classic channel devices for networking and permanent storage that are currently even more common than PCI devices. Hence it could have a fully functional s390 kernel with CONFIG_PCI=n, then the relevant iomem mapping functions [including ioremap(), devm_ioremap(), etc.] are not available. Here let QCOM_HIDMA depend on HAS_IOMEM so that it won't be built to cause below compiling error if PCI is unset. -------------------------------------------------------- ld: drivers/dma/qcom/hidma.o: in function `hidma_probe': hidma.c:(.text+0x4b46): undefined reference to `devm_ioremap_resource' ld: hidma.c:(.text+0x4b9e): undefined reference to `devm_ioremap_resource' make[1]: *** [scripts/Makefile.vmlinux:35: vmlinux] Error 1 make: *** [Makefile:1264: vmlinux] Error 2 Signed-off-by: Baoquan He Reviewed-by: Niklas Schnelle Cc: Andy Gross Cc: Bjorn Andersson Cc: Konrad Dybcio Cc: Vinod Koul Cc: linux-arm-msm@vger.kernel.org Cc: dmaengine@vger.kernel.org Reviewed-by: Dmitry Baryshkov --- drivers/dma/qcom/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dma/qcom/Kconfig b/drivers/dma/qcom/Kconfig index 3f926a653bd8..ace75d7b835a 100644 --- a/drivers/dma/qcom/Kconfig +++ b/drivers/dma/qcom/Kconfig @@ -45,6 +45,7 @@ config QCOM_HIDMA_MGMT config QCOM_HIDMA tristate "Qualcomm Technologies HIDMA Channel support" + depends on HAS_IOMEM select DMA_ENGINE help Enable support for the Qualcomm Technologies HIDMA controller.