diff mbox series

dt-bindings: nvmem: add nvmem-cell-cells property

Message ID 20230505091906.1820081-1-peng.fan@oss.nxp.com
State New
Headers
Series dt-bindings: nvmem: add nvmem-cell-cells property |

Commit Message

Peng Fan (OSS) May 5, 2023, 9:19 a.m. UTC 
  From: Peng Fan <peng.fan@nxp.com>

The driver has been using this property, so add it.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 Documentation/devicetree/bindings/nvmem/nvmem.yaml | 3 +++
 1 file changed, 3 insertions(+)

Comments

Rob Herring May 5, 2023, 10:33 a.m. UTC | #1 
On Fri, 05 May 2023 17:19:06 +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> The driver has been using this property, so add it.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  Documentation/devicetree/bindings/nvmem/nvmem.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/nvmem/nvmem.yaml:71:10: [warning] wrong indentation: expected 8 but found 9 (indentation)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230505091906.1820081-1-peng.fan@oss.nxp.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
Rob Herring May 5, 2023, 4:11 p.m. UTC | #2 
On Fri, May 05, 2023 at 05:19:06PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> The driver has been using this property, so add it.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  Documentation/devicetree/bindings/nvmem/nvmem.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/nvmem/nvmem.yaml b/Documentation/devicetree/bindings/nvmem/nvmem.yaml
> index 75bb93dda9df..3fc3982da102 100644
> --- a/Documentation/devicetree/bindings/nvmem/nvmem.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/nvmem.yaml
> @@ -67,6 +67,9 @@ patternProperties:
>              description:
>                Size in bit within the address range specified by reg.
>  
> +      "#nvmem-cell-cells":
> +         const: 1

I don't think we can globally set this to 1. You should have a specific 
nvmem layout that uses and defines it.

Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/nvmem/nvmem.yaml b/Documentation/devicetree/bindings/nvmem/nvmem.yaml
index 75bb93dda9df..3fc3982da102 100644
--- a/Documentation/devicetree/bindings/nvmem/nvmem.yaml
+++ b/Documentation/devicetree/bindings/nvmem/nvmem.yaml
@@ -67,6 +67,9 @@  patternProperties:
             description:
               Size in bit within the address range specified by reg.
 
+      "#nvmem-cell-cells":
+         const: 1
+
 additionalProperties: true
 
 examples: