Message ID | 20230505091733.1819521-1-peng.fan@oss.nxp.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp261890vqo; Fri, 5 May 2023 02:22:35 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6htovpdCaq9W2rM1WQ4WGXS/mwoNYkqFgong9PWEgPvvIIajgFVPtLzOn+PNaQbTE/DaLv X-Received: by 2002:a17:903:1cb:b0:1a6:f5d5:b7f6 with SMTP id e11-20020a17090301cb00b001a6f5d5b7f6mr7675839plh.10.1683278555275; Fri, 05 May 2023 02:22:35 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1683278555; cv=pass; d=google.com; s=arc-20160816; b=s33ttyB26s491UuGmkYTcQXEECluLZEvoDNVoL3cUlR6Sfmo233oQknXebgJL7dKHk hZgrVHSJ3l6Z6yf1yMujqgdRgcB+qrNPm3f/S9kYMXoWDaZLogDnlMYAIBnia8pWNU+R DLRxYlTEs2v81SJShFOMHCBYsQK++Iyfj4zHqUg47mY+YiHXMAVBYpuaxR303U2EmIuN wnXg72XHAEvGrVocElxoFAMAEmWcv2WbK3jU1n0y9NAgXu7doBhthEw52cnnxQbK5r1U Edro/iXbr7jPIt7vWQDA02J1ifsaqfQQYljrJFOpvINcc+RlknS8SBcoiAGhFfDNWgls jiGQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :message-id:date:subject:cc:to:from:dkim-signature; bh=jc9JWIKftSJW1SZOcCLvMxvbKL+9gvaW+2HxIyaevBA=; b=dJh1QSJinruwXqVS6xdpitZgUef98wJy0gQbEameKD9zLqqScsTxuULM9F7SQ6KQGa T31uUGqoDmAuiqojb4VbSI5pK94BsUKAl+oth4idlxkj2Lk3uuy8XwHFF+Txwcf+MX4H f7XudCQqre9UX7iwwOPzPQgagOaYbgbiMP9NZbSUP/XbQ7bGvNXMl7MRAgHsfrZWjL4s HMHqbL6eKmY/DFy47ulOQZ2kQSPdyZ4JJJnuRfe1nWEZ+20Kpl852YInTqkSWAzYyFQy phBrc5BfPtn9J5quENK6XFBHdfPZhEBfhOZfD/lE/5v49i4bARqGp4TN7n0+2VD2zD+B Io2Q== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@NXP1.onmicrosoft.com header.s=selector2-NXP1-onmicrosoft-com header.b=errJwzKD; arc=pass (i=1 spf=pass spfdomain=oss.nxp.com dkim=pass dkdomain=oss.nxp.com dmarc=pass fromdomain=oss.nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 3-20020a17090a194300b0024ffd8aa52bsi3540894pjh.3.2023.05.05.02.22.20; Fri, 05 May 2023 02:22:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@NXP1.onmicrosoft.com header.s=selector2-NXP1-onmicrosoft-com header.b=errJwzKD; arc=pass (i=1 spf=pass spfdomain=oss.nxp.com dkim=pass dkdomain=oss.nxp.com dmarc=pass fromdomain=oss.nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231615AbjEEJMs (ORCPT <rfc822;b08248@gmail.com> + 99 others); Fri, 5 May 2023 05:12:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231516AbjEEJMm (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 5 May 2023 05:12:42 -0400 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2049.outbound.protection.outlook.com [40.107.21.49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51378191FB; Fri, 5 May 2023 02:12:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DBYZhOJbD09uLzvpXpFdkjKJAkd9OoKLZNJTwuCde/xGNsSanyGRLrH4p+IwlrTqZMOyDRSwJkAxBKi7YycW+xTuE83dUyKjGPLo1HhIWAwgGlXu7ssGDheSOAG/AyeR139rzp/Yy4bhNxd7e/GjwPbIIeh4zeY5A1NwT2splBl+qdQcqiE8/WhMEiWG6qP5G82hDtYv/P/gmA34PfWcnI0yIFQi/cL9z/z7lL63dQYGg4+tP9WKpCsIqOayDBusBLUR0Qe04xcaEBpZWmfIf8wq2JQWIPy4/dU1gGO1RBfv4OJB5nGo45gSbneKyLNRw4irce7whqZzs2g9CSNODA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jc9JWIKftSJW1SZOcCLvMxvbKL+9gvaW+2HxIyaevBA=; b=CUT1jO755emieTDDhWwyn/TbFGIdI+R87ouVFJN8HBs4Y8YN/WYoOCkjwT84xz5lI+tnHD4Z3TcmVCmn3GgSIHhuHBHRKJXFeb6DmHAcwWksSwAWcet3ex9rtnfqAk+lVyUdTq7TQ7GBNz7pX8Rw7rCKalafAFG8RsOx8KJ/so/3J206r4hOWg3349XQyIg/V7f2tizjtBl9K63rqYdIfKBEg5hZfKAoLacV1vini4d9INVEzgdpKKn61xTkeL+0jb6p6+IA4LS56j5iC4iifiyjmVoDURy7yGYRHzvfmnZFuBbEhkfwBIPNqkldahO4HE6/EYYKy6jBdsEZPEOZiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jc9JWIKftSJW1SZOcCLvMxvbKL+9gvaW+2HxIyaevBA=; b=errJwzKDy8dI5xK0yV98XAS8YModm66z8mbBPd6PpSn86WofbHUD0L+GA+hZZ2Gg6FV6+ay7NRKMg6LDTEYpK7Na/ehSlFSObNRpIh9Mb4VsM//5BlI857tJhaCA+4M0CO3S/cB5ZFZYuvc/JsvXdskZtgLRjCtv7nGUMGX6tRI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by DB9PR04MB9473.eurprd04.prod.outlook.com (2603:10a6:10:369::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.21; Fri, 5 May 2023 09:12:37 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::b999:f2c6:a8cc:7b4]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::b999:f2c6:a8cc:7b4%4]) with mapi id 15.20.6363.027; Fri, 5 May 2023 09:12:37 +0000 From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com> To: srinivas.kandagatla@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan <peng.fan@nxp.com> Subject: [PATCH 1/2] dt-bindings: nvmem: add binding doc for i.MX OCOTP/ELE Date: Fri, 5 May 2023 17:17:32 +0800 Message-Id: <20230505091733.1819521-1-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.37.1 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SI2P153CA0028.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::9) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|DB9PR04MB9473:EE_ X-MS-Office365-Filtering-Correlation-Id: 390157fd-e56a-48ab-4fa9-08db4d48de58 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AyX8b300UmBlQ7zKTTfCs3mgmaqH8HqmMSv8t+TNMwRZnoPonZYWzxgL1jlBqX9Dh9ksuDE3Vls3EwSZeuMRDe175uNvAw94Aol9nIpBQAZzGMu0/Glk2l1dPC767B+Wxzizq9mka2AsoDIeWN21/SGblkz1rFfSBrVJHhOtblGnFIkKRt6gR2zmI2z8KFyW3eP68Zant5tnQqXYFhO8C9DvkTzGaehrC0TohDax/x0dhg3mFd4WUb/RaEysfuYLtgg22O/JFP78XFLZ/iR9pQ82u2SKdAkhKeXa9xbmImqrwwg3xXWzwcMYQ3XYlyjjbw7KJ24NAXAJUKlL0V0RFXDEpkTVww/B9CYjgZyZaQSycMwxc2BP+6/MQSFrq7Auqxu4wJ3Qs0ShDRdnvudojNkIWEc5ApMH+QpoO+cBd6AivxU5b5KnC5MHX4+zfXo5Y2aCIClx5AxS+T/VSXfun3IKb7E8jaPg0SUQg/IkBzmzfBdUp2qJx377qvNHf5ZJG+pu7pBzjgNkhOPHxu2wdLpfzfidNwfK117ZyzNlnmtHWLkFYMkzfl75Y2tiUzAhQVl8aSniPLfXNqZEAfv/tbjsn7MBJU7096jo4sdwiImO+XKoatC8oD5iQPDqgvXWRqNTdxu1ifLbLDjntViCBQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(346002)(136003)(376002)(366004)(396003)(451199021)(66946007)(2616005)(478600001)(83380400001)(6486002)(6666004)(52116002)(966005)(66476007)(316002)(4326008)(66556008)(26005)(186003)(6506007)(6512007)(1076003)(8936002)(8676002)(7416002)(5660300002)(38350700002)(38100700002)(2906002)(41300700001)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: +bDj4Cci9HgdEesolPK5aFHMKaOlzjp3SZSBuEyRX8mHZTdtIBv6g+TBP3M+IRgq2DbttY34r2zvmLKIjAh+0gpuL4x4IwxQEJt/MMFzCWjIBbouL/v9pYLuKqqUKDAcLhvAF9OxxaLJS3qAkcuYeJ3qbpXnYG2f+OU3IhPL39fDa3g+udD0a0Iz/0iRaUDjNZMYbo9bnP0pf5Rx2PFSTaE1Emp34NdB0Jsfherh3Fy4Jee1f50fs/PVBIJUrf/ysHfGO+X9A3VffqHAObYyB1ZEnJGgYWDVgz6/BUWi6EHrdwaBhEDce5+MjdC7G3jnyVTR3eXrBX/Cr/Oq2Ce94MS1xvYjyJHq0kVsYw/X88ckLCPXh9vIGWJUSpjQm1zAONJo9cCSwiHkKvnRiNRAeasgi4H8hgRGdWZKP2RJ480IeTM93K16MrOAOPs1Cp7IOdn6L8bLE5mLYfqWLssCCrSET7syF+28A/Wv5av2BmpozZxt5m3T+7ZHS0IICt3GwhX+rxpX5Z0AKjxIfkfzYG1tGfXHod+YWAOh7ovnRRwZVOnT8HY9Ph3XslmhiPEG0JDck9NAjIfGUx2gMecZZCPJcsLfEH6p6GgSr3OsUhZf+H3TKnvE1LUyPN0NYQGJD784WPC7n+CrCrtHqrIAYPUMiAHA4cx2TWrvqYNZ3IXdz1Q8/OUKQVgLcSolsi0v6d6+bbfCHmufr4LPkCIqC5cMdhBl2r8sGJWFyL8AToLE5aBc5txN5g/vJe8YbJCOxnQBK3dFVCco0FCBBUU3eOJNfbjuHfWtF15/N9QfFN3Q9ZAHitIz1jhc3+4WoFx8UEk8qhsOlSr966MiPGpoqZZkTiZbleuWrcPvoNyfA7kL160vzGUgw78EOYixnUi7ftNxIGGHEsu7RvUkC9EGcUFzeDD5hvHNV7ovNxkntGkee5WEFbTa/d1EmZLTajHDdg8fMihOp1hs7sYCLM+LN105ZfmW0Zi87VF8lqowYSgIa7E4G/qql+r4RklIza5dI3zT4zQbdxZM160Ob0HV0pj/CObed856kP0Q8xAqoGhGwBMpj6NpDuJ5PYPIn2BaxKe6FZPKzbNZoa+f1f5UoeK/njYsbEsrfuknVk7cuxX53fhK6L2mSoS8yVsQUgQssizoYQ00cnkeme1I5H01OgHoDC9UOC4i5klmXxYVeKGHYwoSqG7q4XTu3KnuiAo3RviGKLMBbdrOfv4Ce9qx1AgiQ2Ym5ZSrJ97hdNn2+J73yHc3m2P2hk+WSnklp7alFddxtiV8KnOy3kHtBEPcJZY9EgKEO+HYcNVdqrN17MjW5Kuxa2O3leGOppkM5HpsIgKLmBq8RYtZ7ScR5ive10EfzPNnFDDyRbbaj5Pq93G39yrF1di6I1VBPWPbI7XmfSnsGwzTFASUP1+Et7sKs09Uyhqb0KDcTcRcAae4DBw5iCjA/WAV22rNq8jo5xGtZ/ilLQbDDCr2Iny8oFc8vDlmV1xJD9xrT0/EuqZ49EHNNHF/CKxEeZAb4wPTUEAfnzX8r1LCWp5co+HuQnOtZNmqcpcH41M6jSxGev6XQbV5/lilRpdJSDTn7Fq6FAhS X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 390157fd-e56a-48ab-4fa9-08db4d48de58 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 09:12:37.0545 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kEzBHdvaKNPaNENgbIg1lYAaPg0yQERW8+RwFElDV5ScTb9U34lEp2Ljz5cJio84ESUa4CMFMajmkUxTD2sg6w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9473 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1765045494663183442?= X-GMAIL-MSGID: =?utf-8?q?1765045494663183442?= |
Series |
[1/2] dt-bindings: nvmem: add binding doc for i.MX OCOTP/ELE
|
|
Commit Message
Peng Fan (OSS)
May 5, 2023, 9:17 a.m. UTC
From: Peng Fan <peng.fan@nxp.com> There are two parts of i.MX93 OCOTP, with 1st part Fuse shadow block(fsb), 2nd part managed by ELE firmware. This binding doc supports both. Signed-off-by: Peng Fan <peng.fan@nxp.com> --- .../bindings/nvmem/imx-ocotp-ele.yaml | 65 +++++++++++++++++++ 1 file changed, 65 insertions(+) create mode 100644 Documentation/devicetree/bindings/nvmem/imx-ocotp-ele.yaml
Comments
Hi, On 23-05-05, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@nxp.com> ... > +examples: > + - | > + #include <dt-bindings/clock/imx6sx-clock.h> > + > + ocotp: efuse@21bc000 { > + #address-cells = <1>; > + #size-cells = <1>; > + compatible = "fsl,imx6sx-ocotp", "syscon"; > + reg = <0x021bc000 0x4000>; > + clocks = <&clks IMX6SX_CLK_OCOTP>; Nit: the "compatible" should be the first property followed by the "reg" property. Regards, Marco > + > + cpu_speed_grade: speed-grade@10 { > + reg = <0x10 4>; > + }; > + > + tempmon_calib: calib@38 { > + reg = <0x38 4>; > + }; > + > + tempmon_temp_grade: temp-grade@20 { > + reg = <0x20 4>; > + }; > + }; > + > +... > -- > 2.37.1 > > >
On 05/05/2023 11:17, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@nxp.com> > > There are two parts of i.MX93 OCOTP, with 1st part Fuse shadow block(fsb), > 2nd part managed by ELE firmware. This binding doc supports both. Subject: drop second/last, redundant "binding doc for". The "dt-bindings" prefix is already stating that these are bindings and documentation. > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > .../bindings/nvmem/imx-ocotp-ele.yaml | 65 +++++++++++++++++++ > 1 file changed, 65 insertions(+) > create mode 100644 Documentation/devicetree/bindings/nvmem/imx-ocotp-ele.yaml > > diff --git a/Documentation/devicetree/bindings/nvmem/imx-ocotp-ele.yaml b/Documentation/devicetree/bindings/nvmem/imx-ocotp-ele.yaml > new file mode 100644 > index 000000000000..024594a2bcb4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/nvmem/imx-ocotp-ele.yaml Filename matching compatible style. fsl,imx93-ocotp.yaml > @@ -0,0 +1,65 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/nvmem/imx-ocotp-ele.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP i.MX9 On-Chip OTP Controller (OCOTP) > + > +maintainers: > + - Peng Fan <peng.fan@nxp.com> > + > +allOf: > + - $ref: nvmem.yaml# > + > +properties: > + compatible: > + oneOf: > + - items: > + - const: fsl,imx93-ocotp-fsb > + - const: syscon > + - items: > + - const: fsl,imx93-ocotp-ele > + > + reg: > + maxItems: 1 > + > + "#address-cells": > + const: 1 Drop > + > + "#size-cells": > + const: 1 Drop > + > + clocks: > + maxItems: 1 > + > +required: > + - compatible Also: reg and clocks > + > +unevaluatedProperties: false > + Best regards, Krzysztof
On 05/05/2023 14:01, Krzysztof Kozlowski wrote: > On 05/05/2023 11:17, Peng Fan (OSS) wrote: >> From: Peng Fan <peng.fan@nxp.com> >> >> There are two parts of i.MX93 OCOTP, with 1st part Fuse shadow block(fsb), >> 2nd part managed by ELE firmware. This binding doc supports both. > > Subject: drop second/last, redundant "binding doc for". The > "dt-bindings" prefix is already stating that these are bindings and > documentation. > >> >> Signed-off-by: Peng Fan <peng.fan@nxp.com> >> --- >> .../bindings/nvmem/imx-ocotp-ele.yaml | 65 +++++++++++++++++++ >> 1 file changed, 65 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/nvmem/imx-ocotp-ele.yaml >> >> diff --git a/Documentation/devicetree/bindings/nvmem/imx-ocotp-ele.yaml b/Documentation/devicetree/bindings/nvmem/imx-ocotp-ele.yaml >> new file mode 100644 >> index 000000000000..024594a2bcb4 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/nvmem/imx-ocotp-ele.yaml > > Filename matching compatible style. fsl,imx93-ocotp.yaml > > >> @@ -0,0 +1,65 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/nvmem/imx-ocotp-ele.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: NXP i.MX9 On-Chip OTP Controller (OCOTP) >> + >> +maintainers: >> + - Peng Fan <peng.fan@nxp.com> >> + >> +allOf: >> + - $ref: nvmem.yaml# >> + >> +properties: >> + compatible: >> + oneOf: >> + - items: >> + - const: fsl,imx93-ocotp-fsb >> + - const: syscon >> + - items: >> + - const: fsl,imx93-ocotp-ele >> + Actually this is the same as existing bindings. Just squash it. However I wonder - why this is syscon? Best regards, Krzysztof
> Subject: Re: [PATCH 1/2] dt-bindings: nvmem: add binding doc for i.MX > OCOTP/ELE > > On 05/05/2023 14:01, Krzysztof Kozlowski wrote: > > On 05/05/2023 11:17, Peng Fan (OSS) wrote: > >> From: Peng Fan <peng.fan@nxp.com> > >> > >> There are two parts of i.MX93 OCOTP, with 1st part Fuse shadow > >> block(fsb), 2nd part managed by ELE firmware. This binding doc supports > both. > > > > Subject: drop second/last, redundant "binding doc for". The > > "dt-bindings" prefix is already stating that these are bindings and > > documentation. > > > >> > >> Signed-off-by: Peng Fan <peng.fan@nxp.com> > >> --- > >> .../bindings/nvmem/imx-ocotp-ele.yaml | 65 +++++++++++++++++++ > >> 1 file changed, 65 insertions(+) > >> create mode 100644 > >> Documentation/devicetree/bindings/nvmem/imx-ocotp-ele.yaml > >> > >> diff --git > >> a/Documentation/devicetree/bindings/nvmem/imx-ocotp-ele.yaml > >> b/Documentation/devicetree/bindings/nvmem/imx-ocotp-ele.yaml > >> new file mode 100644 > >> index 000000000000..024594a2bcb4 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/nvmem/imx-ocotp-ele.yaml > > > > Filename matching compatible style. fsl,imx93-ocotp.yaml > > > > > >> @@ -0,0 +1,65 @@ > >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > >> +--- > >> +$id: > >> > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdev > >> +icetree.org%2Fschemas%2Fnvmem%2Fimx-ocotp- > ele.yaml%23&data=05%7C01%7 > >> > +Cpeng.fan%40nxp.com%7Cd779f2b1abe94a0d493208db4d618fd9%7C686e > a1d3bc2 > >> > +b4c6fa92cd99c5c301635%7C0%7C0%7C638188853636582816%7CUnknown > %7CTWFpb > >> > +GZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXV > CI6M > >> > +n0%3D%7C3000%7C%7C%7C&sdata=2uIFOmUqlbgPIRasl%2FyO0CdZAFPhV > 2qpHnhwKB > >> +OZ008%3D&reserved=0 > >> +$schema: > >> > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdev > >> +icetree.org%2Fmeta- > schemas%2Fcore.yaml%23&data=05%7C01%7Cpeng.fan%40 > >> > +nxp.com%7Cd779f2b1abe94a0d493208db4d618fd9%7C686ea1d3bc2b4c6f > a92cd99 > >> > +c5c301635%7C0%7C0%7C638188853636582816%7CUnknown%7CTWFpbG > Zsb3d8eyJWI > >> > +joiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7 > C3000 > >> > +%7C%7C%7C&sdata=iKJpzjsi7TuqxDim7sUjHmwFR1eK9hFNp2ygMap9bq8% > 3D&reser > >> +ved=0 > >> + > >> +title: NXP i.MX9 On-Chip OTP Controller (OCOTP) > >> + > >> +maintainers: > >> + - Peng Fan <peng.fan@nxp.com> > >> + > >> +allOf: > >> + - $ref: nvmem.yaml# > >> + > >> +properties: > >> + compatible: > >> + oneOf: > >> + - items: > >> + - const: fsl,imx93-ocotp-fsb > >> + - const: syscon > >> + - items: > >> + - const: fsl,imx93-ocotp-ele > >> + > > Actually this is the same as existing bindings. Just squash it. You mean add the compatible to imx-ocotp.yaml? > > However I wonder - why this is syscon? Someone may wanna to use syscon_to_regmap? I just follow imx-ocotp.yaml. Regards, Peng. > > Best regards, > Krzysztof
On 06/05/2023 04:58, Peng Fan wrote: >> Subject: Re: [PATCH 1/2] dt-bindings: nvmem: add binding doc for i.MX >> OCOTP/ELE >> >> On 05/05/2023 14:01, Krzysztof Kozlowski wrote: >>> On 05/05/2023 11:17, Peng Fan (OSS) wrote: >>>> From: Peng Fan <peng.fan@nxp.com> >>>> >>>> There are two parts of i.MX93 OCOTP, with 1st part Fuse shadow >>>> block(fsb), 2nd part managed by ELE firmware. This binding doc supports >> both. >>> >>> Subject: drop second/last, redundant "binding doc for". The >>> "dt-bindings" prefix is already stating that these are bindings and >>> documentation. >>> >>>> >>>> Signed-off-by: Peng Fan <peng.fan@nxp.com> >>>> --- >>>> .../bindings/nvmem/imx-ocotp-ele.yaml | 65 +++++++++++++++++++ >>>> 1 file changed, 65 insertions(+) >>>> create mode 100644 >>>> Documentation/devicetree/bindings/nvmem/imx-ocotp-ele.yaml >>>> >>>> diff --git >>>> a/Documentation/devicetree/bindings/nvmem/imx-ocotp-ele.yaml >>>> b/Documentation/devicetree/bindings/nvmem/imx-ocotp-ele.yaml >>>> new file mode 100644 >>>> index 000000000000..024594a2bcb4 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/nvmem/imx-ocotp-ele.yaml >>> >>> Filename matching compatible style. fsl,imx93-ocotp.yaml >>> >>> >>>> @@ -0,0 +1,65 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 >>>> +--- >>>> +$id: >>>> >> +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdev >>>> +icetree.org%2Fschemas%2Fnvmem%2Fimx-ocotp- >> ele.yaml%23&data=05%7C01%7 >>>> >> +Cpeng.fan%40nxp.com%7Cd779f2b1abe94a0d493208db4d618fd9%7C686e >> a1d3bc2 >>>> >> +b4c6fa92cd99c5c301635%7C0%7C0%7C638188853636582816%7CUnknown >> %7CTWFpb >>>> >> +GZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXV >> CI6M >>>> >> +n0%3D%7C3000%7C%7C%7C&sdata=2uIFOmUqlbgPIRasl%2FyO0CdZAFPhV >> 2qpHnhwKB >>>> +OZ008%3D&reserved=0 >>>> +$schema: >>>> >> +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdev >>>> +icetree.org%2Fmeta- >> schemas%2Fcore.yaml%23&data=05%7C01%7Cpeng.fan%40 >>>> >> +nxp.com%7Cd779f2b1abe94a0d493208db4d618fd9%7C686ea1d3bc2b4c6f >> a92cd99 >>>> >> +c5c301635%7C0%7C0%7C638188853636582816%7CUnknown%7CTWFpbG >> Zsb3d8eyJWI >>>> >> +joiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7 >> C3000 >>>> >> +%7C%7C%7C&sdata=iKJpzjsi7TuqxDim7sUjHmwFR1eK9hFNp2ygMap9bq8% >> 3D&reser >>>> +ved=0 >>>> + >>>> +title: NXP i.MX9 On-Chip OTP Controller (OCOTP) >>>> + >>>> +maintainers: >>>> + - Peng Fan <peng.fan@nxp.com> >>>> + >>>> +allOf: >>>> + - $ref: nvmem.yaml# >>>> + >>>> +properties: >>>> + compatible: >>>> + oneOf: >>>> + - items: >>>> + - const: fsl,imx93-ocotp-fsb >>>> + - const: syscon >>>> + - items: >>>> + - const: fsl,imx93-ocotp-ele >>>> + >> >> Actually this is the same as existing bindings. Just squash it. > > You mean add the compatible to imx-ocotp.yaml? I missed this file, I was thinking about mxs, but sure, can go to imx. All of them are the same... > >> >> However I wonder - why this is syscon? > > Someone may wanna to use syscon_to_regmap? > I just follow imx-ocotp.yaml. That's not a good reason to add syscon. Drop it. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/nvmem/imx-ocotp-ele.yaml b/Documentation/devicetree/bindings/nvmem/imx-ocotp-ele.yaml new file mode 100644 index 000000000000..024594a2bcb4 --- /dev/null +++ b/Documentation/devicetree/bindings/nvmem/imx-ocotp-ele.yaml @@ -0,0 +1,65 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/nvmem/imx-ocotp-ele.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NXP i.MX9 On-Chip OTP Controller (OCOTP) + +maintainers: + - Peng Fan <peng.fan@nxp.com> + +allOf: + - $ref: nvmem.yaml# + +properties: + compatible: + oneOf: + - items: + - const: fsl,imx93-ocotp-fsb + - const: syscon + - items: + - const: fsl,imx93-ocotp-ele + + reg: + maxItems: 1 + + "#address-cells": + const: 1 + + "#size-cells": + const: 1 + + clocks: + maxItems: 1 + +required: + - compatible + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/clock/imx6sx-clock.h> + + ocotp: efuse@21bc000 { + #address-cells = <1>; + #size-cells = <1>; + compatible = "fsl,imx6sx-ocotp", "syscon"; + reg = <0x021bc000 0x4000>; + clocks = <&clks IMX6SX_CLK_OCOTP>; + + cpu_speed_grade: speed-grade@10 { + reg = <0x10 4>; + }; + + tempmon_calib: calib@38 { + reg = <0x38 4>; + }; + + tempmon_temp_grade: temp-grade@20 { + reg = <0x20 4>; + }; + }; + +...