diff mbox series

[v2,1/2] dt-bindings: dma: ti: Add J721S2 BCDMA

Message ID 20230505082602.31783-2-vaishnav.a@ti.com
State New
Headers
Series Add support for J721S2 CSI BCDMA |

Commit Message

Vaishnav Achath May 5, 2023, 8:26 a.m. UTC 
  Add bindings for J721S2 BCDMA instance dedicated for Camera
Serial Interface. Unlike AM62A CSI BCDMA, this instance has RX
and TX channels but lacks block copy channels.

Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com>
---

V1->V2:
     * Move J721S2 BCDMA entry to else condition to avoid failure
     with AM62A BCDMA.

 .../devicetree/bindings/dma/ti/k3-bcdma.yaml  | 54 +++++++++++++------
 1 file changed, 39 insertions(+), 15 deletions(-)

Comments

Krzysztof Kozlowski May 5, 2023, 12:29 p.m. UTC | #1 
On 05/05/2023 10:26, Vaishnav Achath wrote:
> Add bindings for J721S2 BCDMA instance dedicated for Camera
> Serial Interface. Unlike AM62A CSI BCDMA, this instance has RX
> and TX channels but lacks block copy channels.
> 
> Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com>
> ---
> 
> V1->V2:
>      * Move J721S2 BCDMA entry to else condition to avoid failure
>      with AM62A BCDMA.
> 
>  .../devicetree/bindings/dma/ti/k3-bcdma.yaml  | 54 +++++++++++++------
>  1 file changed, 39 insertions(+), 15 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml b/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml
> index beecfe7a1732..54d4b8e0c8ce 100644
> --- a/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml
> +++ b/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml
> @@ -33,6 +33,7 @@ properties:
>      enum:
>        - ti,am62a-dmss-bcdma-csirx
>        - ti,am64-dmss-bcdma
> +      - ti,j721s2-dmss-bcdma-csi
>  
>    reg:
>      minItems: 3
> @@ -152,21 +153,44 @@ allOf:
>          - power-domains
>  
>      else:
> -      properties:
> -        reg:
> -          minItems: 5
> -
> -        reg-names:
> -          items:
> -            - const: gcfg
> -            - const: bchanrt
> -            - const: rchanrt
> -            - const: tchanrt
> -            - const: ringrt
> -
> -      required:
> -        - ti,sci-rm-range-bchan
> -        - ti,sci-rm-range-tchan
> +      if:
> +        properties:
> +          compatible:
> +            contains:
> +              const: ti,j721s2-dmss-bcdma-csi
> +      then:
> +        properties:
> +          ti,sci-rm-range-bchan: false
> +
> +          reg:
> +            maxItems: 4
> +
> +          reg-names:
> +            items:
> +              - const: gcfg
> +              - const: rchanrt
> +              - const: tchanrt
> +              - const: ringrt
> +
> +        required:
> +          - ti,sci-rm-range-tchan
> +
> +      else:

Avoid if:else:if:else and alike. I asked to add one more if covering
this case.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml b/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml
index beecfe7a1732..54d4b8e0c8ce 100644
--- a/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml
+++ b/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml
@@ -33,6 +33,7 @@  properties:
     enum:
       - ti,am62a-dmss-bcdma-csirx
       - ti,am64-dmss-bcdma
+      - ti,j721s2-dmss-bcdma-csi
 
   reg:
     minItems: 3
@@ -152,21 +153,44 @@  allOf:
         - power-domains
 
     else:
-      properties:
-        reg:
-          minItems: 5
-
-        reg-names:
-          items:
-            - const: gcfg
-            - const: bchanrt
-            - const: rchanrt
-            - const: tchanrt
-            - const: ringrt
-
-      required:
-        - ti,sci-rm-range-bchan
-        - ti,sci-rm-range-tchan
+      if:
+        properties:
+          compatible:
+            contains:
+              const: ti,j721s2-dmss-bcdma-csi
+      then:
+        properties:
+          ti,sci-rm-range-bchan: false
+
+          reg:
+            maxItems: 4
+
+          reg-names:
+            items:
+              - const: gcfg
+              - const: rchanrt
+              - const: tchanrt
+              - const: ringrt
+
+        required:
+          - ti,sci-rm-range-tchan
+
+      else:
+        properties:
+          reg:
+            minItems: 5
+
+          reg-names:
+            items:
+              - const: gcfg
+              - const: bchanrt
+              - const: rchanrt
+              - const: tchanrt
+              - const: ringrt
+
+        required:
+          - ti,sci-rm-range-bchan
+          - ti,sci-rm-range-tchan
 
 unevaluatedProperties: false