Message ID | 20230504230727.729539-1-f.fainelli@gmail.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp22387vqo; Thu, 4 May 2023 16:45:32 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6dl6Tjv3OdLcvW9iAnO+zL6w3ky40ygf4Lj6K54gdRnXF+tb3f/xUdudJ3SziFJ7eWgG++ X-Received: by 2002:a17:90a:8283:b0:24e:a0b:426 with SMTP id g3-20020a17090a828300b0024e0a0b0426mr4025397pjn.24.1683243932525; Thu, 04 May 2023 16:45:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683243932; cv=none; d=google.com; s=arc-20160816; b=C7cE8no2pA09IwGx10K2iVUhFinaHKM5+0YcN/ncUmUSg+Sb9DPOtvGPsidGZoul0x lt46rWlAwq8CKOdF0NKV03+OiTp56z4rMByvIsUXt3z/Z59hVjAZjYJ5KovNTBvITLvt wwHut+9HiNnp4cwh1Oi5kCo7cOXukLVUAfJkh11uiDvfgT3oHk+MMSgp2f0CgKp70E1C yJoGJGtjQ1qhZYoYviDgeoRDMxm883AQsaW0eHKjHhhxRunu24/fnH9/j5RktWQOwc0N X5zD+aLHF/KvkgDcCXg1qUUgFAxFYW8dIyZ8BRUUVTtqZtto2NtPhGR81HOeQ31uvbBq ETow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=K/W435ELPheTBswndumHoGwwCmqI4GKA76kRzPB3uIw=; b=U4jQfSfRglwO/62qv98mHaZWonJ1uXEF9HliCKXuIXAXh+Wj3rFL6X7FjDYVE8kmgR G9r3pPL7ISn4fXKxs+FySPcD2DP6qBu5Lk9TXxXUEhipJ4NZXV3OU3lOgcByameU3a0k JuVdC+8ie6zzpv/qG6ygkjtvI6a4Whh4k+9vT9Qr9bf36xG8tzeNUThsBplmnAEE+lfx qc3Y3jij5Fbpw5fdeA+1+1XHD8xZU7G0AhNAAw5fXVRao5xxojHMKAOL4dAx7eLcRq7X McOeUZPV3h1Xcmj7DvQIc2CXldJ7nMkjN2wR9TLWXMhtsW8Mbo1apTbrhQuzrRtx2e06 EL1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=BWDBsJ0R; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x7-20020a17090aca0700b0024dd8ed1373si4810517pjt.185.2023.05.04.16.44.28; Thu, 04 May 2023 16:45:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=BWDBsJ0R; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229680AbjEDXHk (ORCPT <rfc822;b08248@gmail.com> + 99 others); Thu, 4 May 2023 19:07:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229446AbjEDXHi (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 4 May 2023 19:07:38 -0400 Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C53712094; Thu, 4 May 2023 16:07:37 -0700 (PDT) Received: by mail-qt1-x835.google.com with SMTP id d75a77b69052e-3ef5bea20caso4651371cf.3; Thu, 04 May 2023 16:07:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683241656; x=1685833656; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=K/W435ELPheTBswndumHoGwwCmqI4GKA76kRzPB3uIw=; b=BWDBsJ0Rzimf3W7ms+EXKNHW70EVwyfEHUkG5hfMkbJ/Os0x29RnMBe4au9FRa4Lk9 aCzjQNFWtNTToiI1Lq78XCWO9pUtLCi7hCz7PT1qbkG9CIM6n8HKsuMpEHiYl6yEIUCl RyB8GEY6Ykn5OVpepy0+mvlQMeeszvIx8htVFxD4fp4iU+p4eRa8v0vpbMLPmd7nzStr SO5HneJ7+GoobgkFHubBuuSRW8Co/hfQltdzJd2Su59mR7ibeuAAvM6yiRzG8vTjqokB Tcmpm+Gp4Ii+Df32vPQwlLOXhTg07Ch8hSpUhiCfNsHg0n+PKh7n9p8AfFyBaB8vgkDe rdxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683241656; x=1685833656; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=K/W435ELPheTBswndumHoGwwCmqI4GKA76kRzPB3uIw=; b=M9xKzTBHoFmoBzB+SCOakBHLMSEDiCTMdaIAgv1pZDogJoS+qMy1+VTSa+xNHwZTK1 XlDn/BfZR2gAaN3m0/k5w4Z7zyyYvC+GwER0F30zfA0DFw8S1Lgnn/GTbUTH9fSGhsDv PVqxiTLcaW4nxv9BdjF0UTOEWOqOn0vg0ywQ/9RJdFV3fYhH4aWMEPL8iex4K4GRgeSd W45lPaY0oenwJUb3OVIkGrckfiXooHWq6LUzclKU2322Jqugz4fgF3dXcDVYAzZGGHz9 uN2SsuNV9OIcStQ01iY+iHEzLS9ms1Aff5J00R2pGeCPJY7CPsPMCAj3o+CZ1WdBj9pa GXcQ== X-Gm-Message-State: AC+VfDx6ykPfcgSDp4R04nu8z67XTnkeEkYUo5qOFB6fqNeqijMk+XBU xCJTMGHkDALimuhtppBoAc4g+bX4+9o= X-Received: by 2002:ac8:7d46:0:b0:3ef:6393:4bcc with SMTP id h6-20020ac87d46000000b003ef63934bccmr8421423qtb.15.1683241656100; Thu, 04 May 2023 16:07:36 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id b16-20020ac844d0000000b003f0a79e6a8bsm80137qto.28.2023.05.04.16.07.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 May 2023 16:07:35 -0700 (PDT) From: Florian Fainelli <f.fainelli@gmail.com> To: netdev@vger.kernel.org Cc: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, Florian Fainelli <f.fainelli@gmail.com>, Doug Berger <opendmb@gmail.com>, Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, linux-kernel@vger.kernel.org (open list) Subject: [PATCH net] net: bcmgenet: Remove phy_stop() from bcmgenet_netif_stop() Date: Thu, 4 May 2023 16:07:27 -0700 Message-Id: <20230504230727.729539-1-f.fainelli@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1765009189591549802?= X-GMAIL-MSGID: =?utf-8?q?1765009189591549802?= |
Series |
[net] net: bcmgenet: Remove phy_stop() from bcmgenet_netif_stop()
|
|
Commit Message
Florian Fainelli
May 4, 2023, 11:07 p.m. UTC
The call to phy_stop() races with the later call to phy_disconnect(),
resulting in concurrent phy_suspend() calls being run from different
CPUs. The final call to phy_disconnect() ensures that the PHY is
stopped and suspended, too.
Fixes: c96e731c93ff ("net: bcmgenet: connect and disconnect from the PHY state machine")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/net/ethernet/broadcom/genet/bcmgenet.c | 1 -
1 file changed, 1 deletion(-)
Comments
Hello: This patch was applied to netdev/net.git (main) by David S. Miller <davem@davemloft.net>: On Thu, 4 May 2023 16:07:27 -0700 you wrote: > The call to phy_stop() races with the later call to phy_disconnect(), > resulting in concurrent phy_suspend() calls being run from different > CPUs. The final call to phy_disconnect() ensures that the PHY is > stopped and suspended, too. > > Fixes: c96e731c93ff ("net: bcmgenet: connect and disconnect from the PHY state machine") > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> > > [...] Here is the summary with links: - [net] net: bcmgenet: Remove phy_stop() from bcmgenet_netif_stop() https://git.kernel.org/netdev/net/c/93e0401e0fc0 You are awesome, thank you!
diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c index d937daa8ee88..f28ffc31df22 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c @@ -3465,7 +3465,6 @@ static void bcmgenet_netif_stop(struct net_device *dev) /* Disable MAC transmit. TX DMA disabled must be done before this */ umac_enable_set(priv, CMD_TX_EN, false); - phy_stop(dev->phydev); bcmgenet_disable_rx_napi(priv); bcmgenet_intr_disable(priv);